Arcanesoft\Auth\Http\Requests\Backend\Users\UpdateUserRequest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	authorize()	0	4	1
A	rules()	0	12	1
A	all()	0	6	1
A	getRoleIds()	0	6	1

<?php namespace Arcanesoft\Auth\Http\Requests\Backend\Users;

use Arcanesoft\Auth\Bases\FormRequest;
use Illuminate\Support\Facades\Cache;

/**
 * Class     UpdateUserRequest
 *
 * @package  Arcanesoft\Auth\Http\Requests\Backend\Users
 * @author   ARCANEDEV <arcanedev.maroc@gmail.com>
 */
class UpdateUserRequest extends FormRequest
{
    /* ------------------------------------------------------------------------------------------------
     |  Properties
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Role validation rules.
     *
     * @var array
     */
    protected $rules = [
        'username'              => 'required|min:3',
        'email'                 => 'required|email',
        'first_name'            => 'required|min:2',
        'last_name'             => 'required|min:2',
        'password'              => 'required_with:password_confirmation|min:8|confirmed',
        'password_confirmation' => 'required_with:password|min:8',
        'roles'                 => 'required|array|min:1',
    ];

    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        /**  @var \Arcanesoft\Contracts\Auth\Models\User  $user */
        $user  = $this->route('user_id');
        $rules = $this->rules;

        $rules['username'] .= '|unique:users,username,' . $user->id;

Accessing id on the interface Arcanesoft\Contracts\Auth\Models\User suggest that you code against a concrete implementation. How about adding an instanceof check?

        $rules['email']    .= '|unique:users,email,' . $user->id;

Accessing id on the interface Arcanesoft\Contracts\Auth\Models\User suggest that you code against a concrete implementation. How about adding an instanceof check?

        $rules['roles']    .= '|in:' . $this->getRoleIds()->implode(',');

        return $rules;
    }

    /**
     * {@inheritdoc}
     */
    public function all()
    {
        return array_merge(parent::all(), [
            'username' => str_slug($this->get('username'))
        ]);
    }

    /* ------------------------------------------------------------------------------------------------
     |  Other Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Get the role ids.
     *
     * @return \Illuminate\Database\Eloquent\Collection
     */
    private function getRoleIds()
    {
        return Cache::remember('auth.roles.ids', 5, function () {
            return app(\Arcanesoft\Contracts\Auth\Models\Role::class)->lists('id');
        });
    }
}