UserImpersonator::isImpersonating() - Code Metrics - Inspection of "Updating the routes" - ARCANESOFT/Auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 08597b...c6ec6e )

by ARCANEDEV

created 2016-11-24 12:48 UTC

UserImpersonator::isImpersonating() A

↳ Parent: UserImpersonator

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php namespace Arcanesoft\Auth\Helpers;

use Arcanesoft\Contracts\Auth\Models\User;

/**
 * Class     UserImpersonator
 *
 * @package  Arcanesoft\Auth\Helpers
 * @author   ARCANEDEV <[email protected]>
 */
class UserImpersonator
{
    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * @param  \Arcanesoft\Contracts\Auth\Models\User  $user
     *
     * @return bool
     */
    public static function start(User $user)
    {
        if ( ! $user->isMember()) return false;

        session()->put('impersonate', $user->id);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        return true;
    }

    public static function stop()
    {
        session()->forget('impersonate');
    }

    public static function isImpersonating()
    {
        return session()->has('impersonate');
    }
}


1			<?php namespace Arcanesoft\Auth\Helpers;
2
3			use Arcanesoft\Contracts\Auth\Models\User;
4
5			/**
6			* Class UserImpersonator
7			*
8			* @package Arcanesoft\Auth\Helpers
9			* @author ARCANEDEV <[email protected]>
10			*/
11			class UserImpersonator
12			{
13			/* ------------------------------------------------------------------------------------------------
14			\| Main Functions
15			\| ------------------------------------------------------------------------------------------------
16			*/
17			/**
18			* @param \Arcanesoft\Contracts\Auth\Models\User $user
19			*
20			* @return bool
21			*/
22			public static function start(User $user)
23			{
24			if ( ! $user->isMember()) return false;
25
26			session()->put('impersonate', $user->id);
			0 ignored issues – show Bug introduced 2016-11-24 12:52 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Arcanesoft\Contracts\Auth\Models\User` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
27
28			return true;
29			}
30
31			public static function stop()
32			{
33			session()->forget('impersonate');
34			}
35
36			public static function isImpersonating()
37			{
38			return session()->has('impersonate');
39			}
40			}
41

ARCANESOFT / Auth

Push — master ( 08597b...c6ec6e )

UserImpersonator::isImpersonating() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like