UpdateUserRequest::authorize() - Code Metrics - Inspection of "Updating and fixing some random stuff" - ARCANESOFT/Auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 720025...0e57e6 )

by ARCANEDEV

created 2016-12-18 18:39 UTC

UpdateUserRequest::authorize() A

↳ Parent: UpdateUserRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
ccs	0
cts	4
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php namespace Arcanesoft\Auth\Http\Requests\Admin\Users;

/**
 * Class     UpdateUserRequest
 *
 * @package  Arcanesoft\Auth\Http\Requests\Admin\Users
 * @author   ARCANEDEV <[email protected]>
 */
class UpdateUserRequest extends UserFormRequest
{
    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        /** @var \Arcanesoft\Contracts\Auth\Models\User  $user */
        $user = $this->route('auth_user');

        return array_merge(parent::rules(), [
            'username'              => "required|min:3|unique:users,username,{$user->id}",
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'email'                 => "required|email|unique:users,email,{$user->id}",
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'password'              => 'required_with:password_confirmation|min:8|confirmed',
            'password_confirmation' => 'required_with:password',
        ]);
    }
}


Push — master ( 720025...0e57e6 )

UpdateUserRequest::authorize() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1			<?php namespace Arcanesoft\Auth\Http\Requests\Admin\Users;
2
3			/**
4			* Class UpdateUserRequest
5			*
6			* @package Arcanesoft\Auth\Http\Requests\Admin\Users
7			* @author ARCANEDEV <[email protected]>
8			*/
9			class UpdateUserRequest extends UserFormRequest
10			{
11			/* ------------------------------------------------------------------------------------------------
12			\| Main Functions
13			\| ------------------------------------------------------------------------------------------------
14			*/
15			/**
16			* Determine if the user is authorized to make this request.
17			*
18			* @return bool
19			*/
20			public function authorize()
21			{
22			return true;
23			}
24
25			/**
26			* Get the validation rules that apply to the request.
27			*
28			* @return array
29			*/
30			public function rules()
31			{
32			/** @var \Arcanesoft\Contracts\Auth\Models\User $user */
33			$user = $this->route('auth_user');
34
35			return array_merge(parent::rules(), [
36			'username' => "required\|min:3\|unique:users,username,{$user->id}",
			0 ignored issues – show Bug introduced 2016-09-18 17:24 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Arcanesoft\Contracts\Auth\Models\User` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
37			'email' => "required\|email\|unique:users,email,{$user->id}",
			0 ignored issues – show Bug introduced 2016-09-18 17:24 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Arcanesoft\Contracts\Auth\Models\User` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
38			'password' => 'required_with:password_confirmation\|min:8\|confirmed',
39			'password_confirmation' => 'required_with:password',
40			]);
41			}
42			}
43

ARCANESOFT / Auth

Push — master ( 720025...0e57e6 )

UpdateUserRequest::authorize() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like