PasswordResetsController::clear() - Code Metrics - Inspection of "Updating and fixing some random stuff" - ARCANESOFT/Auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 720025...0e57e6 )

by ARCANEDEV

created 2016-12-18 18:39 UTC

PasswordResetsController::clear() A

↳ Parent: PasswordResetsController

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
c	0
b	0
f	0
ccs	0
cts	7
cp	0
rs	9.4285
cc	1
eloc	5
nc	1
nop	0
crap	2

<?php namespace Arcanesoft\Auth\Http\Controllers\Admin;

use Arcanesoft\Auth\Models\PasswordReset;
use Arcanesoft\Auth\Policies\PasswordResetsPolicy;

/**
 * Class     PasswordResetsController
 *
 * @package  Arcanesoft\Auth\Http\Controllers\Admin
 * @author   ARCANEDEV <[email protected]>
 */
class PasswordResetsController extends Controller
{
    /* ------------------------------------------------------------------------------------------------
     |  Properties
     | ------------------------------------------------------------------------------------------------
     */
    /** @var int */
    protected $perPage = 30;

    /* ------------------------------------------------------------------------------------------------
     |  Constructor
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * PasswordResetsController constructor.
     */
    public function __construct()
    {
        parent::__construct();

        $this->setCurrentPage('auth-password-resets');
        $this->addBreadcrumbRoute('Password Resets', 'admin::auth.password-resets.index');
    }

    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    public function index()
    {
        $this->authorize(PasswordResetsPolicy::PERMISSION_LIST);

        $resets = PasswordReset::with(['user'])
            ->orderBy('created_at', 'desc')
            ->paginate($this->perPage);

        $this->setTitle($title = 'List of password resets');
        $this->addBreadcrumb($title);

        return $this->view('admin.password-resets.list', compact('resets'));
    }

    public function delete()
    {
        parent::onlyAjax();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

        $this->authorize(PasswordResetsPolicy::PERMISSION_DELETE);

        return response()->json([]);
    }

    public function clear()
    {
        parent::onlyAjax();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

        $this->authorize(PasswordResetsPolicy::PERMISSION_DELETE);

        PasswordReset::getTokenRepository()->deleteExpired();

        return response()->json(['status' => 'success']);
    }
}


1			<?php namespace Arcanesoft\Auth\Http\Controllers\Admin;
2
3			use Arcanesoft\Auth\Models\PasswordReset;
4			use Arcanesoft\Auth\Policies\PasswordResetsPolicy;
5
6			/**
7			* Class PasswordResetsController
8			*
9			* @package Arcanesoft\Auth\Http\Controllers\Admin
10			* @author ARCANEDEV <[email protected]>
11			*/
12			class PasswordResetsController extends Controller
13			{
14			/* ------------------------------------------------------------------------------------------------
15			\| Properties
16			\| ------------------------------------------------------------------------------------------------
17			*/
18			/** @var int */
19			protected $perPage = 30;
20
21			/* ------------------------------------------------------------------------------------------------
22			\| Constructor
23			\| ------------------------------------------------------------------------------------------------
24			*/
25			/**
26			* PasswordResetsController constructor.
27			*/
28			public function __construct()
29			{
30			parent::__construct();
31
32			$this->setCurrentPage('auth-password-resets');
33			$this->addBreadcrumbRoute('Password Resets', 'admin::auth.password-resets.index');
34			}
35
36			/* ------------------------------------------------------------------------------------------------
37			\| Main Functions
38			\| ------------------------------------------------------------------------------------------------
39			*/
40			public function index()
41			{
42			$this->authorize(PasswordResetsPolicy::PERMISSION_LIST);
43
44			$resets = PasswordReset::with(['user'])
45			->orderBy('created_at', 'desc')
46			->paginate($this->perPage);
47
48			$this->setTitle($title = 'List of password resets');
49			$this->addBreadcrumb($title);
50
51			return $this->view('admin.password-resets.list', compact('resets'));
52			}
53
54			public function delete()
55			{
56			parent::onlyAjax();
			0 ignored issues – show Comprehensibility Bug introduced 2016-10-30 21:33 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`onlyAjax()` instead of `delete()`). Are you sure this is correct? If so, you might want to change this to `$this->onlyAjax()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
57
58			$this->authorize(PasswordResetsPolicy::PERMISSION_DELETE);
59
60			return response()->json([]);
61			}
62
63			public function clear()
64			{
65			parent::onlyAjax();
			0 ignored issues – show Comprehensibility Bug introduced 2016-10-30 21:33 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`onlyAjax()` instead of `clear()`). Are you sure this is correct? If so, you might want to change this to `$this->onlyAjax()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
66
67			$this->authorize(PasswordResetsPolicy::PERMISSION_DELETE);
68
69			PasswordReset::getTokenRepository()->deleteExpired();
70
71			return response()->json(['status' => 'success']);
72			}
73			}
74

ARCANESOFT / Auth

Push — master ( 720025...0e57e6 )

PasswordResetsController::clear() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like