Calculatable - Code Metrics - Inspection of "Adding the LiquidVolume Class" - ARCANEDEV/Units - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by ARCANEDEV

created 2016-08-22 19:24 UTC

Calculatable A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	91
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	91
wmc	6
lcom	1
cbo	0
ccs	24
cts	24
cp	1
rs	10

5 Methods

Rating	Name	Size	Complexity
A	calculate()	15	2
A	add()	8	1
A	sub()	8	1
A	multiply()	6	1
A	divide()	6	1

<?php namespace Arcanedev\Units\Traits;

use Arcanedev\Units\Contracts\UnitMeasure;

/**
 * Trait     Calculatable
 *
 * @package  Arcanedev\Units\Traits
 * @author   ARCANEDEV <[email protected]>
 */
trait Calculatable
{
    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Add the unit instance.
     *
     * @param  \Arcanedev\Units\Contracts\UnitMeasure  $unit
     *
     * @return \Arcanedev\Units\Contracts\UnitMeasure
     */
    public function add(UnitMeasure $unit)
    {
        return $this->setValue(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            static::calculate(
                $this->value(), '+', $unit->to($this->unit())->value()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            )
        );
    }

    /**
     * Sub the unit instance.
     *
     * @param  \Arcanedev\Units\Contracts\UnitMeasure  $unit
     *
     * @return \Arcanedev\Units\Contracts\UnitMeasure
     */
    public function sub(UnitMeasure $unit)
    {
        return $this->setValue(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            static::calculate(
                $this->value(), '-', $unit->to($this->unit())->value()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            )
        );
    }

    /**
     * Multiply unit by the given number.
     *
     * @param  float|int  $number
     *
     * @return \Arcanedev\Units\Contracts\UnitMeasure
     */
    public function multiply($number)
    {
        return $this->setValue(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            static::calculate($this->value(), 'x', $number)
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        );
    }

    /**
     * Divide unit by the given number.
     *
     * @param  float|int  $number
     *
     * @return \Arcanedev\Units\Contracts\Weight
     */
    public function divide($number)
    {
        return $this->setValue(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            static::calculate($this->value(), '/', $number)
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        );
    }

    /**
     * Calculate the value.
     *
     * @param  float|int  $a
     * @param  string     $operator
     * @param  float|int  $b
     *
     * @return float|int
     */
    protected static function calculate($a, $operator, $b)
    {
        $operations = $operations = [
            '+' => function ($a, $b) { return $a + $b; },
            '-' => function ($a, $b) { return $a - $b; },
            'x' => function ($a, $b) { return $a * $b; },
            '*' => function ($a, $b) { return $a * $b; },
            '/' => function ($a, $b) { return $a / $b; },
            '^' => function ($a, $b) { return pow($a, $b); },
        ];

        return array_key_exists($operator, $operations)
            ? call_user_func_array($operations[$operator], [$a, $b])
            : $a;
    }
}


1		<?php namespace Arcanedev\Units\Traits;
2
3		use Arcanedev\Units\Contracts\UnitMeasure;
4
5		/**
6		* Trait Calculatable
7		*
8		* @package Arcanedev\Units\Traits
9		* @author ARCANEDEV <[email protected]>
10		*/
11		trait Calculatable
12		{
13		/* ------------------------------------------------------------------------------------------------
14		\| Main Functions
15		\| ------------------------------------------------------------------------------------------------
16		*/
17		/**
18		* Add the unit instance.
19		*
20		* @param \Arcanedev\Units\Contracts\UnitMeasure $unit
21		*
22		* @return \Arcanedev\Units\Contracts\UnitMeasure
23		*/
24	32	public function add(UnitMeasure $unit)
25		{
26	32	return $this->setValue(
		0 ignored issues – show Bug introduced 2016-08-22 19:28 UTC by Report Bug Copy Issue Report It seems like `setValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27	32	static::calculate(
28	32	$this->value(), '+', $unit->to($this->unit())->value()
		0 ignored issues – show Bug introduced 2016-08-22 19:28 UTC by Report Bug Copy Issue Report It seems like `value()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2016-08-22 19:28 UTC by Report Bug Copy Issue Report It seems like `unit()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29	24	)
30	24	);
31		}
32
33		/**
34		* Sub the unit instance.
35		*
36		* @param \Arcanedev\Units\Contracts\UnitMeasure $unit
37		*
38		* @return \Arcanedev\Units\Contracts\UnitMeasure
39		*/
40	16	public function sub(UnitMeasure $unit)
41		{
42	16	return $this->setValue(
		0 ignored issues – show Bug introduced 2016-08-22 19:28 UTC by Report Bug Copy Issue Report It seems like `setValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
43	16	static::calculate(
44	16	$this->value(), '-', $unit->to($this->unit())->value()
		0 ignored issues – show Bug introduced 2016-08-22 19:28 UTC by Report Bug Copy Issue Report It seems like `value()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2016-08-22 19:28 UTC by Report Bug Copy Issue Report It seems like `unit()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
45	12	)
46	12	);
47		}
48
49		/**
50		* Multiply unit by the given number.
51		*
52		* @param float\|int $number
53		*
54		* @return \Arcanedev\Units\Contracts\UnitMeasure
55		*/
56	16	public function multiply($number)
57		{
58	16	return $this->setValue(
		0 ignored issues – show Bug introduced 2016-08-22 19:28 UTC by Report Bug Copy Issue Report It seems like `setValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
59	16	static::calculate($this->value(), 'x', $number)
		0 ignored issues – show Bug introduced 2016-08-22 19:28 UTC by Report Bug Copy Issue Report It seems like `value()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
60	12	);
61		}
62
63		/**
64		* Divide unit by the given number.
65		*
66		* @param float\|int $number
67		*
68		* @return \Arcanedev\Units\Contracts\Weight
69		*/
70	16	public function divide($number)
71		{
72	16	return $this->setValue(
		0 ignored issues – show Bug introduced 2016-08-22 19:28 UTC by Report Bug Copy Issue Report It seems like `setValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
73	16	static::calculate($this->value(), '/', $number)
		0 ignored issues – show Bug introduced 2016-08-22 19:28 UTC by Report Bug Copy Issue Report It seems like `value()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
74	6	);
75		}
76
77		/**
78		* Calculate the value.
79		*
80		* @param float\|int $a
81		* @param string $operator
82		* @param float\|int $b
83		*
84		* @return float\|int
85		*/
86		protected static function calculate($a, $operator, $b)
87		{
88		$operations = $operations = [
89		'+' => function ($a, $b) { return $a + $b; },
90		'-' => function ($a, $b) { return $a - $b; },
91		'x' => function ($a, $b) { return $a * $b; },
92		'' => function ($a, $b) { return $a $b; },
93		'/' => function ($a, $b) { return $a / $b; },
94		'^' => function ($a, $b) { return pow($a, $b); },
95	246	];
96
97	328	return array_key_exists($operator, $operations)
98	326	? call_user_func_array($operations[$operator], [$a, $b])
99	304	: $a;
100		}
101		}
102

ARCANEDEV / Units

Pull Request — master (#4)

Calculatable A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like