HasFactories - Code Metrics - Inspection of "Update Laravel 7.x support" - ARCANEDEV/Support - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#35)

by ARCANEDEV

created 2020-03-04 08:14 UTC

HasFactories A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
dl	0
loc	37
ccs	0
cts	10
cp	0
c	0
b	0
f	0
rs	10
wmc	4
lcom	1
cbo	0

3 Methods

Rating	Name	Size	Complexity
A	getFactoriesPath()	4	1
A	publishFactories()	6	2
A	loadFactories()	4	1

<?php

declare(strict_types=1);

namespace Arcanedev\Support\Providers\Concerns;

/**
 * Trait     HasFactories
 *
 * @package  Arcanedev\Support\Providers\Concerns
 * @author   ARCANEDEV <[email protected]>
 */
trait HasFactories
{
    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Get the migrations path.
     *
     * @return string
     */
    protected function getFactoriesPath(): string
    {
        return $this->getBasePath().DIRECTORY_SEPARATOR.'database'.DIRECTORY_SEPARATOR.'factories';
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Publish the factories.
     *
     * @param  string|null  $path
     */
    protected function publishFactories(?string $path = null): void
    {
        $this->publishes([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->getFactoriesPath() => $path ?: database_path('factories'),
        ], [$this->package, 'factories', "{$this->package}-factories"]);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Load the factories.
     */
    protected function loadFactories(): void
    {
        $this->loadFactoriesFrom($this->getFactoriesPath());

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Arcanedev\Support\Providers\Concerns;
6
7			/**
8			* Trait HasFactories
9			*
10			* @package Arcanedev\Support\Providers\Concerns
11			* @author ARCANEDEV <[email protected]>
12			*/
13			trait HasFactories
14			{
15			/* -----------------------------------------------------------------
16			\| Main Methods
17			\| -----------------------------------------------------------------
18			*/
19
20			/**
21			* Get the migrations path.
22			*
23			* @return string
24			*/
25			protected function getFactoriesPath(): string
26			{
27			return $this->getBasePath().DIRECTORY_SEPARATOR.'database'.DIRECTORY_SEPARATOR.'factories';
			0 ignored issues – show Bug introduced 2020-03-04 08:19 UTC by Report Bug Copy Issue Report It seems like `getBasePath()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28			}
29
30			/**
31			* Publish the factories.
32			*
33			* @param string\|null $path
34			*/
35			protected function publishFactories(?string $path = null): void
36			{
37			$this->publishes([
			0 ignored issues – show Bug introduced 2020-03-04 08:19 UTC by Report Bug Copy Issue Report It seems like `publishes()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
38			$this->getFactoriesPath() => $path ?: database_path('factories'),
39			], [$this->package, 'factories', "{$this->package}-factories"]);
			0 ignored issues – show Bug introduced 2020-03-04 08:19 UTC by Report Bug Copy Issue Report The property `package` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
40			}
41
42			/**
43			* Load the factories.
44			*/
45			protected function loadFactories(): void
46			{
47			$this->loadFactoriesFrom($this->getFactoriesPath());
			0 ignored issues – show Bug introduced 2020-03-04 08:19 UTC by Report Bug Copy Issue Report The method `loadFactoriesFrom()` does not exist on `Arcanedev\Support\Providers\Concerns\HasFactories`. Did you maybe mean `loadFactories()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
48			}
49			}
50

ARCANEDEV / Support

Pull Request — master (#35)

HasFactories A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like