HasViews - Code Metrics - Inspection of "Updating service providers & composer.json" - ARCANEDEV/Support - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by ARCANEDEV

created 2019-10-02 18:03 UTC

HasViews A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
dl	0
loc	50
ccs	0
cts	14
cp	0
rs	10
c	0
b	0
f	0
wmc	5
lcom	1
cbo	0

4 Methods

Rating	Name	Size	Complexity
A	getViewsPath()	4	1
A	getViewsDestinationPath()	4	1
A	publishViews()	9	2
A	loadViews()	4	1

<?php namespace Arcanedev\Support\Providers\Concerns;

/**
 * Trait     HasViews
 *
 * @package  Arcanedev\Support\Providers\Concerns
 * @author   ARCANEDEV <[email protected]>
 */
trait HasViews
{
    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Get the base views path.
     *
     * @return string
     */
    protected function getViewsPath()
    {
        return $this->getBasePath().DS.'resources'.DS.'views';
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get the destination views path.
     *
     * @return string
     */
    protected function getViewsDestinationPath()
    {
        return $this->app['config']['view.paths'][0].DS.'vendor'.DS.$this->package;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Publish and load the views if $load argument is true.
     *
     * @param  bool  $load
     */
    protected function publishViews($load = true)
    {
        $this->publishes([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->getViewsPath() => $this->getViewsDestinationPath()
        ], 'views');

        if ($load)
            $this->loadViews();
    }

    /**
     * Load the views files.
     */
    protected function loadViews()
    {
        $this->loadViewsFrom($this->getViewsPath(), $this->package);

    }
}


1			<?php namespace Arcanedev\Support\Providers\Concerns;
2
3			/**
4			* Trait HasViews
5			*
6			* @package Arcanedev\Support\Providers\Concerns
7			* @author ARCANEDEV <[email protected]>
8			*/
9			trait HasViews
10			{
11			/* -----------------------------------------------------------------
12			\| Main Methods
13			\| -----------------------------------------------------------------
14			*/
15
16			/**
17			* Get the base views path.
18			*
19			* @return string
20			*/
21			protected function getViewsPath()
22			{
23			return $this->getBasePath().DS.'resources'.DS.'views';
			0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report It seems like `getBasePath()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			}
25
26			/**
27			* Get the destination views path.
28			*
29			* @return string
30			*/
31			protected function getViewsDestinationPath()
32			{
33			return $this->app['config']['view.paths'][0].DS.'vendor'.DS.$this->package;
			0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report The property `app` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report The property `package` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
34			}
35
36			/**
37			* Publish and load the views if $load argument is true.
38			*
39			* @param bool $load
40			*/
41			protected function publishViews($load = true)
42			{
43			$this->publishes([
			0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report It seems like `publishes()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
44			$this->getViewsPath() => $this->getViewsDestinationPath()
45			], 'views');
46
47			if ($load)
48			$this->loadViews();
49			}
50
51			/**
52			* Load the views files.
53			*/
54			protected function loadViews()
55			{
56			$this->loadViewsFrom($this->getViewsPath(), $this->package);
			0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report The method `loadViewsFrom()` does not exist on `Arcanedev\Support\Providers\Concerns\HasViews`. Did you maybe mean `loadViews()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
57			}
58			}
59

ARCANEDEV / Support

Pull Request — master (#30)

HasViews A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like