HasMigrations::loadMigrations() - Code Metrics - Inspection of "Merge pull request #30 from ARCANEDEV/update-packa..." - ARCANEDEV/Support - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cb32ca...f4aa28 )

by ARCANEDEV

created 2019-10-02 18:09 UTC

HasMigrations::loadMigrations() A

↳ Parent: HasMigrations

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	4
ccs	0
cts	3
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php namespace Arcanedev\Support\Providers\Concerns;

/**
 * Trait     HasMigrations
 *
 * @package  Arcanedev\Support\Providers\Concerns
 * @author   ARCANEDEV <[email protected]>
 */
trait HasMigrations
{
    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Get the migrations path.
     *
     * @return string
     */
    protected function getMigrationsPath()
    {
        return $this->getBasePath().DS.'database'.DS.'migrations';
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Publish the migration files.
     */
    protected function publishMigrations()
    {
        $this->publishes([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->getMigrationsPath() => database_path('migrations')
        ], 'migrations');
    }

    /**
     * Load the migrations files.
     */
    protected function loadMigrations()
    {
        $this->loadMigrationsFrom($this->getMigrationsPath());

    }
}


1			<?php namespace Arcanedev\Support\Providers\Concerns;
2
3			/**
4			* Trait HasMigrations
5			*
6			* @package Arcanedev\Support\Providers\Concerns
7			* @author ARCANEDEV <[email protected]>
8			*/
9			trait HasMigrations
10			{
11			/* -----------------------------------------------------------------
12			\| Main Methods
13			\| -----------------------------------------------------------------
14			*/
15
16			/**
17			* Get the migrations path.
18			*
19			* @return string
20			*/
21			protected function getMigrationsPath()
22			{
23			return $this->getBasePath().DS.'database'.DS.'migrations';
			0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report It seems like `getBasePath()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			}
25
26			/**
27			* Publish the migration files.
28			*/
29			protected function publishMigrations()
30			{
31			$this->publishes([
			0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report It seems like `publishes()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32			$this->getMigrationsPath() => database_path('migrations')
33			], 'migrations');
34			}
35
36			/**
37			* Load the migrations files.
38			*/
39			protected function loadMigrations()
40			{
41			$this->loadMigrationsFrom($this->getMigrationsPath());
			0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report The method `loadMigrationsFrom()` does not exist on `Arcanedev\Support\Providers\Concerns\HasMigrations`. Did you maybe mean `loadMigrations()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
42			}
43			}
44

ARCANEDEV / Support

Push — master ( cb32ca...f4aa28 )

HasMigrations::loadMigrations() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like