HasConfig::getConfigFileDestination() - Code Metrics - Inspection of "Merge pull request #30 from ARCANEDEV/update-packa..." - ARCANEDEV/Support - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cb32ca...f4aa28 )

by ARCANEDEV

created 2019-10-02 18:09 UTC

HasConfig::getConfigFileDestination() A

↳ Parent: HasConfig

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	4
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace Arcanedev\Support\Providers\Concerns;

use Illuminate\Support\Str;

/**
 * Trait     HasConfig
 *
 * @package  Arcanedev\Support\Providers\Concerns
 * @author   ARCANEDEV <[email protected]>
 */
trait HasConfig
{
    /* -----------------------------------------------------------------
     |  Properties
     | -----------------------------------------------------------------
     */

    /**
     * Merge multiple config files into one instance (package name as root key)
     *
     * @var bool
     */
    protected $multiConfigs = false;

    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Get config folder.
     *
     * @return string
     */
    protected function getConfigFolder()
    {
        return realpath($this->getBasePath().DS.'config');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get config key.
     *
     * @return string
     */
    protected function getConfigKey()
    {
        return Str::slug($this->package);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get config file path.
     *
     * @return string
     */
    protected function getConfigFile()
    {
        return $this->getConfigFolder().DS."{$this->package}.php";
    }

    /**
     * Get config file destination path.
     *
     * @return string
     */
    protected function getConfigFileDestination()
    {
        return config_path("{$this->package}.php");
    }

    /**
     * Register configs.
     *
     * @param  string  $separator
     */
    protected function registerConfig($separator = '.')
    {
        $this->multiConfigs
            ? $this->registerMultipleConfigs($separator)
            : $this->mergeConfigFrom($this->getConfigFile(), $this->getConfigKey());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Register all package configs.
     *
     * @param  string  $separator
     */
    private function registerMultipleConfigs($separator = '.')
    {
        foreach (glob($this->getConfigFolder().'/*.php') as $configPath) {
            $this->mergeConfigFrom(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                $configPath, $this->getConfigKey().$separator.basename($configPath, '.php')
            );
        }
    }

    /**
     * Publish the config file.
     */
    protected function publishConfig()
    {
        $this->publishes([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->getConfigFile() => $this->getConfigFileDestination()
        ], 'config');
    }
}


1		<?php
2
3		namespace Arcanedev\Support\Providers\Concerns;
4
5		use Illuminate\Support\Str;
6
7		/**
8		* Trait HasConfig
9		*
10		* @package Arcanedev\Support\Providers\Concerns
11		* @author ARCANEDEV <[email protected]>
12		*/
13		trait HasConfig
14		{
15		/* -----------------------------------------------------------------
16		\| Properties
17		\| -----------------------------------------------------------------
18		*/
19
20		/**
21		* Merge multiple config files into one instance (package name as root key)
22		*
23		* @var bool
24		*/
25		protected $multiConfigs = false;
26
27		/* -----------------------------------------------------------------
28		\| Main Methods
29		\| -----------------------------------------------------------------
30		*/
31
32		/**
33		* Get config folder.
34		*
35		* @return string
36		*/
37		protected function getConfigFolder()
38		{
39		return realpath($this->getBasePath().DS.'config');
		0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report It seems like `getBasePath()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
40		}
41
42		/**
43		* Get config key.
44		*
45		* @return string
46		*/
47	6	protected function getConfigKey()
48		{
49	6	return Str::slug($this->package);
		0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report The property `package` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
50		}
51
52		/**
53		* Get config file path.
54		*
55		* @return string
56		*/
57	6	protected function getConfigFile()
58		{
59	6	return $this->getConfigFolder().DS."{$this->package}.php";
60		}
61
62		/**
63		* Get config file destination path.
64		*
65		* @return string
66		*/
67		protected function getConfigFileDestination()
68		{
69		return config_path("{$this->package}.php");
70		}
71
72		/**
73		* Register configs.
74		*
75		* @param string $separator
76		*/
77	6	protected function registerConfig($separator = '.')
78		{
79	6	$this->multiConfigs
80		? $this->registerMultipleConfigs($separator)
81	6	: $this->mergeConfigFrom($this->getConfigFile(), $this->getConfigKey());
		0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report It seems like `mergeConfigFrom()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
82	6	}
83
84		/**
85		* Register all package configs.
86		*
87		* @param string $separator
88		*/
89		private function registerMultipleConfigs($separator = '.')
90		{
91		foreach (glob($this->getConfigFolder().'/*.php') as $configPath) {
92		$this->mergeConfigFrom(
		0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report It seems like `mergeConfigFrom()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
93		$configPath, $this->getConfigKey().$separator.basename($configPath, '.php')
94		);
95		}
96		}
97
98		/**
99		* Publish the config file.
100		*/
101		protected function publishConfig()
102		{
103		$this->publishes([
		0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report It seems like `publishes()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
104		$this->getConfigFile() => $this->getConfigFileDestination()
105		], 'config');
106		}
107		}
108

ARCANEDEV / Support

Push — master ( cb32ca...f4aa28 )

HasConfig::getConfigFileDestination() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like