HasViews - Code Metrics - ARCANEDEV/Support - Measure and Improve Code Quality continuously with Scrutinizer

HasViews A
last analyzed 2021-02-26 17:52 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
dl	0
loc	47
ccs	0
cts	12
cp	0
rs	10
c	0
b	0
f	0
wmc	5
lcom	1
cbo	0

4 Methods

Rating	Name	Size	Complexity
A	loadViews()	4	1
A	getViewsPath()	4	1
A	getViewsDestinationPath()	4	1
A	publishViews()	6	2

<?php

declare(strict_types=1);

namespace Arcanedev\Support\Providers\Concerns;

/**
 * Trait     HasViews
 *
 * @author   ARCANEDEV <[email protected]>
 */
trait HasViews
{
    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Get the base views path.
     *
     * @return string
     */
    protected function getViewsPath(): string
    {
        return $this->getBasePath().DIRECTORY_SEPARATOR.'views';
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get the destination views path.
     *
     * @return string
     */
    protected function getViewsDestinationPath(): string
    {
        return $this->app['config']['view.paths'][0].DIRECTORY_SEPARATOR.'vendor'.DIRECTORY_SEPARATOR.$this->getPackageName();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Publish the views.
     *
     * @param  string|null  $path
     */
    protected function publishViews(?string $path = null): void
    {
        $this->publishes([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->getViewsPath() => $path ?: $this->getViewsDestinationPath(),
        ], $this->getPublishedTags('views'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Load the views files.
     */
    protected function loadViews(): void
    {
        $this->loadViewsFrom($this->getViewsPath(), $this->getPackageName());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Arcanedev\Support\Providers\Concerns;
6
7			/**
8			* Trait HasViews
9			*
10			* @author ARCANEDEV <[email protected]>
11			*/
12			trait HasViews
13			{
14			/* -----------------------------------------------------------------
15			\| Main Methods
16			\| -----------------------------------------------------------------
17			*/
18
19			/**
20			* Get the base views path.
21			*
22			* @return string
23			*/
24			protected function getViewsPath(): string
25			{
26			return $this->getBasePath().DIRECTORY_SEPARATOR.'views';
			0 ignored issues – show Bug introduced 2020-03-04 08:19 UTC by Report Bug Copy Issue Report It seems like `getBasePath()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			}
28
29			/**
30			* Get the destination views path.
31			*
32			* @return string
33			*/
34			protected function getViewsDestinationPath(): string
35			{
36			return $this->app['config']['view.paths'][0].DIRECTORY_SEPARATOR.'vendor'.DIRECTORY_SEPARATOR.$this->getPackageName();
			0 ignored issues – show Bug introduced 2020-03-04 08:19 UTC by Report Bug Copy Issue Report The property `app` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2020-03-08 13:21 UTC by Report Bug Copy Issue Report It seems like `getPackageName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
37			}
38
39			/**
40			* Publish the views.
41			*
42			* @param string\|null $path
43			*/
44			protected function publishViews(?string $path = null): void
45			{
46			$this->publishes([
			0 ignored issues – show Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report It seems like `publishes()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
47			$this->getViewsPath() => $path ?: $this->getViewsDestinationPath(),
48			], $this->getPublishedTags('views'));
			0 ignored issues – show Bug introduced 2020-03-08 13:21 UTC by Report Bug Copy Issue Report It seems like `getPublishedTags()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
49			}
50
51			/**
52			* Load the views files.
53			*/
54			protected function loadViews(): void
55			{
56			$this->loadViewsFrom($this->getViewsPath(), $this->getPackageName());
			0 ignored issues – show Bug introduced 2020-03-08 13:21 UTC by Report Bug Copy Issue Report It seems like `getPackageName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2019-10-02 18:06 UTC by Report Bug Copy Issue Report The method `loadViewsFrom()` does not exist on `Arcanedev\Support\Providers\Concerns\HasViews`. Did you maybe mean `loadViews()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
57			}
58			}
59

ARCANEDEV / Support

HasViews A last analyzed 2021-02-26 17:52 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like

HasViews A
last analyzed 2021-02-26 17:52 UTC