Issues in StripeOAuth.php (master) - Issues in master - ARCANEDEV/Stripe - Measure and Improve Code Quality continuously with Scrutinizer

Issues (16)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/StripeOAuth.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php namespace Arcanedev\Stripe;

/**
 * Class     StripeOAuth
 *
 * @package  Arcanedev\Stripe
 * @author   ARCANEDEV <[email protected]>
 */
abstract class StripeOAuth
{
    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Generates a URL to Stripe's OAuth form.
     *
     * @param  array|null  $params
     * @param  array|null  $options
     *
     * @return string
     */
    public static function authorizeUrl($params = null, $options = null)
    {
        if ( ! $params)
            $params = [];

        $params['client_id'] = self::getClientId($params);

        if ( ! array_key_exists('response_type', $params))
            $params['response_type'] = 'code';

        $base = ($options && array_key_exists('connect_base', $options))
            ? $options['connect_base']
            : Stripe::$connectBase;

        return $base.'/oauth/authorize?'.str_url_queries($params);
    }

    /**
     * Use an authorization code to connect an account to your platform and fetch the user's credentials.
     *
     * @param  array|null  $params
     * @param  array|null  $options
     *
     * @return \Arcanedev\Stripe\StripeObject
     */
    public static function token($params = null, $options = null)
    {
        $base = ($options && array_key_exists('connect_base', $options))
            ? $options['connect_base']
            : Stripe::$connectBase;

        /** @var  \Arcanedev\Stripe\Http\Response  $response */
        list($response, $apiKey) = Http\Requestor::make(null, $base)->request(
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
            'post',
            '/oauth/token',
            $params,
            null
        );

        return Utilities\Util::convertToStripeObject($response->getJson(), $options);

    }

    /**
     * Disconnects an account from your platform.
     *
     * @param  array|null  $params
     * @param  array|null  $options
     *
     * @return \Arcanedev\Stripe\StripeObject
     */
    public static function deauthorize($params = null, $options = null)
    {
        if ( ! $params)
            $params = [];

        $base = ($options && array_key_exists('connect_base', $options))
            ? $options['connect_base']
            : Stripe::$connectBase;

        $params['client_id'] = self::getClientId($params);

        list($response, $apiKey) = Http\Requestor::make(null, $base)->request(
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
            'post',
            '/oauth/deauthorize',
            $params,
            null
        );

        return Utilities\Util::convertToStripeObject($response->getJson(), $options);

    }

    /* -----------------------------------------------------------------
     |  Other Methods
     | -----------------------------------------------------------------
     */

    private static function getClientId($params = null)
    {
        $clientId = ($params && array_key_exists('client_id', $params)) ? $params['client_id'] : null;

        if ($clientId === null)
            $clientId = Stripe::getClientId();

        if ($clientId === null) {
            throw new Exceptions\AuthenticationException(
                'No client_id provided.  (HINT: set your client_id using '
                . '"Stripe::setClientId(<CLIENT-ID>)".  You can find your client_ids '
                . 'in your Stripe dashboard at '
                . 'https://dashboard.stripe.com/account/applications/settings, '
                . 'after registering your account as a platform. See '
                . 'https://stripe.com/docs/connect/standard-accounts for details, '
                . 'or email [email protected] if you have any questions.'
            );
        }

        return $clientId;
    }
}


1		<?php namespace Arcanedev\Stripe;
2
3		/**
4		* Class StripeOAuth
5		*
6		* @package Arcanedev\Stripe
7		* @author ARCANEDEV <[email protected]>
8		*/
9		abstract class StripeOAuth
10		{
11		/* -----------------------------------------------------------------
12		\| Main Methods
13		\| -----------------------------------------------------------------
14		*/
15
16		/**
17		* Generates a URL to Stripe's OAuth form.
18		*
19		* @param array\|null $params
20		* @param array\|null $options
21		*
22		* @return string
23		*/
24	2	public static function authorizeUrl($params = null, $options = null)
25		{
26	2	if ( ! $params)
27		$params = [];
28
29	2	$params['client_id'] = self::getClientId($params);
30
31	2	if ( ! array_key_exists('response_type', $params))
32	2	$params['response_type'] = 'code';
33
34	2	$base = ($options && array_key_exists('connect_base', $options))
35		? $options['connect_base']
36	2	: Stripe::$connectBase;
37
38	2	return $base.'/oauth/authorize?'.str_url_queries($params);
39		}
40
41		/**
42		* Use an authorization code to connect an account to your platform and fetch the user's credentials.
43		*
44		* @param array\|null $params
45		* @param array\|null $options
46		*
47		* @return \Arcanedev\Stripe\StripeObject
48		*/
49	6	public static function token($params = null, $options = null)
50		{
51	6	$base = ($options && array_key_exists('connect_base', $options))
52		? $options['connect_base']
53	6	: Stripe::$connectBase;
54
55		/** @var \Arcanedev\Stripe\Http\Response $response */
56	6	list($response, $apiKey) = Http\Requestor::make(null, $base)->request(
		0 ignored issues – show Unused Code introduced 2017-10-25 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$apiKey` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
57	6	'post',
58	6	'/oauth/token',
59	6	$params,
60	6	null
61		);
62
63	2	return Utilities\Util::convertToStripeObject($response->getJson(), $options);
		0 ignored issues – show Bug introduced 2017-10-25 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$response->getJson()` targeting `Arcanedev\Stripe\Http\Response::getJson()` can also be of type `null`; however, `Arcanedev\Stripe\Utiliti...convertToStripeObject()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Bug introduced 2017-10-25 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$options` defined by parameter `$options` on line 49 can also be of type `null`; however, `Arcanedev\Stripe\Utiliti...convertToStripeObject()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Bug Compatibility introduced 2017-10-25 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `\Arcanedev\Stripe\Utilit...->getJson(), $options);` of type `Arcanedev\Stripe\StripeO...Stripe\Collection\|array` adds the type `array` to the return on line 63 which is incompatible with the return type documented by `Arcanedev\Stripe\StripeOAuth::token` of type `Arcanedev\Stripe\StripeObject`. Loading history...
64		}
65
66		/**
67		* Disconnects an account from your platform.
68		*
69		* @param array\|null $params
70		* @param array\|null $options
71		*
72		* @return \Arcanedev\Stripe\StripeObject
73		*/
74	4	public static function deauthorize($params = null, $options = null)
75		{
76	4	if ( ! $params)
77		$params = [];
78
79	4	$base = ($options && array_key_exists('connect_base', $options))
80		? $options['connect_base']
81	4	: Stripe::$connectBase;
82
83	4	$params['client_id'] = self::getClientId($params);
84
85	4	list($response, $apiKey) = Http\Requestor::make(null, $base)->request(
		0 ignored issues – show Unused Code introduced 2017-10-25 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$apiKey` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
86	4	'post',
87	4	'/oauth/deauthorize',
88	4	$params,
89	4	null
90		);
91
92	4	return Utilities\Util::convertToStripeObject($response->getJson(), $options);
		0 ignored issues – show Bug introduced 2017-10-25 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$options` defined by parameter `$options` on line 74 can also be of type `null`; however, `Arcanedev\Stripe\Utiliti...convertToStripeObject()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Bug Compatibility introduced 2017-10-25 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `\Arcanedev\Stripe\Utilit...->getJson(), $options);` of type `Arcanedev\Stripe\StripeO...Stripe\Collection\|array` adds the type `array` to the return on line 92 which is incompatible with the return type documented by `Arcanedev\Stripe\StripeOAuth::deauthorize` of type `Arcanedev\Stripe\StripeObject`. Loading history...
93		}
94
95		/* -----------------------------------------------------------------
96		\| Other Methods
97		\| -----------------------------------------------------------------
98		*/
99
100	6	private static function getClientId($params = null)
101		{
102	6	$clientId = ($params && array_key_exists('client_id', $params)) ? $params['client_id'] : null;
103
104	6	if ($clientId === null)
105	6	$clientId = Stripe::getClientId();
106
107	6	if ($clientId === null) {
108		throw new Exceptions\AuthenticationException(
109		'No client_id provided. (HINT: set your client_id using '
110		. '"Stripe::setClientId(<CLIENT-ID>)". You can find your client_ids '
111		. 'in your Stripe dashboard at '
112		. 'https://dashboard.stripe.com/account/applications/settings, '
113		. 'after registering your account as a platform. See '
114		. 'https://stripe.com/docs/connect/standard-accounts for details, '
115		. 'or email [email protected] if you have any questions.'
116		);
117		}
118
119	6	return $clientId;
120		}
121		}
122

ARCANEDEV / Stripe

Issues (16)

Security Analysis no request data

src/StripeOAuth.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like