Arcanedev\MissingUrlsRedirector\Helpers\RouteMaker

Complexity

Total Complexity

5

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	makeCollection()	0	14	3
A	makeRoute()	0	8	1
A	parseAction()	0	11	1

<?php

declare(strict_types=1);

namespace Arcanedev\MissingUrlsRedirector\Helpers;

use Arcanedev\MissingUrlsRedirector\Entities\{Redirection, RedirectionCollection};
use Arcanedev\MissingUrlsRedirector\Events\RouteRedirected;
use Illuminate\Routing\{Route, RouteAction, RouteCollection};

/**
 * Class     RouteMaker
 *
 * @package  Arcanedev\MissingUrlsRedirector\Helpers
 * @author   ARCANEDEV <arcanedev.maroc@gmail.com>
 */
class RouteMaker
{
    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Make routes collection.
     *
     * @param  \Arcanedev\MissingUrlsRedirector\Entities\RedirectionCollection  $redirections
     *
     * @return \Illuminate\Routing\RouteCollection
     */
    public static function makeCollection(RedirectionCollection $redirections): RouteCollection
    {
        $routes = new RouteCollection;

        foreach ($redirections as $group) {
            foreach ($group as $redirection) {
                /** @var  \Arcanedev\MissingUrlsRedirector\Entities\Redirection  $redirection */
                $routes->add($route = static::makeRoute($redirection));
                $redirection->setRoute($route);
            }
        }

        return $routes;
    }

    /**
     * Make a route.
     *
     * @param  \Arcanedev\MissingUrlsRedirector\Entities\Redirection  $redirection
     *
     * @return \Illuminate\Routing\Route
     */
    public static function makeRoute(Redirection $redirection): Route
    {
        $route = new Route(['GET', 'HEAD'], $redirection->getFrom(), []);

        return $route->setAction(
            static::parseAction($route, $redirection)

Since parseAction() is declared private, calling it with static will lead to errors in possible sub-classes. You can either use self, or increase the visibility of parseAction() to at least protected.

        );
    }

    /* -----------------------------------------------------------------
     |  Other Methods
     | -----------------------------------------------------------------
     */

    /**
     * Resolve the router parameters.
     *
     * @param  \Illuminate\Routing\Route                              $route
     * @param  \Arcanedev\MissingUrlsRedirector\Entities\Redirection  $redirection
     *
     * @return array
     */
    private static function parseAction(Route $route, Redirection $redirection): array
    {
        return RouteAction::parse($route->uri(), function () use ($redirection, $route) {
            event(new RouteRedirected($redirection));

            return redirect()->to(
                $redirection->getResolvedUrl(),
                $redirection->getStatus()
            );
        });
    }
}