RouteServiceProvider::map() - Code Metrics - Inspection of "Merge pull request #364 from ARCANEDEV/develop" - ARCANEDEV/LogViewer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 46643f...f8548b )

by ARCANEDEV

created 2020-09-09 09:37 UTC

RouteServiceProvider::map() A

↳ Parent: RouteServiceProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
nc	2
nop	0
dl	0
loc	8
rs	10
c	0
b	0
f	0
ccs	5
cts	5
cp	1
crap	2

<?php

declare(strict_types=1);

namespace Arcanedev\LogViewer\Providers;

use Arcanedev\LogViewer\Http\Routes\LogViewerRoute;
use Arcanedev\Support\Providers\RouteServiceProvider as ServiceProvider;

/**
 * Class     RouteServiceProvider
 *
 * @author   ARCANEDEV <[email protected]>
 */
class RouteServiceProvider extends ServiceProvider
{
    /* -----------------------------------------------------------------
     |  Getters & Setters
     | -----------------------------------------------------------------
     */

    /**
     * Check if routes is enabled
     *
     * @return bool
     */
    public function isEnabled(): bool
    {
        return (bool) $this->config('enabled', false);
    }

    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Boot the service provider.
     */
    public function boot(): void
    {
        if ($this->isEnabled()) {
            $this->routes(function () {
                static::mapRouteClasses([LogViewerRoute::class]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            });
        }
    }

    /* -----------------------------------------------------------------
     |  Other Methods
     | -----------------------------------------------------------------
     */

    /**
     * Get config value by key
     *
     * @param  string      $key
     * @param  mixed|null  $default
     *
     * @return mixed
     */
    private function config($key, $default = null)
    {
        return $this->app['config']->get("log-viewer.route.$key", $default);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Arcanedev\LogViewer\Providers;
6
7		use Arcanedev\LogViewer\Http\Routes\LogViewerRoute;
8		use Arcanedev\Support\Providers\RouteServiceProvider as ServiceProvider;
9
10		/**
11		* Class RouteServiceProvider
12		*
13		* @author ARCANEDEV <[email protected]>
14		*/
15		class RouteServiceProvider extends ServiceProvider
16		{
17		/* -----------------------------------------------------------------
18		\| Getters & Setters
19		\| -----------------------------------------------------------------
20		*/
21
22		/**
23		* Check if routes is enabled
24		*
25		* @return bool
26		*/
27	596	public function isEnabled(): bool
28		{
29	596	return (bool) $this->config('enabled', false);
30		}
31
32		/* -----------------------------------------------------------------
33		\| Main Methods
34		\| -----------------------------------------------------------------
35		*/
36
37		/**
38		* Boot the service provider.
39		*/
40	596	public function boot(): void
41		{
42	596	if ($this->isEnabled()) {
43	596	$this->routes(function () {
44	298	static::mapRouteClasses([LogViewerRoute::class]);
		0 ignored issues – show Documentation introduced 2020-09-03 12:32 UTC by Report Bug Copy Issue Report `array(\Arcanedev\LogView...\LogViewerRoute::class)` is of type `array<integer,?>`, but the function expects a `object<Arcanedev\Support...ting\Concerns\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
45	596	});
46		}
47	596	}
48
49		/* -----------------------------------------------------------------
50		\| Other Methods
51		\| -----------------------------------------------------------------
52		*/
53
54		/**
55		* Get config value by key
56		*
57		* @param string $key
58		* @param mixed\|null $default
59		*
60		* @return mixed
61		*/
62	596	private function config($key, $default = null)
63		{
64	596	return $this->app['config']->get("log-viewer.route.$key", $default);
65		}
66		}
67

ARCANEDEV / LogViewer

Push — master ( 46643f...f8548b )

RouteServiceProvider::map() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like