RouteServiceProvider::routeAttributes() - Code Metrics - Inspection of "Merge pull request #354 from ARCANEDEV/patch-route..." - ARCANEDEV/LogViewer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e36039...46643f )

by ARCANEDEV

created 2020-07-06 08:31 UTC

RouteServiceProvider::routeAttributes() A

↳ Parent: RouteServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0
ccs	0
cts	2
cp	0
crap	2

<?php namespace Arcanedev\LogViewer\Providers;

use Arcanedev\LogViewer\Http\Routes\LogViewerRoute;
use Arcanedev\Support\Providers\RouteServiceProvider as ServiceProvider;

/**
 * Class     RouteServiceProvider
 *
 * @package  Arcanedev\LogViewer\Providers
 * @author   ARCANEDEV <[email protected]>
 */
class RouteServiceProvider extends ServiceProvider
{
    /* -----------------------------------------------------------------
     |  Getters & Setters
     | -----------------------------------------------------------------
     */

    /**
     * Get Route attributes
     *
     * @return array
     */
    public function routeAttributes()
    {
        return (array) $this->config('attributes');
    }

    /**
     * Check if routes is enabled
     *
     * @return bool
     */
    public function isEnabled()
    {
        return $this->config('enabled', false);
    }

    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Define the routes for the application.
     */
    public function map(): void
    {
        if ($this->isEnabled()) {
            static::mapRouteClasses([
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                LogViewerRoute::class,
            ]);
        }
    }

    /* -----------------------------------------------------------------
     |  Other Methods
     | -----------------------------------------------------------------
     */

    /**
     * Get config value by key
     *
     * @param  string      $key
     * @param  mixed|null  $default
     *
     * @return mixed
     */
    private function config($key, $default = null)
    {
        return $this->app['config']->get("log-viewer.route.$key", $default);
    }
}


1		<?php namespace Arcanedev\LogViewer\Providers;
2
3		use Arcanedev\LogViewer\Http\Routes\LogViewerRoute;
4		use Arcanedev\Support\Providers\RouteServiceProvider as ServiceProvider;
5
6		/**
7		* Class RouteServiceProvider
8		*
9		* @package Arcanedev\LogViewer\Providers
10		* @author ARCANEDEV <[email protected]>
11		*/
12		class RouteServiceProvider extends ServiceProvider
13		{
14		/* -----------------------------------------------------------------
15		\| Getters & Setters
16		\| -----------------------------------------------------------------
17		*/
18
19		/**
20		* Get Route attributes
21		*
22		* @return array
23		*/
24		public function routeAttributes()
25		{
26		return (array) $this->config('attributes');
27		}
28
29		/**
30		* Check if routes is enabled
31		*
32		* @return bool
33		*/
34	888	public function isEnabled()
35		{
36	888	return $this->config('enabled', false);
37		}
38
39		/* -----------------------------------------------------------------
40		\| Main Methods
41		\| -----------------------------------------------------------------
42		*/
43
44		/**
45		* Define the routes for the application.
46		*/
47	888	public function map(): void
48		{
49	888	if ($this->isEnabled()) {
50	888	static::mapRouteClasses([
		0 ignored issues – show Documentation introduced 2020-03-04 08:39 UTC by Report Bug Copy Issue Report `array(\Arcanedev\LogView...\LogViewerRoute::class)` is of type `array<integer,?>`, but the function expects a `object<Arcanedev\Support...ting\Concerns\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
51	888	LogViewerRoute::class,
52		]);
53		}
54	888	}
55
56		/* -----------------------------------------------------------------
57		\| Other Methods
58		\| -----------------------------------------------------------------
59		*/
60
61		/**
62		* Get config value by key
63		*
64		* @param string $key
65		* @param mixed\|null $default
66		*
67		* @return mixed
68		*/
69	888	private function config($key, $default = null)
70		{
71	888	return $this->app['config']->get("log-viewer.route.$key", $default);
72		}
73		}
74

ARCANEDEV / LogViewer

Push — master ( e36039...46643f )

RouteServiceProvider::routeAttributes() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like