Arcanedev\Localization\Middleware\LocaleCookieRedirect

Complexity

Total Complexity

7

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

80%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	handle()	0	19	7

<?php

declare(strict_types=1);

namespace Arcanedev\Localization\Middleware;

use Closure;
use Illuminate\Http\Request;

/**
 * Class     LocaleCookieRedirect
 *
 * @author   ARCANEDEV <arcanedev.maroc@gmail.com>
 */
class LocaleCookieRedirect extends Middleware
{
    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure                  $next
     *
     * @return mixed
     */
    public function handle(Request $request, Closure $next)
    {
        // If the request URL is ignored from localization.
        if ($this->shouldIgnore($request)) return $next($request);

        $segment = $request->segment(1, null);

        if ($this->localization->isLocaleSupported($segment))
            return $next($request)->withCookie(cookie()->forever('locale', $segment));

The method forever does only exist in Illuminate\Cookie\CookieJar, but not in Symfony\Component\HttpFoundation\Cookie.

        $locale  = $request->cookie('locale', null);

        if ($this->localization->isLocaleSupported($locale) && $locale !== null && ! $this->isDefaultLocaleHidden($locale)) {

It seems like $locale defined by $request->cookie('locale', null) on line 40 can also be of type array or null; however, Arcanedev\Localization\Contracts\Localization::isLocaleSupported() does only seem to accept string|boolean, maybe add an additional type check?

It seems like $locale defined by $request->cookie('locale', null) on line 40 can also be of type array; however, Arcanedev\Localization\Middleware\Middleware::isDefaultLocaleHidden() does only seem to accept string|null, maybe add an additional type check?

            if ( ! is_null($redirect = $this->getLocalizedRedirect($locale)))

It seems like $locale defined by $request->cookie('locale', null) on line 40 can also be of type array; however, Arcanedev\Localization\Middleware\Middleware::getLocalizedRedirect() does only seem to accept string, maybe add an additional type check?

                return $redirect->withCookie(cookie()->forever('locale', $locale));

It seems like $locale defined by $request->cookie('locale', null) on line 40 can also be of type array; however, Illuminate\Cookie\CookieJar::forever() does only seem to accept string, maybe add an additional type check?

        }

        return $next($request);
    }
}