VisitorPresenter::getLocationNameAttribute() - Code Metrics - Inspection of "Merge pull request #7 from ARCANEDEV/develop" - ARCANEDEV/LaravelTracker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c30100...d2035e )

by ARCANEDEV

created 2016-12-21 18:30 UTC

VisitorPresenter::getLocationNameAttribute() A

↳ Parent: VisitorPresenter

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
ccs	0
cts	2
cp	0
cc	2
eloc	2
nc	2
nop	0
crap	6

<?php namespace Arcanedev\LaravelTracker\Models\Presenters;

/**
 * Class     VisitorPresenter
 *
 * @package  Arcanedev\LaravelTracker\Models\Presenters
 * @author   ARCANEDEV <[email protected]>
 *
 * @property  string  location_name
 *
 * @property  \Arcanedev\LaravelTracker\Models\GeoIp  geoip
 */
trait VisitorPresenter
{
    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Get the `location_name` attribute.
     *
     * @return string
     */
    public function getLocationNameAttribute()
    {
        return $this->hasGeoip() ? $this->geoip->country.' '.$this->geoip->city : 'undefined';
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php namespace Arcanedev\LaravelTracker\Models\Presenters;
2
3			/**
4			* Class VisitorPresenter
5			*
6			* @package Arcanedev\LaravelTracker\Models\Presenters
7			* @author ARCANEDEV <[email protected]>
8			*
9			* @property string location_name
10			*
11			* @property \Arcanedev\LaravelTracker\Models\GeoIp geoip
12			*/
13			trait VisitorPresenter
14			{
15			/* ------------------------------------------------------------------------------------------------
16			\| Main Functions
17			\| ------------------------------------------------------------------------------------------------
18			*/
19			/**
20			* Get the `location_name` attribute.
21			*
22			* @return string
23			*/
24			public function getLocationNameAttribute()
25			{
26			return $this->hasGeoip() ? $this->geoip->country.' '.$this->geoip->city : 'undefined';
			0 ignored issues – show Bug introduced 2016-12-13 15:01 UTC by Report Bug Copy Issue Report It seems like `hasGeoip()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			}
28			}
29

ARCANEDEV / LaravelTracker

Push — master ( c30100...d2035e )

VisitorPresenter::getLocationNameAttribute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like