Issues in RefererTracker.php - All Issues - Inspection of "Merge pull request #4 from ARCANEDEV/develop" - ARCANEDEV/LaravelTracker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 243903...9a7d92 )

by ARCANEDEV

created 2016-12-13 00:25 UTC

src/Trackers/RefererTracker.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php namespace Arcanedev\LaravelTracker\Trackers;

use Arcanedev\LaravelTracker\Contracts\Parsers\RefererParser;
use Arcanedev\LaravelTracker\Contracts\Trackers\RefererTracker as RefererTrackerContract;
use Arcanedev\LaravelTracker\Models\AbstractModel;
use Illuminate\Support\Arr;

/**
 * Class     RefererTracker
 *
 * @package  Arcanedev\LaravelTracker\Trackers
 * @author   ARCANEDEV <[email protected]>
 */
class RefererTracker extends AbstractTracker implements RefererTrackerContract
{
    /* ------------------------------------------------------------------------------------------------
     |  Getters and Setters
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Get the model.
     *
     * @return \Arcanedev\LaravelTracker\Models\Referer
     */
    protected function getModel()
    {
        return $this->makeModel(AbstractModel::MODEL_REFERER);
    }

    /**
     * @return \Arcanedev\LaravelTracker\Contracts\Parsers\RefererParser
     */
    private function getRefererParser()
    {
        return $this->make(RefererParser::class);
    }

    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Track the referer and return the id.
     *
     * @param  string  $refererUrl
     * @param  string  $pageUrl
     *
     * @return int|null
     */
    public function track($refererUrl, $pageUrl)
    {
        $firstParsed = $this->getRefererParser()->parseUrl($refererUrl);

        if ($firstParsed) {

            $domainId   = $this->trackDomain($firstParsed['domain']);
            $attributes = [
                'url'               => $firstParsed['url'],
                'host'              => $firstParsed['host'],
                'domain_id'         => $domainId,
                'medium'            => null,
                'source'            => null,
                'search_terms_hash' => null,
            ];

            $secondParsed = $this->getRefererParser()->parse($firstParsed['url'], $pageUrl);

            if ($secondParsed->isKnown()) {
                $attributes['medium']            = $secondParsed->getMedium();
                $attributes['source']            = $secondParsed->getSource();
                $attributes['search_terms_hash'] = sha1($secondParsed->getSearchTerm());
            }

            $referer = $this->getModel()->firstOrCreate(
                Arr::only($attributes, ['url', 'search_terms_hash']),
                $attributes
            );

            if ($secondParsed->isKnown()) {
                $this->trackRefererSearchTerms($referer, $secondParsed->getSearchTerm());
            }

            return $referer->id;
        }

        return null;
    }

    /**
     * Track the domain and get the id.
     *
     * @param  string  $name
     *
     * @return int
     */
    private function trackDomain($name)
    {
        return $this->makeModel(AbstractModel::MODEL_DOMAIN)
                    ->firstOrCreate(compact('name'))->id;
    }

    /**
     * Store the referer's search terms.
     *
     * @param  \Arcanedev\LaravelTracker\Models\Referer     $referer
     * @param  string                                       $searchTerms
     */
    private function trackRefererSearchTerms($referer, $searchTerms)
    {
        $terms = [];

        foreach (explode(' ', $searchTerms) as $term) {
            $terms[] = $this->makeModel(AbstractModel::MODEL_REFERER_SEARCH_TERM)->fill([
                'search_term' => $term,
            ]);
        }

        if (count($terms) > 0)
            $referer->searchTerms()->saveMany($terms);

    }
}


1		<?php namespace Arcanedev\LaravelTracker\Trackers;
2
3		use Arcanedev\LaravelTracker\Contracts\Parsers\RefererParser;
4		use Arcanedev\LaravelTracker\Contracts\Trackers\RefererTracker as RefererTrackerContract;
5		use Arcanedev\LaravelTracker\Models\AbstractModel;
6		use Illuminate\Support\Arr;
7
8		/**
9		* Class RefererTracker
10		*
11		* @package Arcanedev\LaravelTracker\Trackers
12		* @author ARCANEDEV <[email protected]>
13		*/
14		class RefererTracker extends AbstractTracker implements RefererTrackerContract
15		{
16		/* ------------------------------------------------------------------------------------------------
17		\| Getters and Setters
18		\| ------------------------------------------------------------------------------------------------
19		*/
20		/**
21		* Get the model.
22		*
23		* @return \Arcanedev\LaravelTracker\Models\Referer
24		*/
25	6	protected function getModel()
26		{
27	6	return $this->makeModel(AbstractModel::MODEL_REFERER);
28		}
29
30		/**
31		* @return \Arcanedev\LaravelTracker\Contracts\Parsers\RefererParser
32		*/
33	18	private function getRefererParser()
34		{
35	18	return $this->make(RefererParser::class);
36		}
37
38		/* ------------------------------------------------------------------------------------------------
39		\| Main Functions
40		\| ------------------------------------------------------------------------------------------------
41		*/
42		/**
43		* Track the referer and return the id.
44		*
45		* @param string $refererUrl
46		* @param string $pageUrl
47		*
48		* @return int\|null
49		*/
50	18	public function track($refererUrl, $pageUrl)
51		{
52	18	$firstParsed = $this->getRefererParser()->parseUrl($refererUrl);
53
54	18	if ($firstParsed) {
		0 ignored issues – show Bug Best Practice introduced 2016-12-05 18:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$firstParsed` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
55	6	$domainId = $this->trackDomain($firstParsed['domain']);
56		$attributes = [
57	6	'url' => $firstParsed['url'],
58	6	'host' => $firstParsed['host'],
59	6	'domain_id' => $domainId,
60	3	'medium' => null,
61	3	'source' => null,
62	3	'search_terms_hash' => null,
63	3	];
64
65	6	$secondParsed = $this->getRefererParser()->parse($firstParsed['url'], $pageUrl);
66
67	6	if ($secondParsed->isKnown()) {
68	6	$attributes['medium'] = $secondParsed->getMedium();
69	6	$attributes['source'] = $secondParsed->getSource();
70	6	$attributes['search_terms_hash'] = sha1($secondParsed->getSearchTerm());
71	3	}
72
73	6	$referer = $this->getModel()->firstOrCreate(
74	6	Arr::only($attributes, ['url', 'search_terms_hash']),
75		$attributes
76	3	);
77
78	6	if ($secondParsed->isKnown()) {
79	6	$this->trackRefererSearchTerms($referer, $secondParsed->getSearchTerm());
80	3	}
81
82	6	return $referer->id;
83		}
84
85	12	return null;
86		}
87
88		/**
89		* Track the domain and get the id.
90		*
91		* @param string $name
92		*
93		* @return int
94		*/
95	6	private function trackDomain($name)
96		{
97	6	return $this->makeModel(AbstractModel::MODEL_DOMAIN)
98	6	->firstOrCreate(compact('name'))->id;
99		}
100
101		/**
102		* Store the referer's search terms.
103		*
104		* @param \Arcanedev\LaravelTracker\Models\Referer $referer
105		* @param string $searchTerms
106		*/
107	6	private function trackRefererSearchTerms($referer, $searchTerms)
108		{
109	6	$terms = [];
110
111	6	foreach (explode(' ', $searchTerms) as $term) {
112	6	$terms[] = $this->makeModel(AbstractModel::MODEL_REFERER_SEARCH_TERM)->fill([
113	6	'search_term' => $term,
114	3	]);
115	3	}
116
117	6	if (count($terms) > 0)
118	6	$referer->searchTerms()->saveMany($terms);
119
120	6	}
121		}
122

ARCANEDEV / LaravelTracker

Push — master ( 243903...9a7d92 )

src/Trackers/RefererTracker.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like