Issues in Value.php (master) - Issues in master - ARCANEDEV/LaravelMetrics - Measure and Improve Code Quality continuously with Scrutinizer

Issues (15)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Metrics/Value.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace Arcanedev\LaravelMetrics\Metrics;

use Arcanedev\LaravelMetrics\Metrics\Concerns\HasRoundedValue;
use Arcanedev\LaravelMetrics\Results\ValueResult;

/**
 * Class     Value
 *
 * @author   ARCANEDEV <[email protected]>
 */
abstract class Value extends Metric
{
    /* -----------------------------------------------------------------
     |  Traits
     | -----------------------------------------------------------------
     */

    use HasRoundedValue;

    /* -----------------------------------------------------------------
     |  Getters & Setters
     | -----------------------------------------------------------------
     */

    /**
     * Get the metric type.
     *
     * @return string
     */
    public function type(): string
    {
        return 'value';
    }

    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Calculate the `count` of the metric.
     *
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
     * @param  string|string                                 $column
     *
     * @return \Arcanedev\LaravelMetrics\Results\ValueResult|mixed
     */
    public function count($model, $column = null)
    {
        return $this->aggregate('count', $model, $column);
    }

    /**
     * Calculate the `average` of the metric.
     *
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
     * @param  string                                        $column
     *
     * @return \Arcanedev\LaravelMetrics\Results\ValueResult|mixed
     */
    public function average($model, string $column)
    {
        return $this->aggregate('avg', $model, $column);
    }

    /**
     * Calculate the `sum` of the metric.
     *
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
     * @param  string                                        $column
     *
     * @return \Arcanedev\LaravelMetrics\Results\ValueResult|mixed
     */
    public function sum($model, string $column)
    {
        return $this->aggregate('sum', $model, $column);
    }

    /**
     * Calculate the `max` of the metric.
     *
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
     * @param  string                                        $column
     *
     * @return \Arcanedev\LaravelMetrics\Results\ValueResult|mixed
     */
    public function max($model, string $column)
    {
        return $this->aggregate('max', $model, $column);
    }

    /**
     * Calculate the `min` of the metric.
     *
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
     * @param  string                                        $column
     *
     * @return \Arcanedev\LaravelMetrics\Results\ValueResult|mixed
     */
    public function min($model, string $column)
    {
        return $this->aggregate('min', $model, $column);
    }

    /* -----------------------------------------------------------------
     |  Other Methods
     | -----------------------------------------------------------------
     */

    /**
     * Handle the aggregate calculation of the metric.
     *
     * @param string                                         $method
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
     * @param  string|null                                   $column
     *
     * @return \Arcanedev\LaravelMetrics\Results\ValueResult|mixed
     */
    protected function aggregate(string $method, $model, string $column = null)
    {
        $query  = static::getQuery($model);
        $column = $column ?? $query->getModel()->getQualifiedKeyName();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $value  = $query->{$method}($column);

        return $this->result($method === 'count' ? $value : $this->roundValue($value));
    }

    /**
     * Make a new result instance.
     *
     * @param  mixed|null  $value
     *
     * @return \Arcanedev\LaravelMetrics\Results\ValueResult|mixed
     */
    protected function result($value = null)
    {
        return new ValueResult($value);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Arcanedev\LaravelMetrics\Metrics;
6
7		use Arcanedev\LaravelMetrics\Metrics\Concerns\HasRoundedValue;
8		use Arcanedev\LaravelMetrics\Results\ValueResult;
9
10		/**
11		* Class Value
12		*
13		* @author ARCANEDEV <[email protected]>
14		*/
15		abstract class Value extends Metric
16		{
17		/* -----------------------------------------------------------------
18		\| Traits
19		\| -----------------------------------------------------------------
20		*/
21
22		use HasRoundedValue;
23
24		/* -----------------------------------------------------------------
25		\| Getters & Setters
26		\| -----------------------------------------------------------------
27		*/
28
29		/**
30		* Get the metric type.
31		*
32		* @return string
33		*/
34	36	public function type(): string
35		{
36	36	return 'value';
37		}
38
39		/* -----------------------------------------------------------------
40		\| Main Methods
41		\| -----------------------------------------------------------------
42		*/
43
44		/**
45		* Calculate the `count` of the metric.
46		*
47		* @param \Illuminate\Database\Eloquent\Builder\|string $model
48		* @param string\|string $column
49		*
50		* @return \Arcanedev\LaravelMetrics\Results\ValueResult\|mixed
51		*/
52	4	public function count($model, $column = null)
53		{
54	4	return $this->aggregate('count', $model, $column);
55		}
56
57		/**
58		* Calculate the `average` of the metric.
59		*
60		* @param \Illuminate\Database\Eloquent\Builder\|string $model
61		* @param string $column
62		*
63		* @return \Arcanedev\LaravelMetrics\Results\ValueResult\|mixed
64		*/
65	12	public function average($model, string $column)
66		{
67	12	return $this->aggregate('avg', $model, $column);
68		}
69
70		/**
71		* Calculate the `sum` of the metric.
72		*
73		* @param \Illuminate\Database\Eloquent\Builder\|string $model
74		* @param string $column
75		*
76		* @return \Arcanedev\LaravelMetrics\Results\ValueResult\|mixed
77		*/
78	4	public function sum($model, string $column)
79		{
80	4	return $this->aggregate('sum', $model, $column);
81		}
82
83		/**
84		* Calculate the `max` of the metric.
85		*
86		* @param \Illuminate\Database\Eloquent\Builder\|string $model
87		* @param string $column
88		*
89		* @return \Arcanedev\LaravelMetrics\Results\ValueResult\|mixed
90		*/
91	4	public function max($model, string $column)
92		{
93	4	return $this->aggregate('max', $model, $column);
94		}
95
96		/**
97		* Calculate the `min` of the metric.
98		*
99		* @param \Illuminate\Database\Eloquent\Builder\|string $model
100		* @param string $column
101		*
102		* @return \Arcanedev\LaravelMetrics\Results\ValueResult\|mixed
103		*/
104	4	public function min($model, string $column)
105		{
106	4	return $this->aggregate('min', $model, $column);
107		}
108
109		/* -----------------------------------------------------------------
110		\| Other Methods
111		\| -----------------------------------------------------------------
112		*/
113
114		/**
115		* Handle the aggregate calculation of the metric.
116		*
117		* @param string $method
118		* @param \Illuminate\Database\Eloquent\Builder\|string $model
119		* @param string\|null $column
120		*
121		* @return \Arcanedev\LaravelMetrics\Results\ValueResult\|mixed
122		*/
123	28	protected function aggregate(string $method, $model, string $column = null)
124		{
125	28	$query = static::getQuery($model);
126	28	$column = $column ?? $query->getModel()->getQualifiedKeyName();
		0 ignored issues – show Bug introduced 2019-05-10 00:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getQualifiedKeyName` does only exist in `Illuminate\Database\Eloquent\Model`, but not in `Illuminate\Database\Eloquent\Builder`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
127
128	28	$value = $query->{$method}($column);
129
130	28	return $this->result($method === 'count' ? $value : $this->roundValue($value));
131		}
132
133		/**
134		* Make a new result instance.
135		*
136		* @param mixed\|null $value
137		*
138		* @return \Arcanedev\LaravelMetrics\Results\ValueResult\|mixed
139		*/
140	28	protected function result($value = null)
141		{
142	28	return new ValueResult($value);
143		}
144		}
145

ARCANEDEV / LaravelMetrics

Issues (15)

Security Analysis not enabled

src/Metrics/Value.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like