Completed
Pull Request — master (#4)
by ARCANEDEV
04:12
created

Trend   A

Complexity

Total Complexity 17

Size/Duplication

Total Lines 249
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 15

Test Coverage

Coverage 85.94%

Importance

Changes 0
Metric Value
wmc 17
lcom 1
cbo 15
dl 0
loc 249
ccs 55
cts 64
cp 0.8594
rs 10
c 0
b 0
f 0

10 Methods

Rating   Name   Duplication   Size   Complexity  
A type() 0 4 1
A count() 0 4 1
A average() 0 4 1
A sum() 0 4 1
A max() 0 4 1
A min() 0 4 1
A result() 0 4 1
B parseDateResult() 0 23 6
A toArray() 0 7 1
A aggregate() 0 54 3
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Arcanedev\LaravelMetrics\Metrics;
6
7
use Arcanedev\LaravelMetrics\Exceptions\InvalidTrendUnitException;
8
use Arcanedev\LaravelMetrics\Helpers\TrendDatePeriod;
9
use Arcanedev\LaravelMetrics\Results\TrendResult;
10
use Cake\Chronos\Chronos;
11
use Illuminate\Support\Facades\DB;
12
13
/**
14
 * Class     Trend
15
 *
16
 * @package  Arcanedev\LaravelMetrics\Metrics
17
 * @author   ARCANEDEV <[email protected]>
18
 */
19
abstract class Trend extends Metric
20
{
21
    /* -----------------------------------------------------------------
22
     |  Constants
23
     | -----------------------------------------------------------------
24
     */
25
26
    /**
27
     * Trend metric unit constants.
28
     */
29
    const BY_MONTHS  = 'month';
30
    const BY_WEEKS   = 'week';
31
    const BY_DAYS    = 'day';
32
    const BY_HOURS   = 'hour';
33
    const BY_MINUTES = 'minute';
34
35
    /* -----------------------------------------------------------------
36
     |  Traits
37
     | -----------------------------------------------------------------
38
     */
39
40
    use Concerns\AggregatesTrends,
41
        Concerns\HasExpressions,
42
        Concerns\HasRanges,
43
        Concerns\FormatsTrends;
44
45
    /* -----------------------------------------------------------------
46
     |  Getters
47
     | -----------------------------------------------------------------
48
     */
49
50
    /**
51
     * Get the metric type.
52
     *
53
     * @return string
54
     */
55 12
    public function type(): string
56
    {
57 12
        return 'trend';
58
    }
59
60
    /* -----------------------------------------------------------------
61
     |  Main Methods
62
     | -----------------------------------------------------------------
63
     */
64
65
    /**
66
     * Calculate the `count` of the metric.
67
     *
68
     * @param  string                                        $unit
69
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
70
     * @param  string|null                                   $dateColumn
71
     * @param  string|null                                   $column
72
     *
73
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
74
     */
75 10
    public function count($unit, $model, $dateColumn = null, $column = null)
76
    {
77 10
        return $this->aggregate('count', $unit, $model, $column, $dateColumn);
78
    }
79
80
    /**
81
     * Return a value result showing a average aggregate over time.
82
     *
83
     * @param  string                                        $unit
84
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
85
     * @param  string                                        $column
86
     * @param  string|null                                   $dateColumn
87
     *
88
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
89
     */
90
    public function average(string $unit, $model, $column, $dateColumn = null)
91
    {
92
        return $this->aggregate('avg', $unit, $model, $column, $dateColumn);
93
    }
94
95
    /**
96
     * Return a value result showing a sum aggregate over time.
97
     *
98
     * @param  string                                        $unit
99
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
100
     * @param  string                                        $column
101
     * @param  string|null                                   $dateColumn
102
     *
103
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
104
     */
105
    public function sum(string $unit, $model, $column, $dateColumn = null)
106
    {
107
        return $this->aggregate('sum', $unit, $model, $column, $dateColumn);
108
    }
109
110
    /**
111
     * Return a value result showing a max aggregate over time.
112
     *
113
     * @param  string                                        $unit
114
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
115
     * @param  string                                        $column
116
     * @param  string|null                                   $dateColumn
117
     *
118
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
119
     */
120
    public function max(string $unit, $model, $column, $dateColumn = null)
121
    {
122
        return $this->aggregate('max', $unit, $model, $column, $dateColumn);
123
    }
124
125
    /**
126
     * Return a value result showing a min aggregate over time.
127
     *
128
     * @param  string                                        $unit
129
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
130
     * @param  string                                        $column
131
     * @param  string|null                                   $dateColumn
132
     *
133
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
134
     */
135
    public function min(string $unit, $model, $column, $dateColumn = null)
136
    {
137
        return $this->aggregate('min', $unit, $model, $column, $dateColumn);
138
    }
139
140
    /**
141
     * Make a new result instance.
142
     *
143
     * @param  mixed|null  $value
144
     *
145
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
146
     */
147 10
    protected function result($value = null)
148
    {
149 10
        return new TrendResult($value);
150
    }
151
152
    /* -----------------------------------------------------------------
153
     |  Other Methods
154
     | -----------------------------------------------------------------
155
     */
156
157
    /**
158
     * Handle the aggregate calculation of the metric.
159
     *
160
     * @param  string                                        $method
161
     * @param  string                                        $unit
162
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
163
     * @param  string|null                                   $column
164
     * @param  string|null                                   $dateColumn
165
     *
166
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
167
     */
168 10
    protected function aggregate(string $method, string $unit, $model, ?string $column = null, ?string $dateColumn = null)
169
    {
170 10
        $range          = $this->request->input('range');
171 10
        $timezone       = $this->request->input('timezone');
172 10
        $twelveHourTime = $this->request->input('twelveHourTime') === 'true';
173
174 10
        $query      = static::getQuery($model);
175 10
        $column     = $column ?? $query->getModel()->getCreatedAtColumn();
0 ignored issues
show
Bug introduced by
The method getCreatedAtColumn does only exist in Illuminate\Database\Eloquent\Model, but not in Illuminate\Database\Eloquent\Builder.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
176 10
        $dateColumn = $dateColumn ?? $query->getModel()->getCreatedAtColumn();
177 10
        $expression = static::getExpression($query, 'trend_date_format', $dateColumn, [$unit, $query, $timezone]);
178
179 10
        $dates = TrendDatePeriod::make(
180 10
            $startingDate = TrendDatePeriod::getStartingDate($unit, $range),
181 10
            $endingDate = Chronos::now(),
182
            $unit,
183
            $timezone
184
        )->mapWithKeys(function (Chronos $date) use ($twelveHourTime, $unit) {
185
            return [
186 10
                static::formatAggregateKey($date, $unit) => [
187 10
                    'label' => static::formatLabelBy($date, $unit, $twelveHourTime),
188 10
                    'value' => 0,
189
                ]
190
            ];
191 10
        });
192
193 10
        $wrappedColumn = $query->getQuery()->getGrammar()->wrap($column);
194
195 10
        $results = $query->select([
0 ignored issues
show
Bug introduced by
The method select() does not exist on Illuminate\Database\Eloquent\Builder. Did you maybe mean createSelectWithConstraint()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
196 10
                DB::raw("{$expression} as date_result"),
197 10
                DB::raw("{$method}({$wrappedColumn}) as aggregate")
198
            ])
199 10
            ->whereBetween($dateColumn, [$startingDate, $endingDate])
200 10
            ->groupBy('date_result')
201 10
            ->orderBy('date_result')
202 10
            ->get()
203
            ->mapWithKeys(function ($result) use ($method, $unit, $twelveHourTime) {
204 10
                $date  = static::parseDateResult($result->getAttribute('date_result'), $unit);
205 10
                $value = $result->getAttribute('aggregate');
206
207
                return [
208 10
                    static::formatAggregateKey($date, $unit) => [
209 10
                        'label' => static::formatLabelBy($date, $unit, $twelveHourTime),
210 10
                        'value' => $method === 'count' ? intval($value) : round($value, 0),
211
                    ],
212
                ];
213 10
            });
214
215 10
        $results = $dates->merge($results)->sortKeys();
216
217 10
        if ($results->count() > $range)
218 10
            $results->shift();
219
220 10
        return $this->result()->trend($results->all());
221
    }
222
223
    /**
224
     * Parse the date result.
225
     *
226
     * @param  string  $date
227
     * @param  string  $unit
228
     *
229
     * @return \Cake\Chronos\Chronos
230
     */
231 10
    protected function parseDateResult(string $date, string $unit): Chronos
232
    {
233
        switch ($unit) {
234 10
            case self::BY_MONTHS:
235 2
                return Chronos::createFromFormat('Y-m', $date);
236
237 8
            case self::BY_WEEKS:
238 2
                [$year, $week] = explode('-', $date);
0 ignored issues
show
Bug introduced by
The variable $year does not exist. Did you forget to declare it?

This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.

Loading history...
Bug introduced by
The variable $week does not exist. Did you forget to declare it?

This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.

Loading history...
239 2
                return (new Chronos)->setISODate((int) $year, (int) $week)->setTime(0, 0);
240
241 6
            case self::BY_DAYS:
242 2
                return Chronos::createFromFormat('Y-m-d', $date);
243
244 4
            case self::BY_HOURS:
245 2
                return Chronos::createFromFormat('Y-m-d H:00', $date);
246
247 2
            case self::BY_MINUTES:
248 2
                return Chronos::createFromFormat('Y-m-d H:i:00', $date);
249
250
            default:
251
                throw InvalidTrendUnitException::make($unit);
252
        }
253
    }
254
255
    /**
256
     * Get the instance as an array.
257
     *
258
     * @return array
259
     */
260 2
    public function toArray(): array
261
    {
262 2
        return array_merge(
263 1
            parent::toArray(),
264 2
            ['ranges' => $this->rangesToArray()]
265
        );
266
    }
267
}
268