Completed
Push — master ( 6abfd6...1b4658 )
by ARCANEDEV
04:23
created

Trend   A

Complexity

Total Complexity 17

Size/Duplication

Total Lines 250
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 15

Test Coverage

Coverage 86.57%

Importance

Changes 0
Metric Value
wmc 17
lcom 1
cbo 15
dl 0
loc 250
ccs 58
cts 67
cp 0.8657
rs 10
c 0
b 0
f 0

10 Methods

Rating   Name   Duplication   Size   Complexity  
A type() 0 4 1
A count() 0 4 1
A average() 0 4 1
A sum() 0 4 1
A max() 0 4 1
A min() 0 4 1
A result() 0 4 1
A aggregate() 0 54 3
B parseDateResult() 0 24 6
A toArray() 0 7 1
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Arcanedev\LaravelMetrics\Metrics;
6
7
use Arcanedev\LaravelMetrics\Exceptions\InvalidTrendUnitException;
8
use Arcanedev\LaravelMetrics\Helpers\TrendDatePeriod;
9
use Arcanedev\LaravelMetrics\Results\TrendResult;
10
use Cake\Chronos\Chronos;
11
use Illuminate\Support\Facades\DB;
12
13
/**
14
 * Class     Trend
15
 *
16
 * @package  Arcanedev\LaravelMetrics\Metrics
17
 * @author   ARCANEDEV <[email protected]>
18
 */
19
abstract class Trend extends Metric
20
{
21
    /* -----------------------------------------------------------------
22
     |  Constants
23
     | -----------------------------------------------------------------
24
     */
25
26
    /**
27
     * Trend metric unit constants.
28
     */
29
    const BY_MONTHS  = 'month';
30
    const BY_WEEKS   = 'week';
31
    const BY_DAYS    = 'day';
32
    const BY_HOURS   = 'hour';
33
    const BY_MINUTES = 'minute';
34
35
    /* -----------------------------------------------------------------
36
     |  Traits
37
     | -----------------------------------------------------------------
38
     */
39
40
    use Concerns\AggregatesTrends,
41
        Concerns\HasExpressions,
42
        Concerns\HasRanges,
43
        Concerns\FormatsTrends;
44
45
    /* -----------------------------------------------------------------
46
     |  Getters
47
     | -----------------------------------------------------------------
48
     */
49
50
    /**
51
     * Get the metric type.
52
     *
53
     * @return string
54
     */
55 36
    public function type(): string
56
    {
57 36
        return 'trend';
58
    }
59
60
    /* -----------------------------------------------------------------
61
     |  Main Methods
62
     | -----------------------------------------------------------------
63
     */
64
65
    /**
66
     * Calculate the `count` of the metric.
67
     *
68
     * @param  string                                        $unit
69
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
70
     * @param  string|null                                   $dateColumn
71
     * @param  string|null                                   $column
72
     *
73
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
74
     */
75 30
    public function count($unit, $model, $dateColumn = null, $column = null)
76
    {
77 30
        return $this->aggregate('count', $unit, $model, $column, $dateColumn);
78
    }
79
80
    /**
81
     * Return a value result showing a average aggregate over time.
82
     *
83
     * @param  string                                        $unit
84
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
85
     * @param  string                                        $column
86
     * @param  string|null                                   $dateColumn
87
     *
88
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
89
     */
90
    public function average(string $unit, $model, $column, $dateColumn = null)
91
    {
92
        return $this->aggregate('avg', $unit, $model, $column, $dateColumn);
93
    }
94
95
    /**
96
     * Return a value result showing a sum aggregate over time.
97
     *
98
     * @param  string                                        $unit
99
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
100
     * @param  string                                        $column
101
     * @param  string|null                                   $dateColumn
102
     *
103
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
104
     */
105
    public function sum(string $unit, $model, $column, $dateColumn = null)
106
    {
107
        return $this->aggregate('sum', $unit, $model, $column, $dateColumn);
108
    }
109
110
    /**
111
     * Return a value result showing a max aggregate over time.
112
     *
113
     * @param  string                                        $unit
114
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
115
     * @param  string                                        $column
116
     * @param  string|null                                   $dateColumn
117
     *
118
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
119
     */
120
    public function max(string $unit, $model, $column, $dateColumn = null)
121
    {
122
        return $this->aggregate('max', $unit, $model, $column, $dateColumn);
123
    }
124
125
    /**
126
     * Return a value result showing a min aggregate over time.
127
     *
128
     * @param  string                                        $unit
129
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
130
     * @param  string                                        $column
131
     * @param  string|null                                   $dateColumn
132
     *
133
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
134
     */
135
    public function min(string $unit, $model, $column, $dateColumn = null)
136
    {
137
        return $this->aggregate('min', $unit, $model, $column, $dateColumn);
138
    }
139
140
    /**
141
     * Make a new result instance.
142
     *
143
     * @param  mixed|null  $value
144
     *
145
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
146
     */
147 30
    protected function result($value = null)
148
    {
149 30
        return new TrendResult($value);
150
    }
151
152
    /* -----------------------------------------------------------------
153
     |  Other Methods
154
     | -----------------------------------------------------------------
155
     */
156
157
    /**
158
     * Handle the aggregate calculation of the metric.
159
     *
160
     * @param  string                                        $method
161
     * @param  string                                        $unit
162
     * @param  \Illuminate\Database\Eloquent\Builder|string  $model
163
     * @param  string|null                                   $column
164
     * @param  string|null                                   $dateColumn
165
     *
166
     * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed
167
     */
168 30
    protected function aggregate(string $method, string $unit, $model, ?string $column = null, ?string $dateColumn = null)
169
    {
170 30
        $range          = $this->request->input('range');
171 30
        $timezone       = $this->request->input('timezone');
172 30
        $twelveHourTime = $this->request->input('twelveHourTime') === 'true';
173
174 30
        $query      = static::getQuery($model);
175 30
        $column     = $column ?? $query->getModel()->getCreatedAtColumn();
0 ignored issues
show
Bug introduced by
The method getCreatedAtColumn does only exist in Illuminate\Database\Eloquent\Model, but not in Illuminate\Database\Eloquent\Builder.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
176 30
        $dateColumn = $dateColumn ?? $query->getModel()->getCreatedAtColumn();
177 30
        $expression = static::getExpression($query, 'trend_date_format', $dateColumn, [$unit, $query, $timezone]);
178
179 30
        $dates = TrendDatePeriod::make(
180 30
            $startingDate = TrendDatePeriod::getStartingDate($unit, $range),
181 30
            $endingDate = Chronos::now(),
182 10
            $unit,
183 10
            $timezone
184
        )->mapWithKeys(function (Chronos $date) use ($twelveHourTime, $unit) {
185
            return [
186 30
                static::formatAggregateKey($date, $unit) => [
187 30
                    'label' => static::formatLabelBy($date, $unit, $twelveHourTime),
188 30
                    'value' => 0,
189
                ]
190
            ];
191 30
        });
192
193 30
        $wrappedColumn = $query->getQuery()->getGrammar()->wrap($column);
194
195 30
        $results = $query->select([
0 ignored issues
show
Bug introduced by
The method select() does not exist on Illuminate\Database\Eloquent\Builder. Did you maybe mean createSelectWithConstraint()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
196 30
                DB::raw("{$expression} as date_result"),
197 30
                DB::raw("{$method}({$wrappedColumn}) as aggregate")
198
            ])
199 30
            ->whereBetween($dateColumn, [$startingDate, $endingDate])
200 30
            ->groupBy('date_result')
201 30
            ->orderBy('date_result')
202 30
            ->get()
203
            ->mapWithKeys(function ($result) use ($method, $unit, $twelveHourTime) {
204 30
                $date  = static::parseDateResult($result->getAttribute('date_result'), $unit);
205 30
                $value = $result->getAttribute('aggregate');
206
207
                return [
208 30
                    static::formatAggregateKey($date, $unit) => [
209 30
                        'label' => static::formatLabelBy($date, $unit, $twelveHourTime),
210 30
                        'value' => $method === 'count' ? intval($value) : round($value, 0),
211
                    ],
212
                ];
213 30
            });
214
215 30
        $results = $dates->merge($results)->sortKeys();
216
217 30
        if ($results->count() > $range)
218 30
            $results->shift();
219
220 30
        return $this->result()->trend($results->all());
221
    }
222
223
    /**
224
     * Parse the date result.
225
     *
226
     * @param  string  $date
227
     * @param  string  $unit
228
     *
229
     * @return \Cake\Chronos\Chronos
230
     */
231 30
    protected function parseDateResult(string $date, string $unit): Chronos
232
    {
233
        switch ($unit) {
234 30
            case self::BY_MONTHS:
235 6
                [$year, $month] = explode('-', $date);
0 ignored issues
show
Bug introduced by
The variable $year does not exist. Did you forget to declare it?

This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.

Loading history...
Bug introduced by
The variable $month does not exist. Did you forget to declare it?

This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.

Loading history...
236 6
                return Chronos::create((int) $year, (int) $month, 1);
237
238 24
            case self::BY_WEEKS:
239 6
                [$year, $week] = explode('-', $date);
0 ignored issues
show
Bug introduced by
The variable $week does not exist. Did you forget to declare it?

This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.

Loading history...
240 6
                return (new Chronos)->setISODate((int) $year, (int) $week)->setTime(0, 0);
241
242 18
            case self::BY_DAYS:
243 6
                return Chronos::createFromFormat('Y-m-d', $date);
244
245 12
            case self::BY_HOURS:
246 6
                return Chronos::createFromFormat('Y-m-d H:00', $date);
247
248 6
            case self::BY_MINUTES:
249 6
                return Chronos::createFromFormat('Y-m-d H:i:00', $date);
250
251
            default:
252
                throw InvalidTrendUnitException::make($unit);
253
        }
254
    }
255
256
    /**
257
     * Get the instance as an array.
258
     *
259
     * @return array
260
     */
261 6
    public function toArray(): array
262
    {
263 6
        return array_merge(
264 6
            parent::toArray(),
265 6
            ['ranges' => $this->rangesToArray()]
266
        );
267
    }
268
}
269