TrendDatePeriod - Code Metrics - Inspection of "WIP (Part 8)" - ARCANEDEV/LaravelMetrics - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1842cb...2414f9 )

by ARCANEDEV

created 2019-05-13 23:35 UTC

TrendDatePeriod A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	113
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	0
loc	113
c	0
b	0
f	0
wmc	17
lcom	1
cbo	3
ccs	42
cts	42
cp	1
rs	10

3 Methods

Rating	Name	Size	Complexity
A	make()	21	4
B	getStartingDate()	29	7
B	getNextDate()	22	6

<?php namespace Arcanedev\LaravelMetrics\Helpers;

use Arcanedev\LaravelMetrics\Exceptions\InvalidTrendUnitException;
use Arcanedev\LaravelMetrics\Metrics\Trend;
use Cake\Chronos\Chronos;
use Illuminate\Support\Collection;

/**
 * Class     TrendDatePeriod
 *
 * @package  Arcanedev\LaravelMetrics\Helpers
 * @author   ARCANEDEV <[email protected]>
 */
class TrendDatePeriod
{
    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Make date period (range) for the trend metric.
     *
     * @param  \Cake\Chronos\Chronos  $start
     * @param  \Cake\Chronos\Chronos  $end
     * @param  string                 $unit
     * @param  mixed|null             $timezone
     *
     * @return \Illuminate\Support\Collection
     */
    public static function make(Chronos $start, Chronos $end, string $unit, $timezone = null)
    {
        $period = new Collection;
        $next   = $start;

        if ( ! empty($timezone)) {
            $next = $start->setTimezone($timezone);
            $end  = $end->setTimezone($timezone);
        }

        $period->push($next);

        while ($next->lt($end)) {
            $next = static::getNextDate($unit, $next);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}

            if ($next->lte($end))
                $period->push($next);
        }

        return $period;
    }

    /**
     * Get the starting date.
     *
     * @param  string        $unit
     * @param  mixed|null    $range
     *
     * @return \Cake\Chronos\Chronos
     */
    public static function getStartingDate(string $unit, $range = null): Chronos
    {
        $range = empty($range) ? 1 : ($range - 1);
        $now   = Chronos::now();

        switch ($unit) {
            case Trend::BY_MONTHS:
                return $now->subMonths($range)->firstOfMonth()->setTime(0, 0);

            case Trend::BY_WEEKS:
                return $now->subWeeks($range)->startOfWeek()->setTime(0, 0);

            case Trend::BY_DAYS:
                return $now->subDays($range)->setTime(0, 0);

            case Trend::BY_HOURS:
                return with($now->subHours($range), function (Chronos $date) {
                    return $date->setTime($date->hour, 0);
                });

            case Trend::BY_MINUTES:
                return with($now->subMinutes($range), function (Chronos $date) {
                    return $date->setTime($date->hour, $date->minute);
                });

            default:
                throw InvalidTrendUnitException::make($unit);
        }
    }

    /* -----------------------------------------------------------------
     |  Other Methods
     | -----------------------------------------------------------------
     */

    /**
     * Get next date.
     *
     * @param  string                 $unit
     * @param  \Cake\Chronos\Chronos  $next
     *
     * @return \Cake\Chronos\Chronos
     */
    private static function getNextDate(string $unit, Chronos $next): Chronos
    {
        switch ($unit) {
            case Trend::BY_MONTHS:
                return $next->addMonths(1);

            case Trend::BY_WEEKS:
                return $next->addWeeks(1);

            case Trend::BY_DAYS:
                return $next->addDays(1);

            case Trend::BY_HOURS:
                return $next->addHours(1);

            case Trend::BY_MINUTES:
                return $next->addMinutes(1);

            default:
                throw InvalidTrendUnitException::make($unit);
        }
    }
}


1		<?php namespace Arcanedev\LaravelMetrics\Helpers;
2
3		use Arcanedev\LaravelMetrics\Exceptions\InvalidTrendUnitException;
4		use Arcanedev\LaravelMetrics\Metrics\Trend;
5		use Cake\Chronos\Chronos;
6		use Illuminate\Support\Collection;
7
8		/**
9		* Class TrendDatePeriod
10		*
11		* @package Arcanedev\LaravelMetrics\Helpers
12		* @author ARCANEDEV <[email protected]>
13		*/
14		class TrendDatePeriod
15		{
16		/* -----------------------------------------------------------------
17		\| Main Methods
18		\| -----------------------------------------------------------------
19		*/
20
21		/**
22		* Make date period (range) for the trend metric.
23		*
24		* @param \Cake\Chronos\Chronos $start
25		* @param \Cake\Chronos\Chronos $end
26		* @param string $unit
27		* @param mixed\|null $timezone
28		*
29		* @return \Illuminate\Support\Collection
30		*/
31	36	public static function make(Chronos $start, Chronos $end, string $unit, $timezone = null)
32		{
33	36	$period = new Collection;
34	36	$next = $start;
35
36	36	if ( ! empty($timezone)) {
37	20	$next = $start->setTimezone($timezone);
38	20	$end = $end->setTimezone($timezone);
39		}
40
41	36	$period->push($next);
42
43	36	while ($next->lt($end)) {
44	36	$next = static::getNextDate($unit, $next);
		0 ignored issues – show Bug introduced 2019-05-13 23:38 UTC by Report Bug Copy Issue Report Since `getNextDate()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `getNextDate()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
45
46	32	if ($next->lte($end))
47	32	$period->push($next);
48		}
49
50	32	return $period;
51		}
52
53		/**
54		* Get the starting date.
55		*
56		* @param string $unit
57		* @param mixed\|null $range
58		*
59		* @return \Cake\Chronos\Chronos
60		*/
61	36	public static function getStartingDate(string $unit, $range = null): Chronos
62		{
63	36	$range = empty($range) ? 1 : ($range - 1);
64	36	$now = Chronos::now();
65
66	9	switch ($unit) {
67	27	case Trend::BY_MONTHS:
68	8	return $now->subMonths($range)->firstOfMonth()->setTime(0, 0);
69
70	21	case Trend::BY_WEEKS:
71	4	return $now->subWeeks($range)->startOfWeek()->setTime(0, 0);
72
73	18	case Trend::BY_DAYS:
74	12	return $now->subDays($range)->setTime(0, 0);
75
76	9	case Trend::BY_HOURS:
77		return with($now->subHours($range), function (Chronos $date) {
78	4	return $date->setTime($date->hour, 0);
79	4	});
80
81	6	case Trend::BY_MINUTES:
82		return with($now->subMinutes($range), function (Chronos $date) {
83	4	return $date->setTime($date->hour, $date->minute);
84	4	});
85
86		default:
87	4	throw InvalidTrendUnitException::make($unit);
88		}
89		}
90
91		/* -----------------------------------------------------------------
92		\| Other Methods
93		\| -----------------------------------------------------------------
94		*/
95
96		/**
97		* Get next date.
98		*
99		* @param string $unit
100		* @param \Cake\Chronos\Chronos $next
101		*
102		* @return \Cake\Chronos\Chronos
103		*/
104	36	private static function getNextDate(string $unit, Chronos $next): Chronos
105		{
106	9	switch ($unit) {
107	27	case Trend::BY_MONTHS:
108	8	return $next->addMonths(1);
109
110	21	case Trend::BY_WEEKS:
111	4	return $next->addWeeks(1);
112
113	18	case Trend::BY_DAYS:
114	12	return $next->addDays(1);
115
116	9	case Trend::BY_HOURS:
117	4	return $next->addHours(1);
118
119	6	case Trend::BY_MINUTES:
120	4	return $next->addMinutes(1);
121
122		default:
123	4	throw InvalidTrendUnitException::make($unit);
124		}
125		}
126		}
127

ARCANEDEV / LaravelMetrics

Push — master ( 1842cb...2414f9 )

TrendDatePeriod A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like