Complex classes like Trend often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Trend, and based on these observations, apply Extract Interface, too.
| 1 | <?php namespace Arcanedev\LaravelMetrics\Metrics; |
||
| 17 | abstract class Trend extends Metric |
||
| 18 | { |
||
| 19 | /* ----------------------------------------------------------------- |
||
| 20 | | Constants |
||
| 21 | | ----------------------------------------------------------------- |
||
| 22 | */ |
||
| 23 | |||
| 24 | /** |
||
| 25 | * Trend metric unit constants. |
||
| 26 | */ |
||
| 27 | const BY_MONTHS = 'month'; |
||
| 28 | const BY_WEEKS = 'week'; |
||
| 29 | const BY_DAYS = 'day'; |
||
| 30 | const BY_HOURS = 'hour'; |
||
| 31 | const BY_MINUTES = 'minute'; |
||
| 32 | |||
| 33 | /* ----------------------------------------------------------------- |
||
| 34 | | Traits |
||
| 35 | | ----------------------------------------------------------------- |
||
| 36 | */ |
||
| 37 | |||
| 38 | use HasExpressions, |
||
| 39 | Concerns\HasRanges, |
||
| 40 | Concerns\FormatsTrends; |
||
| 41 | |||
| 42 | /* ----------------------------------------------------------------- |
||
| 43 | | Getters |
||
| 44 | | ----------------------------------------------------------------- |
||
| 45 | */ |
||
| 46 | |||
| 47 | /** |
||
| 48 | * Get the metric type. |
||
| 49 | * |
||
| 50 | * @return string |
||
| 51 | */ |
||
| 52 | 8 | public function type(): string |
|
| 56 | |||
| 57 | /* ----------------------------------------------------------------- |
||
| 58 | | Main Methods |
||
| 59 | | ----------------------------------------------------------------- |
||
| 60 | */ |
||
| 61 | |||
| 62 | /** |
||
| 63 | * Return a value result showing a count aggregate over months. |
||
| 64 | * |
||
| 65 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 66 | * @param string|null $column |
||
| 67 | * |
||
| 68 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 69 | */ |
||
| 70 | public function countByMonths($model, $column = null) |
||
| 74 | |||
| 75 | /** |
||
| 76 | * Return a value result showing a count aggregate over weeks. |
||
| 77 | * |
||
| 78 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 79 | * @param string|null $column |
||
| 80 | * |
||
| 81 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 82 | */ |
||
| 83 | public function countByWeeks($model, $column = null) |
||
| 87 | |||
| 88 | /** |
||
| 89 | * Return a value result showing a count aggregate over days. |
||
| 90 | * |
||
| 91 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 92 | * @param string|null $column |
||
| 93 | * |
||
| 94 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 95 | */ |
||
| 96 | 8 | public function countByDays($model, $column = null) |
|
| 100 | |||
| 101 | /** |
||
| 102 | * Return a value result showing a count aggregate over hours. |
||
| 103 | * |
||
| 104 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 105 | * @param string|null $column |
||
| 106 | * |
||
| 107 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 108 | */ |
||
| 109 | public function countByHours($model, $column = null) |
||
| 113 | |||
| 114 | /** |
||
| 115 | * Return a value result showing a count aggregate over minutes. |
||
| 116 | * |
||
| 117 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 118 | * @param string|null $column |
||
| 119 | * |
||
| 120 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 121 | */ |
||
| 122 | public function countByMinutes($model, $column = null) |
||
| 126 | |||
| 127 | /** |
||
| 128 | * Return a value result showing a count aggregate over time. |
||
| 129 | * |
||
| 130 | * @param string $unit |
||
| 131 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 132 | * @param string|null $dateColumn |
||
| 133 | * @param string|null $column |
||
| 134 | * |
||
| 135 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 136 | */ |
||
| 137 | 8 | public function count($unit, $model, $dateColumn = null, $column = null) |
|
| 141 | |||
| 142 | /** |
||
| 143 | * Return a value result showing a average aggregate over months. |
||
| 144 | * |
||
| 145 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 146 | * @param string $column |
||
| 147 | * @param string|null $dateColumn |
||
| 148 | * |
||
| 149 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 150 | */ |
||
| 151 | public function averageByMonths($model, $column, $dateColumn = null) |
||
| 155 | |||
| 156 | /** |
||
| 157 | * Return a value result showing a average aggregate over weeks. |
||
| 158 | * |
||
| 159 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 160 | * @param string $column |
||
| 161 | * @param string|null $dateColumn |
||
| 162 | * |
||
| 163 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 164 | */ |
||
| 165 | public function averageByWeeks($model, $column, $dateColumn = null) |
||
| 169 | |||
| 170 | /** |
||
| 171 | * Return a value result showing a average aggregate over days. |
||
| 172 | * |
||
| 173 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 174 | * @param string $column |
||
| 175 | * @param string|null $dateColumn |
||
| 176 | * |
||
| 177 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 178 | */ |
||
| 179 | public function averageByDays($model, $column, $dateColumn = null) |
||
| 183 | |||
| 184 | /** |
||
| 185 | * Return a value result showing a average aggregate over hours. |
||
| 186 | * |
||
| 187 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 188 | * @param string $column |
||
| 189 | * @param string|null $dateColumn |
||
| 190 | * |
||
| 191 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 192 | */ |
||
| 193 | public function averageByHours($model, $column, $dateColumn = null) |
||
| 197 | |||
| 198 | /** |
||
| 199 | * Return a value result showing a average aggregate over minutes. |
||
| 200 | * |
||
| 201 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 202 | * @param string $column |
||
| 203 | * @param string|null $dateColumn |
||
| 204 | * |
||
| 205 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 206 | */ |
||
| 207 | public function averageByMinutes($model, $column, $dateColumn = null) |
||
| 211 | |||
| 212 | /** |
||
| 213 | * Return a value result showing a average aggregate over time. |
||
| 214 | * |
||
| 215 | * @param string $unit |
||
| 216 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 217 | * @param string $column |
||
| 218 | * @param string|null $dateColumn |
||
| 219 | * |
||
| 220 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 221 | */ |
||
| 222 | public function average(string $unit, $model, $column, $dateColumn = null) |
||
| 226 | |||
| 227 | /** |
||
| 228 | * Return a value result showing a sum aggregate over months. |
||
| 229 | * |
||
| 230 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 231 | * @param string $column |
||
| 232 | * @param string|null $dateColumn |
||
| 233 | * |
||
| 234 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 235 | */ |
||
| 236 | public function sumByMonths($model, $column, $dateColumn = null) |
||
| 240 | |||
| 241 | /** |
||
| 242 | * Return a value result showing a sum aggregate over weeks. |
||
| 243 | * |
||
| 244 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 245 | * @param string $column |
||
| 246 | * @param string $dateColumn |
||
| 247 | * |
||
| 248 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 249 | */ |
||
| 250 | public function sumByWeeks($model, $column, $dateColumn = null) |
||
| 254 | |||
| 255 | /** |
||
| 256 | * Return a value result showing a sum aggregate over days. |
||
| 257 | * |
||
| 258 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 259 | * @param string $column |
||
| 260 | * @param string|null $dateColumn |
||
| 261 | * |
||
| 262 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 263 | */ |
||
| 264 | public function sumByDays($model, $column, $dateColumn = null) |
||
| 268 | |||
| 269 | /** |
||
| 270 | * Return a value result showing a sum aggregate over hours. |
||
| 271 | * |
||
| 272 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 273 | * @param string $column |
||
| 274 | * @param string $dateColumn |
||
| 275 | * |
||
| 276 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 277 | */ |
||
| 278 | public function sumByHours($model, $column, $dateColumn = null) |
||
| 282 | |||
| 283 | /** |
||
| 284 | * Return a value result showing a sum aggregate over minutes. |
||
| 285 | * |
||
| 286 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 287 | * @param string $column |
||
| 288 | * @param string|null $dateColumn |
||
| 289 | * |
||
| 290 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 291 | */ |
||
| 292 | public function sumByMinutes($model, $column, $dateColumn = null) |
||
| 296 | |||
| 297 | /** |
||
| 298 | * Return a value result showing a sum aggregate over time. |
||
| 299 | * |
||
| 300 | * @param string $unit |
||
| 301 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 302 | * @param string $column |
||
| 303 | * @param string|null $dateColumn |
||
| 304 | * |
||
| 305 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 306 | */ |
||
| 307 | public function sum(string $unit, $model, $column, $dateColumn = null) |
||
| 311 | |||
| 312 | /** |
||
| 313 | * Return a value result showing a max aggregate over months. |
||
| 314 | * |
||
| 315 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 316 | * @param string $column |
||
| 317 | * @param string|null $dateColumn |
||
| 318 | * |
||
| 319 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 320 | */ |
||
| 321 | public function maxByMonths($model, $column, $dateColumn = null) |
||
| 325 | |||
| 326 | /** |
||
| 327 | * Return a value result showing a max aggregate over weeks. |
||
| 328 | * |
||
| 329 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 330 | * @param string $column |
||
| 331 | * @param string|null $dateColumn |
||
| 332 | * |
||
| 333 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 334 | */ |
||
| 335 | public function maxByWeeks($model, $column, $dateColumn = null) |
||
| 339 | |||
| 340 | /** |
||
| 341 | * Return a value result showing a max aggregate over days. |
||
| 342 | * |
||
| 343 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 344 | * @param string $column |
||
| 345 | * @param string|null $dateColumn |
||
| 346 | * |
||
| 347 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 348 | */ |
||
| 349 | public function maxByDays($model, $column, $dateColumn = null) |
||
| 353 | |||
| 354 | /** |
||
| 355 | * Return a value result showing a max aggregate over hours. |
||
| 356 | * |
||
| 357 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 358 | * @param string $column |
||
| 359 | * @param string|null $dateColumn |
||
| 360 | * |
||
| 361 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 362 | */ |
||
| 363 | public function maxByHours($model, $column, $dateColumn = null) |
||
| 367 | |||
| 368 | /** |
||
| 369 | * Return a value result showing a max aggregate over minutes. |
||
| 370 | * |
||
| 371 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 372 | * @param string $column |
||
| 373 | * @param string|null $dateColumn |
||
| 374 | * |
||
| 375 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 376 | */ |
||
| 377 | public function maxByMinutes($model, $column, $dateColumn = null) |
||
| 381 | |||
| 382 | /** |
||
| 383 | * Return a value result showing a max aggregate over time. |
||
| 384 | * |
||
| 385 | * @param string $unit |
||
| 386 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 387 | * @param string $column |
||
| 388 | * @param string|null $dateColumn |
||
| 389 | * |
||
| 390 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 391 | */ |
||
| 392 | public function max(string $unit, $model, $column, $dateColumn = null) |
||
| 396 | |||
| 397 | /** |
||
| 398 | * Return a value result showing a min aggregate over months. |
||
| 399 | * |
||
| 400 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 401 | * @param string $column |
||
| 402 | * @param string|null $dateColumn |
||
| 403 | * |
||
| 404 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 405 | */ |
||
| 406 | public function minByMonths($model, $column, $dateColumn = null) |
||
| 410 | |||
| 411 | /** |
||
| 412 | * Return a value result showing a min aggregate over weeks. |
||
| 413 | * |
||
| 414 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 415 | * @param string $column |
||
| 416 | * @param string|null $dateColumn |
||
| 417 | * |
||
| 418 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 419 | */ |
||
| 420 | public function minByWeeks($model, $column, $dateColumn = null) |
||
| 424 | |||
| 425 | /** |
||
| 426 | * Return a value result showing a min aggregate over days. |
||
| 427 | * |
||
| 428 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 429 | * @param string $column |
||
| 430 | * @param string|null $dateColumn |
||
| 431 | * |
||
| 432 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 433 | */ |
||
| 434 | public function minByDays($model, $column, $dateColumn = null) |
||
| 438 | |||
| 439 | /** |
||
| 440 | * Return a value result showing a min aggregate over hours. |
||
| 441 | * |
||
| 442 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 443 | * @param string $column |
||
| 444 | * @param string|null $dateColumn |
||
| 445 | * |
||
| 446 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 447 | */ |
||
| 448 | public function minByHours($model, $column, $dateColumn = null) |
||
| 452 | |||
| 453 | /** |
||
| 454 | * Return a value result showing a min aggregate over minutes. |
||
| 455 | * |
||
| 456 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 457 | * @param string $column |
||
| 458 | * @param string|null $dateColumn |
||
| 459 | * |
||
| 460 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 461 | */ |
||
| 462 | public function minByMinutes($model, $column, $dateColumn = null) |
||
| 466 | |||
| 467 | /** |
||
| 468 | * Return a value result showing a min aggregate over time. |
||
| 469 | * |
||
| 470 | * @param string $unit |
||
| 471 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 472 | * @param string $column |
||
| 473 | * @param string|null $dateColumn |
||
| 474 | * |
||
| 475 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 476 | */ |
||
| 477 | public function min(string $unit, $model, $column, $dateColumn = null) |
||
| 481 | |||
| 482 | /** |
||
| 483 | * Make a new result instance. |
||
| 484 | * |
||
| 485 | * @param mixed|null $value |
||
| 486 | * |
||
| 487 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 488 | */ |
||
| 489 | 8 | protected function result($value = null) |
|
| 493 | |||
| 494 | /* ----------------------------------------------------------------- |
||
| 495 | | Other Methods |
||
| 496 | | ----------------------------------------------------------------- |
||
| 497 | */ |
||
| 498 | |||
| 499 | /** |
||
| 500 | * Handle the aggregate calculation of the metric. |
||
| 501 | * |
||
| 502 | * @param string $method |
||
| 503 | * @param string $unit |
||
| 504 | * @param \Illuminate\Database\Eloquent\Builder|string $model |
||
| 505 | * @param string|null $column |
||
| 506 | * @param string|null $dateColumn |
||
| 507 | * |
||
| 508 | * @return \Arcanedev\LaravelMetrics\Results\TrendResult|mixed |
||
| 509 | */ |
||
| 510 | 8 | protected function aggregate(string $method, string $unit, $model, ?string $column = null, ?string $dateColumn = null) |
|
| 558 | |||
| 559 | /** |
||
| 560 | * Parse the date result. |
||
| 561 | * |
||
| 562 | * @param string $dateResult |
||
| 563 | * @param string $unit |
||
| 564 | * |
||
| 565 | * @return \Cake\Chronos\Chronos |
||
| 566 | */ |
||
| 567 | 8 | protected function parseDateResult(string $dateResult, string $unit): Chronos |
|
| 590 | |||
| 591 | /** |
||
| 592 | * Determine the proper aggregate starting date. |
||
| 593 | * |
||
| 594 | * @param string $unit |
||
| 595 | * |
||
| 596 | * @return \Cake\Chronos\Chronos |
||
| 597 | */ |
||
| 598 | 8 | protected function getAggregateStartingDate(string $unit): Chronos |
|
| 626 | |||
| 627 | /** |
||
| 628 | * Get all of the possible date results for the given units. |
||
| 629 | * |
||
| 630 | * @param \Cake\Chronos\Chronos $startDate |
||
| 631 | * @param \Cake\Chronos\Chronos $endDate |
||
| 632 | * @param string $unit |
||
| 633 | * @param mixed $timezone |
||
| 634 | * @param bool $twelveHourTime |
||
| 635 | * |
||
| 636 | * @return array |
||
| 637 | */ |
||
| 638 | 8 | protected function getAllPossibleDateResults( |
|
| 675 | |||
| 676 | /** |
||
| 677 | * Prepare the metric for JSON serialization. |
||
| 678 | * |
||
| 679 | * @return array |
||
| 680 | */ |
||
| 681 | public function toArray(): array |
||
| 688 | } |
||
| 689 |
It seems like the method you are trying to call exists only in some of the possible types.
Let’s take a look at an example:
Available Fixes
Add an additional type-check:
Only allow a single type to be passed if the variable comes from a parameter: