AuthorizationServiceProvider::boot() - Code Metrics - Inspection of "Updating the package to support Laravel 7" - ARCANEDEV/LaravelImpersonator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#12)

by ARCANEDEV

created 2020-03-07 11:51 UTC

AuthorizationServiceProvider::boot() A

↳ Parent: AuthorizationServiceProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
nc	2
nop	0
dl	0
loc	10
ccs	6
cts	6
cp	1
crap	2
rs	9.9332
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Arcanedev\LaravelImpersonator\Providers;

use Arcanedev\LaravelPolicies\Contracts\PolicyManager;
use Arcanedev\Support\Providers\AuthorizationServiceProvider as ServiceProvider;

/**
 * Class     AuthorizationServiceProvider
 *
 * @package  Arcanedev\LaravelImpersonator\Providers
 * @author   ARCANEDEV <[email protected]>
 */
class AuthorizationServiceProvider extends ServiceProvider
{
    /* -----------------------------------------------------------------
     |  Getters
     | -----------------------------------------------------------------
     */

    /**
     * Get policy's classes.
     *
     * @return iterable
     */
    public function policyClasses(): iterable
    {
        return (array) config('impersonator.policies', []);
    }

    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Register any application authentication / authorization services.
     */
    public function boot(): void
    {
        parent::registerPolicies();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

        $manager = $this->app->make(PolicyManager::class);

        foreach ($this->policyClasses() as $class) {
            $manager->registerClass($class);
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Arcanedev\LaravelImpersonator\Providers;
6
7		use Arcanedev\LaravelPolicies\Contracts\PolicyManager;
8		use Arcanedev\Support\Providers\AuthorizationServiceProvider as ServiceProvider;
9
10		/**
11		* Class AuthorizationServiceProvider
12		*
13		* @package Arcanedev\LaravelImpersonator\Providers
14		* @author ARCANEDEV <[email protected]>
15		*/
16		class AuthorizationServiceProvider extends ServiceProvider
17		{
18		/* -----------------------------------------------------------------
19		\| Getters
20		\| -----------------------------------------------------------------
21		*/
22
23		/**
24		* Get policy's classes.
25		*
26		* @return iterable
27		*/
28	168	public function policyClasses(): iterable
29		{
30	168	return (array) config('impersonator.policies', []);
31		}
32
33		/* -----------------------------------------------------------------
34		\| Main Methods
35		\| -----------------------------------------------------------------
36		*/
37
38		/**
39		* Register any application authentication / authorization services.
40		*/
41	168	public function boot(): void
42		{
43	168	parent::registerPolicies();
		0 ignored issues – show Comprehensibility Bug introduced 2020-03-07 11:57 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`registerPolicies()` instead of `boot()`). Are you sure this is correct? If so, you might want to change this to `$this->registerPolicies()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
44
45	168	$manager = $this->app->make(PolicyManager::class);
46
47	168	foreach ($this->policyClasses() as $class) {
48	168	$manager->registerClass($class);
49		}
50	168	}
51		}
52

ARCANEDEV / LaravelImpersonator

Pull Request — master (#12)

AuthorizationServiceProvider::boot() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like