Attributes::makeAttributeElement() - Code Metrics - Inspection of "Updating the Form::select() method" - ARCANEDEV/LaravelHtml - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#23)

by ARCANEDEV

created 2018-03-10 21:28 UTC

Attributes::makeAttributeElement() B

↳ Parent: Attributes

Complexity

Conditions	6
Paths	5

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	8
cts	8
cp	1
rs	8.8571
c	0
b	0
f	0
cc	6
eloc	8
nc	5
nop	2
crap	6

<?php namespace Arcanedev\LaravelHtml\Helpers;

/**
 * Class     Attributes
 *
 * @package  Arcanedev\LaravelHtml\Helpers
 * @author   ARCANEDEV <[email protected]>
 */
class Attributes
{
    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Build an HTML attribute string from an array.
     *
     * @param  array  $attributes
     *
     * @return string
     */
    public static function make(array $attributes)
    {
        $html = [];

        foreach ((array) $attributes as $key => $value) {
            $element = static::makeAttributeElement($key, $value);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}

            if ( ! is_null($element))
                $html[] = $element;
        }

        return (count($html) > 0) ? ' '.implode(' ', array_filter($html)) : '';
    }

    /* -----------------------------------------------------------------
     |  Other Methods
     | -----------------------------------------------------------------
     */

    /**
     * Make attribute element.
     *
     * @param  mixed  $key
     * @param  mixed  $value
     *
     * @return null|string
     */
    private static function makeAttributeElement($key, $value)
    {
        if (is_null($value))
            return null;

        // For numeric keys we will assume that the key and the value are the same
        // as this will convert HTML attributes such as "required" to a correct
        // form like required="required" instead of using incorrect numerics.
        if (is_numeric($key))
            return $value;

        if (is_bool($value) && $key !== 'value')
            return $value ? $key : '';

        return $key.'="'.e($value).'"';
    }
}


1		<?php namespace Arcanedev\LaravelHtml\Helpers;
2
3		/**
4		* Class Attributes
5		*
6		* @package Arcanedev\LaravelHtml\Helpers
7		* @author ARCANEDEV <[email protected]>
8		*/
9		class Attributes
10		{
11		/* -----------------------------------------------------------------
12		\| Main Methods
13		\| -----------------------------------------------------------------
14		*/
15
16		/**
17		* Build an HTML attribute string from an array.
18		*
19		* @param array $attributes
20		*
21		* @return string
22		*/
23	384	public static function make(array $attributes)
24		{
25	384	$html = [];
26
27	384	foreach ((array) $attributes as $key => $value) {
28	348	$element = static::makeAttributeElement($key, $value);
		0 ignored issues – show Bug introduced 2016-07-17 01:50 UTC by Report Bug Copy Issue Report Since `makeAttributeElement()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `makeAttributeElement()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
29
30	348	if ( ! is_null($element))
31	346	$html[] = $element;
32		}
33
34	384	return (count($html) > 0) ? ' '.implode(' ', array_filter($html)) : '';
35		}
36
37		/* -----------------------------------------------------------------
38		\| Other Methods
39		\| -----------------------------------------------------------------
40		*/
41
42		/**
43		* Make attribute element.
44		*
45		* @param mixed $key
46		* @param mixed $value
47		*
48		* @return null\|string
49		*/
50	348	private static function makeAttributeElement($key, $value)
51		{
52	348	if (is_null($value))
53	261	return null;
54
55		// For numeric keys we will assume that the key and the value are the same
56		// as this will convert HTML attributes such as "required" to a correct
57		// form like required="required" instead of using incorrect numerics.
58	342	if (is_numeric($key))
59	9	return $value;
60
61	342	if (is_bool($value) && $key !== 'value')
62	3	return $value ? $key : '';
63
64	342	return $key.'="'.e($value).'"';
65		}
66		}
67

ARCANEDEV / LaravelHtml

Pull Request — master (#23)

Attributes::makeAttributeElement() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like