Issues in AbstractExporter.php (master) - Issues in master - ARCANEDEV/LaravelExcel - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Exporters/AbstractExporter.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php namespace Arcanedev\LaravelExcel\Exporters;

use Arcanedev\LaravelExcel\Contracts\Exporter as ExporterContract;
use Arcanedev\LaravelExcel\Contracts\Serializer as SerializerContract;
use Arcanedev\LaravelExcel\Traits\WithOptions;
use Box\Spout\Writer\WriterFactory;
use Illuminate\Support\Collection;

/**
 * Class     AbstractExporter
 *
 * @package  Arcanedev\LaravelExcel\Exporter
 * @author   ARCANEDEV <[email protected]>
 */
abstract class AbstractExporter implements ExporterContract
{
    /* -----------------------------------------------------------------
     |  Traits
     | -----------------------------------------------------------------
     */

    use WithOptions;

    /* -----------------------------------------------------------------
     |  Properties
     | -----------------------------------------------------------------
     */

    /** @var array */
    protected $data = [];

    /** @var string */
    protected $type;

    /** @var \Arcanedev\LaravelExcel\Contracts\Serializer */
    protected $serializer;

    /** @var \Box\Spout\Writer\WriterInterface */
    protected $writer;

    /* -----------------------------------------------------------------
     |  Constructor
     | -----------------------------------------------------------------
     */

    /**
     * AbstractExporter constructor.
     *
     * @param  array  $options
     */
    public function __construct(array $options = [])
    {
        $this->setSerializer(new DefaultSerializer);
        $this->setOptions($options);
    }

    /* -----------------------------------------------------------------
     |  Getters & Setters
     | -----------------------------------------------------------------
     */

    /**
     * Set the serializer.
     *
     * @param  \Arcanedev\LaravelExcel\Contracts\Serializer  $serializer
     *
     * @return self
     */
    public function setSerializer(SerializerContract $serializer)
    {
        $this->serializer = $serializer;

        return $this;
    }

    /**
     * Get the file type.
     *
     * @return string
     */
    public function getType()
    {
        return $this->type;
    }

    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Load the data.
     *
     * @param  \Illuminate\Support\Collection  $data
     *
     * @return self
     */
    public function load(Collection $data)
    {
        $this->data = $data;


        return $this;
    }

    /**
     * Save the data to a file.
     *
     * @param  string  $filename
     */
    public function save($filename)
    {
        $this->create();
        $this->writer->openToFile($filename);
        $this->makeRows();
        $this->close();
    }

    /* -----------------------------------------------------------------
     |  Other Methods
     | -----------------------------------------------------------------
     */

    /**
     * Create the writer.
     */
    protected function create()
    {
        $this->writer = WriterFactory::create($this->type);
        $this->loadOptions();
    }

    /**
     * Load the writer options.
     */
    abstract protected function loadOptions();

    /**
     * Close the writer.
     */
    protected function close()
    {
        $this->writer->close();
    }

    /**
     * Make rows.
     */
    protected function makeRows()
    {
        if ( ! empty($headerRow = $this->serializer->getHeader()))
            $this->writer->addRow($headerRow);

        foreach ($this->data as $record) {
            $this->writer->addRow(
                $this->serializer->getData($record)
            );
        }
    }
}


1		<?php namespace Arcanedev\LaravelExcel\Exporters;
2
3		use Arcanedev\LaravelExcel\Contracts\Exporter as ExporterContract;
4		use Arcanedev\LaravelExcel\Contracts\Serializer as SerializerContract;
5		use Arcanedev\LaravelExcel\Traits\WithOptions;
6		use Box\Spout\Writer\WriterFactory;
7		use Illuminate\Support\Collection;
8
9		/**
10		* Class AbstractExporter
11		*
12		* @package Arcanedev\LaravelExcel\Exporter
13		* @author ARCANEDEV <[email protected]>
14		*/
15		abstract class AbstractExporter implements ExporterContract
16		{
17		/* -----------------------------------------------------------------
18		\| Traits
19		\| -----------------------------------------------------------------
20		*/
21
22		use WithOptions;
23
24		/* -----------------------------------------------------------------
25		\| Properties
26		\| -----------------------------------------------------------------
27		*/
28
29		/** @var array */
30		protected $data = [];
31
32		/** @var string */
33		protected $type;
34
35		/** @var \Arcanedev\LaravelExcel\Contracts\Serializer */
36		protected $serializer;
37
38		/** @var \Box\Spout\Writer\WriterInterface */
39		protected $writer;
40
41		/* -----------------------------------------------------------------
42		\| Constructor
43		\| -----------------------------------------------------------------
44		*/
45
46		/**
47		* AbstractExporter constructor.
48		*
49		* @param array $options
50		*/
51	45	public function __construct(array $options = [])
52		{
53	45	$this->setSerializer(new DefaultSerializer);
54	45	$this->setOptions($options);
55	45	}
56
57		/* -----------------------------------------------------------------
58		\| Getters & Setters
59		\| -----------------------------------------------------------------
60		*/
61
62		/**
63		* Set the serializer.
64		*
65		* @param \Arcanedev\LaravelExcel\Contracts\Serializer $serializer
66		*
67		* @return self
68		*/
69	45	public function setSerializer(SerializerContract $serializer)
70		{
71	45	$this->serializer = $serializer;
72
73	45	return $this;
74		}
75
76		/**
77		* Get the file type.
78		*
79		* @return string
80		*/
81	18	public function getType()
82		{
83	18	return $this->type;
84		}
85
86		/* -----------------------------------------------------------------
87		\| Main Methods
88		\| -----------------------------------------------------------------
89		*/
90
91		/**
92		* Load the data.
93		*
94		* @param \Illuminate\Support\Collection $data
95		*
96		* @return self
97		*/
98	9	public function load(Collection $data)
99		{
100	9	$this->data = $data;
		0 ignored issues – show Documentation Bug introduced 2016-11-01 20:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$data` of type `object<Illuminate\Support\Collection>` is incompatible with the declared type `array` of property `$data`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
101
102	9	return $this;
103		}
104
105		/**
106		* Save the data to a file.
107		*
108		* @param string $filename
109		*/
110	9	public function save($filename)
111		{
112	9	$this->create();
113	9	$this->writer->openToFile($filename);
114	9	$this->makeRows();
115	9	$this->close();
116	9	}
117
118		/* -----------------------------------------------------------------
119		\| Other Methods
120		\| -----------------------------------------------------------------
121		*/
122
123		/**
124		* Create the writer.
125		*/
126	9	protected function create()
127		{
128	9	$this->writer = WriterFactory::create($this->type);
129	9	$this->loadOptions();
130	9	}
131
132		/**
133		* Load the writer options.
134		*/
135		abstract protected function loadOptions();
136
137		/**
138		* Close the writer.
139		*/
140	9	protected function close()
141		{
142	9	$this->writer->close();
143	9	}
144
145		/**
146		* Make rows.
147		*/
148	9	protected function makeRows()
149		{
150	9	if ( ! empty($headerRow = $this->serializer->getHeader()))
151		$this->writer->addRow($headerRow);
152
153	9	foreach ($this->data as $record) {
154	6	$this->writer->addRow(
155	6	$this->serializer->getData($record)
156		);
157		}
158	9	}
159		}
160

ARCANEDEV / LaravelExcel

Issues (1)

Security Analysis no request data

src/Exporters/AbstractExporter.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like