LaravelAuthServiceProvider::bindModels() - Code Metrics - Inspection of "Updating the model observers and other stuff" - ARCANEDEV/LaravelAuth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by ARCANEDEV

created 2015-12-22 14:39 UTC

LaravelAuthServiceProvider::bindModels() B

↳ Parent: LaravelAuthServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	25
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	25
rs	8.8571
c	1
b	0
f	0
ccs	19
cts	19
cp	1
cc	1
eloc	14
nc	1
nop	0
crap	1

<?php namespace Arcanedev\LaravelAuth;

use Arcanedev\Support\PackageServiceProvider as ServiceProvider;

/**
 * Class     LaravelAuthServiceProvider
 *
 * @package  Arcanedev\LaravelAuth
 * @author   ARCANEDEV <[email protected]>
 */
class LaravelAuthServiceProvider extends ServiceProvider
{
    /* ------------------------------------------------------------------------------------------------
     |  Properties
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Vendor name.
     *
     * @var string
     */
    protected $vendor  = 'arcanedev';

    /**
     * Package name.
     *
     * @var string
     */
    protected $package = 'laravel-auth';

    /* ------------------------------------------------------------------------------------------------
     |  Getters & Setters
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Get the base path of the package.
     *
     * @return string
     */
    public function getBasePath()
    {
        return dirname(__DIR__);
    }

    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Register the service provider.
     */
    public function register()
    {
        $this->registerConfig();

        $this->bindModels();

        if ($this->app['config']->get('laravel-auth.user-observers', false)) {
            $this->app->register(Providers\EventServiceProvider::class);
        }
    }

    /**
     * Boot the service provider.
     */
    public function boot()
    {
        parent::boot();

        $this->registerPublishes();
        $this->registerBladeDirectives();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }

    /**
     * Get the services provided by the provider.
     *
     * @return array
     */
    public function provides()
    {
        return [
            //
        ];
    }

    /* ------------------------------------------------------------------------------------------------
     |  Other Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Register all publishable stuff.
     */
    private function registerPublishes()
    {
        $this->publishes([
            $this->getConfigFile() => config_path("{$this->package}.php"),
        ], 'config');

        $this->publishes([
            $this->getBasePath() . DS . 'database/migrations' => database_path('migrations'),
        ], 'migrations');

        $this->publishes([
            $this->getBasePath() . DS . 'database/factories' => database_path('factories'),
        ], 'factories');
    }

    /**
     * Register blade directives
     */
    private function registerBladeDirectives()
    {
        // Coming soon
    }

    private function bindModels()
    {
        /** @var \Illuminate\Contracts\Config\Repository $config */
        $config = $this->app['config'];

        $this->bind(
            \Arcanesoft\Contracts\Auth\Models\User::class,
            $config->get('laravel-auth.users.model')
        );

        $this->bind(
            \Arcanesoft\Contracts\Auth\Models\Role::class,
            $config->get('laravel-auth.roles.model')
        );

        $this->bind(
            \Arcanesoft\Contracts\Auth\Models\Permission::class,
            $config->get('laravel-auth.permissions.model')
        );

        $this->bind(
            \Arcanesoft\Contracts\Auth\Models\PermissionsGroup::class,
            $config->get('laravel-auth.permissions-groups.model')
        );
    }
}


1		<?php namespace Arcanedev\LaravelAuth;
2
3		use Arcanedev\Support\PackageServiceProvider as ServiceProvider;
4
5		/**
6		* Class LaravelAuthServiceProvider
7		*
8		* @package Arcanedev\LaravelAuth
9		* @author ARCANEDEV <[email protected]>
10		*/
11		class LaravelAuthServiceProvider extends ServiceProvider
12		{
13		/* ------------------------------------------------------------------------------------------------
14		\| Properties
15		\| ------------------------------------------------------------------------------------------------
16		*/
17		/**
18		* Vendor name.
19		*
20		* @var string
21		*/
22		protected $vendor = 'arcanedev';
23
24		/**
25		* Package name.
26		*
27		* @var string
28		*/
29		protected $package = 'laravel-auth';
30
31		/* ------------------------------------------------------------------------------------------------
32		\| Getters & Setters
33		\| ------------------------------------------------------------------------------------------------
34		*/
35		/**
36		* Get the base path of the package.
37		*
38		* @return string
39		*/
40	260	public function getBasePath()
41		{
42	260	return dirname(__DIR__);
43		}
44
45		/* ------------------------------------------------------------------------------------------------
46		\| Main Functions
47		\| ------------------------------------------------------------------------------------------------
48		*/
49		/**
50		* Register the service provider.
51		*/
52	260	public function register()
53		{
54	260	$this->registerConfig();
55
56	260	$this->bindModels();
57
58	260	if ($this->app['config']->get('laravel-auth.user-observers', false)) {
59	260	$this->app->register(Providers\EventServiceProvider::class);
60	195	}
61	260	}
62
63		/**
64		* Boot the service provider.
65		*/
66	260	public function boot()
67		{
68	260	parent::boot();
69
70	260	$this->registerPublishes();
71	260	$this->registerBladeDirectives();
		0 ignored issues – show Unused Code introduced 2015-12-15 17:06 UTC by Report Bug Copy Issue Report The call to the method `Arcanedev\LaravelAuth\La...gisterBladeDirectives()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
72	260	}
73
74		/**
75		* Get the services provided by the provider.
76		*
77		* @return array
78		*/
79	4	public function provides()
80		{
81		return [
82		//
83	4	];
84		}
85
86		/* ------------------------------------------------------------------------------------------------
87		\| Other Functions
88		\| ------------------------------------------------------------------------------------------------
89		*/
90		/**
91		* Register all publishable stuff.
92		*/
93	260	private function registerPublishes()
94		{
95	260	$this->publishes([
96	260	$this->getConfigFile() => config_path("{$this->package}.php"),
97	260	], 'config');
98
99	260	$this->publishes([
100	260	$this->getBasePath() . DS . 'database/migrations' => database_path('migrations'),
101	260	], 'migrations');
102
103	260	$this->publishes([
104	260	$this->getBasePath() . DS . 'database/factories' => database_path('factories'),
105	260	], 'factories');
106	260	}
107
108		/**
109		* Register blade directives
110		*/
111	260	private function registerBladeDirectives()
112		{
113		// Coming soon
114	260	}
115
116	260	private function bindModels()
117		{
118		/** @var \Illuminate\Contracts\Config\Repository $config */
119	260	$config = $this->app['config'];
120
121	260	$this->bind(
122	260	\Arcanesoft\Contracts\Auth\Models\User::class,
123	260	$config->get('laravel-auth.users.model')
124	195	);
125
126	260	$this->bind(
127	260	\Arcanesoft\Contracts\Auth\Models\Role::class,
128	260	$config->get('laravel-auth.roles.model')
129	195	);
130
131	260	$this->bind(
132	260	\Arcanesoft\Contracts\Auth\Models\Permission::class,
133	260	$config->get('laravel-auth.permissions.model')
134	195	);
135
136	260	$this->bind(
137	260	\Arcanesoft\Contracts\Auth\Models\PermissionsGroup::class,
138	260	$config->get('laravel-auth.permissions-groups.model')
139	195	);
140	260	}
141		}
142

ARCANEDEV / LaravelAuth

Pull Request — master (#3)

LaravelAuthServiceProvider::bindModels() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like