Issues in GravatarServiceProvider.php - New Issues - Inspection of "Merge pull request #2 from ARCANEDEV/patch-1" - ARCANEDEV/Gravatar - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 11f9a0...c74065 )

by ARCANEDEV

created 2016-04-17 21:39 UTC

src/GravatarServiceProvider.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php namespace Arcanedev\Gravatar;

use Arcanedev\Support\PackageServiceProvider as ServiceProvider;

/**
 * Class     GravatarServiceProvider
 *
 * @package  Arcanedev\Gravatar
 * @author   ARCANEDEV <[email protected]>
 */
class GravatarServiceProvider extends ServiceProvider
{
    /* ------------------------------------------------------------------------------------------------
     |  Properties
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Vendor name.
     *
     * @var string
     */
    protected $vendor  = 'arcanedev';

    /**
     * Package name.
     *
     * @var string
     */
    protected $package = 'gravatar';

    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var bool
     */
    protected $defer   = true;

    /* ------------------------------------------------------------------------------------------------
     |  Getters & Setters
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Get the base path of the package.
     *
     * @return string
     */
    public function getBasePath()
    {
        return dirname(__DIR__);
    }

    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Register the service provider.
     */
    public function register()
    {
        $this->registerConfig();
        $this->registerGravatar();
    }

    /**
     * Boot the service provider.
     */
    public function boot()
    {
        $this->publishConfig();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * Get the services provided by the provider.
     *
     * @return array
     */
    public function provides()
    {
        return [
            'arcanedev.gravatar',
            Contracts\Gravatar::class,
        ];
    }

    /* ------------------------------------------------------------------------------------------------
     |  Other Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Register Gravatar Helper.
     */
    private function registerGravatar()
    {
        $this->singleton('arcanedev.gravatar', function($app) {
            /** @var \Illuminate\Config\Repository $config */
            $config = $app['config'];

            return new Gravatar(
                $config->get('gravatar.default', 'mm'),
                $config->get('gravatar.size', 80),
                $config->get('gravatar.max-rating', 'g')
            );
        });

        $this->bind(Contracts\Gravatar::class, 'arcanedev.gravatar');
    }
}


1		<?php namespace Arcanedev\Gravatar;
2
3		use Arcanedev\Support\PackageServiceProvider as ServiceProvider;
4
5		/**
6		* Class GravatarServiceProvider
7		*
8		* @package Arcanedev\Gravatar
9		* @author ARCANEDEV <[email protected]>
10		*/
11		class GravatarServiceProvider extends ServiceProvider
12		{
13		/* ------------------------------------------------------------------------------------------------
14		\| Properties
15		\| ------------------------------------------------------------------------------------------------
16		*/
17		/**
18		* Vendor name.
19		*
20		* @var string
21		*/
22		protected $vendor = 'arcanedev';
23
24		/**
25		* Package name.
26		*
27		* @var string
28		*/
29		protected $package = 'gravatar';
30
31		/**
32		* Indicates if loading of the provider is deferred.
33		*
34		* @var bool
35		*/
36		protected $defer = true;
37
38		/* ------------------------------------------------------------------------------------------------
39		\| Getters & Setters
40		\| ------------------------------------------------------------------------------------------------
41		*/
42		/**
43		* Get the base path of the package.
44		*
45		* @return string
46		*/
47	228	public function getBasePath()
48		{
49	228	return dirname(__DIR__);
50		}
51
52		/* ------------------------------------------------------------------------------------------------
53		\| Main Functions
54		\| ------------------------------------------------------------------------------------------------
55		*/
56		/**
57		* Register the service provider.
58		*/
59	228	public function register()
60		{
61	228	$this->registerConfig();
62	228	$this->registerGravatar();
63	228	}
64
65		/**
66		* Boot the service provider.
67		*/
68	228	public function boot()
69		{
70	228	$this->publishConfig();
		0 ignored issues – show Documentation Bug introduced 2016-04-17 21:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `publishConfig` does not exist on `object<Arcanedev\Gravata...ravatarServiceProvider>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
71	228	}
72
73		/**
74		* Get the services provided by the provider.
75		*
76		* @return array
77		*/
78	24	public function provides()
79		{
80		return [
81	24	'arcanedev.gravatar',
82	18	Contracts\Gravatar::class,
83	18	];
84		}
85
86		/* ------------------------------------------------------------------------------------------------
87		\| Other Functions
88		\| ------------------------------------------------------------------------------------------------
89		*/
90		/**
91		* Register Gravatar Helper.
92		*/
93		private function registerGravatar()
94		{
95	228	$this->singleton('arcanedev.gravatar', function($app) {
96		/** @var \Illuminate\Config\Repository $config */
97	192	$config = $app['config'];
98
99	192	return new Gravatar(
100	192	$config->get('gravatar.default', 'mm'),
101	192	$config->get('gravatar.size', 80),
102	192	$config->get('gravatar.max-rating', 'g')
103	144	);
104	228	});
105
106	228	$this->bind(Contracts\Gravatar::class, 'arcanedev.gravatar');
107	228	}
108		}
109

ARCANEDEV / Gravatar

Push — master ( 11f9a0...c74065 )

src/GravatarServiceProvider.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like