Issues in AbstractMeasure.php (master) - Issues in master - ARCANEDEV/GeoLocation - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Entities/Measures/AbstractMeasure.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php namespace Arcanedev\GeoLocation\Entities\Measures;

use Arcanedev\GeoLocation\Traits\CanBeJsonable;
use Illuminate\Contracts\Support\Arrayable;
use Illuminate\Contracts\Support\Jsonable;
use JsonSerializable;

/**
 * Class     AbstractMeasure
 *
 * @package  Arcanedev\GeoLocation\Entities\Measures
 * @author   ARCANEDEV <[email protected]>
 */
abstract class AbstractMeasure implements Arrayable, Jsonable, JsonSerializable
{
    /* -----------------------------------------------------------------
     |  Traits
     | -----------------------------------------------------------------
     */

    use CanBeJsonable;

    /* -----------------------------------------------------------------
     |  Properties
     | -----------------------------------------------------------------
     */

    /**
     * The text value.
     *
     * @var string
     */
    protected $text;

    /**
     * The numeric value.
     *
     * @var int
     */
    protected $value;

    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * AbstractMeasure constructor.
     *
     * @param  string     $text
     * @param  float|int  $value
     */
    public function __construct($text, $value)
    {
        $this->text  = $text;
        $this->value = $value;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /* -----------------------------------------------------------------
     |  Getters & Setters
     | -----------------------------------------------------------------
     */

    /**
     * Get the text (alias).
     *
     * @see getText
     *
     * @return string
     */
    public function text()
    {
        return $this->getText();
    }

    /**
     * Get the text.
     *
     * @return string
     */
    public function getText()
    {
        return $this->text;
    }

    /**
     * Get the value (alias).
     *
     * @see getValue
     *
     * @return float|int
     */
    public function value()
    {
        return $this->getValue();
    }

    /**
     * Get the value.
     *
     * @return float|int
     */
    public function getValue()
    {
        return $this->value;
    }

    /* -----------------------------------------------------------------
     |  Main Methods
     | -----------------------------------------------------------------
     */

    /**
     * Make a distance instance.
     *
     * @param  string  $text
     * @param  int     $value
     *
     * @return static
     */
    public static function make($text, $value)
    {
        return new static($text, $value);
    }

    /**
     * Make a distance instance from array.
     *
     * @param  array  $data
     *
     * @return static
     */
    public static function makeFromArray(array $data)
    {
        return static::make($data['text'], $data['value']);
    }

    /**
     * Get the instance as an array.
     *
     * @return array
     */
    public function toArray()
    {
        return [
            'text'  => $this->text(),
            'value' => $this->value(),
        ];
    }
}


1		<?php namespace Arcanedev\GeoLocation\Entities\Measures;
2
3		use Arcanedev\GeoLocation\Traits\CanBeJsonable;
4		use Illuminate\Contracts\Support\Arrayable;
5		use Illuminate\Contracts\Support\Jsonable;
6		use JsonSerializable;
7
8		/**
9		* Class AbstractMeasure
10		*
11		* @package Arcanedev\GeoLocation\Entities\Measures
12		* @author ARCANEDEV <[email protected]>
13		*/
14		abstract class AbstractMeasure implements Arrayable, Jsonable, JsonSerializable
15		{
16		/* -----------------------------------------------------------------
17		\| Traits
18		\| -----------------------------------------------------------------
19		*/
20
21		use CanBeJsonable;
22
23		/* -----------------------------------------------------------------
24		\| Properties
25		\| -----------------------------------------------------------------
26		*/
27
28		/**
29		* The text value.
30		*
31		* @var string
32		*/
33		protected $text;
34
35		/**
36		* The numeric value.
37		*
38		* @var int
39		*/
40		protected $value;
41
42		/* -----------------------------------------------------------------
43		\| Main Methods
44		\| -----------------------------------------------------------------
45		*/
46
47		/**
48		* AbstractMeasure constructor.
49		*
50		* @param string $text
51		* @param float\|int $value
52		*/
53	87	public function __construct($text, $value)
54		{
55	87	$this->text = $text;
56	87	$this->value = $value;
		0 ignored issues – show Documentation Bug introduced 2017-05-25 17:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$value` can also be of type `double`. However, the property `$value` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
57	87	}
58
59		/* -----------------------------------------------------------------
60		\| Getters & Setters
61		\| -----------------------------------------------------------------
62		*/
63
64		/**
65		* Get the text (alias).
66		*
67		* @see getText
68		*
69		* @return string
70		*/
71	45	public function text()
72		{
73	45	return $this->getText();
74		}
75
76		/**
77		* Get the text.
78		*
79		* @return string
80		*/
81	45	public function getText()
82		{
83	45	return $this->text;
84		}
85
86		/**
87		* Get the value (alias).
88		*
89		* @see getValue
90		*
91		* @return float\|int
92		*/
93	48	public function value()
94		{
95	48	return $this->getValue();
96		}
97
98		/**
99		* Get the value.
100		*
101		* @return float\|int
102		*/
103	48	public function getValue()
104		{
105	48	return $this->value;
106		}
107
108		/* -----------------------------------------------------------------
109		\| Main Methods
110		\| -----------------------------------------------------------------
111		*/
112
113		/**
114		* Make a distance instance.
115		*
116		* @param string $text
117		* @param int $value
118		*
119		* @return static
120		*/
121	75	public static function make($text, $value)
122		{
123	75	return new static($text, $value);
124		}
125
126		/**
127		* Make a distance instance from array.
128		*
129		* @param array $data
130		*
131		* @return static
132		*/
133	57	public static function makeFromArray(array $data)
134		{
135	57	return static::make($data['text'], $data['value']);
136		}
137
138		/**
139		* Get the instance as an array.
140		*
141		* @return array
142		*/
143	24	public function toArray()
144		{
145		return [
146	24	'text' => $this->text(),
147	24	'value' => $this->value(),
148		];
149		}
150		}
151

ARCANEDEV / GeoLocation

Issues (4)

Security Analysis no request data

src/Entities/Measures/AbstractMeasure.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like