CurrencyCollection::load() - Code Metrics - ARCANEDEV/Currencies - Measure and Improve Code Quality continuously with Scrutinizer

CurrencyCollection::load() A
last analyzed 2016-09-03 18:55 UTC

↳ Parent: CurrencyCollection

Complexity

Conditions	4
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	12
cc	4
eloc	6
nc	3
nop	2
ccs	7
cts	7
cp	1
crap	4
rs	9.2

<?php namespace Arcanedev\Currencies\Entities;

use Arcanedev\Currencies\Contracts\Entities\Currency as CurrencyContract;
use Arcanedev\Currencies\Exceptions\CurrencyNotFoundException;
use Arcanedev\Support\Collection;

/**
 * Class     CurrencyCollection
 *
 * @package  Arcanedev\Currencies\Entities
 * @author   ARCANEDEV <[email protected]>
 */
class CurrencyCollection extends Collection
{
    /* ------------------------------------------------------------------------------------------------
     |  Main Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Get a currency from the collection by iso code.
     *
     * @param  string      $iso
     * @param  mixed|null  $default
     *
     * @return \Arcanedev\Currencies\Contracts\Entities\Currency
     */
    public function get($iso, $default = null)
    {
        return parent::get($iso, $default);
    }

    /**
     * Load the currencies.
     *
     * @param  array  $currencies
     * @param  bool   $includeNonIso
     *
     * @return self
     */
    public function load(array $currencies, $includeNonIso = false)
    {
        $this->reset();

        foreach ($currencies as $group => $items) {
            if ($group !== 'iso' && ! $includeNonIso) continue;

            $this->loadMany($items, ($group === 'iso'));
        }

        return $this;
    }

    /**
     * Add a currency to the collection.
     *
     * @param  string  $key
     * @param  array   $attributes
     *
     * @return self
     */
    public function add($key, array $attributes)
    {
        $key        = strtoupper($key);
        $attributes = compact('key') + $attributes;

        return $this->addOne(Currency::make($key, $attributes));
    }

    /**
     * Add a Currency object to the collection.
     *
     * @param  \Arcanedev\Currencies\Contracts\Entities\Currency  $currency
     *
     * @return self
     */
    public function addOne(CurrencyContract $currency)
    {
        $this->put($currency->key, $currency);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        return $this;
    }

    /**
     * Check if the currency exists.
     *
     * @param  string  $iso
     *
     * @return \Arcanedev\Currencies\Contracts\Entities\Currency
     *
     * @throws \Arcanedev\Currencies\Exceptions\CurrencyNotFoundException
     */
    public function findOrFails($iso)
    {
        $iso = strtoupper($iso);

        if ( ! $this->has($iso)) {
            throw new CurrencyNotFoundException("The Currency with the ISO code [$iso] not found");
        }

        return $this->get($iso);
    }

    /* ------------------------------------------------------------------------------------------------
     |  Other Functions
     | ------------------------------------------------------------------------------------------------
     */
    /**
     * Add many currencies.
     *
     * @param  array  $items
     * @param  bool   $isIso
     */
    protected function loadMany($items, $isIso = false)
    {
        foreach ($items as $key => $attributes) {
            $attributes = ['is_iso' => $isIso] + $attributes;

            $this->add($key, $attributes);
        }
    }
}


1		<?php namespace Arcanedev\Currencies\Entities;
2
3		use Arcanedev\Currencies\Contracts\Entities\Currency as CurrencyContract;
4		use Arcanedev\Currencies\Exceptions\CurrencyNotFoundException;
5		use Arcanedev\Support\Collection;
6
7		/**
8		* Class CurrencyCollection
9		*
10		* @package Arcanedev\Currencies\Entities
11		* @author ARCANEDEV <[email protected]>
12		*/
13		class CurrencyCollection extends Collection
14		{
15		/* ------------------------------------------------------------------------------------------------
16		\| Main Functions
17		\| ------------------------------------------------------------------------------------------------
18		*/
19		/**
20		* Get a currency from the collection by iso code.
21		*
22		* @param string $iso
23		* @param mixed\|null $default
24		*
25		* @return \Arcanedev\Currencies\Contracts\Entities\Currency
26		*/
27	108	public function get($iso, $default = null)
28		{
29	108	return parent::get($iso, $default);
30		}
31
32		/**
33		* Load the currencies.
34		*
35		* @param array $currencies
36		* @param bool $includeNonIso
37		*
38		* @return self
39		*/
40	612	public function load(array $currencies, $includeNonIso = false)
41		{
42	612	$this->reset();
43
44	612	foreach ($currencies as $group => $items) {
45	612	if ($group !== 'iso' && ! $includeNonIso) continue;
46
47	612	$this->loadMany($items, ($group === 'iso'));
48	459	}
49
50	612	return $this;
51		}
52
53		/**
54		* Add a currency to the collection.
55		*
56		* @param string $key
57		* @param array $attributes
58		*
59		* @return self
60		*/
61	612	public function add($key, array $attributes)
62		{
63	612	$key = strtoupper($key);
64	612	$attributes = compact('key') + $attributes;
65
66	612	return $this->addOne(Currency::make($key, $attributes));
67		}
68
69		/**
70		* Add a Currency object to the collection.
71		*
72		* @param \Arcanedev\Currencies\Contracts\Entities\Currency $currency
73		*
74		* @return self
75		*/
76	612	public function addOne(CurrencyContract $currency)
77		{
78	612	$this->put($currency->key, $currency);
		0 ignored issues – show Bug introduced 2016-06-23 23:15 UTC by Report Bug Copy Issue Report Accessing `key` on the interface `Arcanedev\Currencies\Contracts\Entities\Currency` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
79
80	612	return $this;
81		}
82
83		/**
84		* Check if the currency exists.
85		*
86		* @param string $iso
87		*
88		* @return \Arcanedev\Currencies\Contracts\Entities\Currency
89		*
90		* @throws \Arcanedev\Currencies\Exceptions\CurrencyNotFoundException
91		*/
92	96	public function findOrFails($iso)
93		{
94	96	$iso = strtoupper($iso);
95
96	96	if ( ! $this->has($iso)) {
97	24	throw new CurrencyNotFoundException("The Currency with the ISO code [$iso] not found");
98		}
99
100	72	return $this->get($iso);
101		}
102
103		/* ------------------------------------------------------------------------------------------------
104		\| Other Functions
105		\| ------------------------------------------------------------------------------------------------
106		*/
107		/**
108		* Add many currencies.
109		*
110		* @param array $items
111		* @param bool $isIso
112		*/
113	612	protected function loadMany($items, $isIso = false)
114		{
115	612	foreach ($items as $key => $attributes) {
116	612	$attributes = ['is_iso' => $isIso] + $attributes;
117
118	612	$this->add($key, $attributes);
119	459	}
120	612	}
121		}
122

ARCANEDEV / Currencies

CurrencyCollection::load() A last analyzed 2016-09-03 18:55 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

CurrencyCollection::load() A
last analyzed 2016-09-03 18:55 UTC