DevTrait - Code Metrics - Inspection of "Refactoring the Package Entity into mutliple Trait..." - ARCANEDEV/Composer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8)

by ARCANEDEV

created 2016-09-09 23:28 UTC

DevTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	3
c	1
b	0
f	0
lcom	1
cbo	2
dl	0
loc	30
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	mergeDevInto()	0	6	1
A	mergeDevAutoload()	0	9	2

<?php namespace Arcanedev\Composer\Entities\PackageTraits;

use Arcanedev\Composer\Entities\PluginState;
use Arcanedev\Composer\Utilities\Util;
use Composer\Package\RootPackageInterface;

/**
 * Trait     DevTrait
 *
 * @package  Arcanedev\Composer\Entities\PackageTraits
 * @author   ARCANEDEV <[email protected]>
 */
trait DevTrait
{
    /**
     * Merge just the dev portion into a RootPackageInterface.
     *
     * @param  \Composer\Package\RootPackageInterface    $root
     * @param  \Arcanedev\Composer\Entities\PluginState  $state
     */
    public function mergeDevInto(RootPackageInterface $root, PluginState $state)
    {
        $this->mergeDevRequires($root, $state);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->mergeDevAutoload($root);
        $this->mergeReferences($root);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Merge autoload-dev into a RootPackage.
     *
     * @param  \Composer\Package\RootPackageInterface  $root
     */
    private function mergeDevAutoload(RootPackageInterface $root)
    {
        if ( ! empty($autoload = $this->package->getDevAutoload())) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            self::unwrapIfNeeded($root, 'setDevAutoload')
                ->setDevAutoload(array_merge_recursive(
                    $root->getDevAutoload(), Util::fixRelativePaths($this->path, $autoload)
class MyClass { }

$x = new MyClass();
$x->foo = true;
                ));
        }
    }
}


1			<?php namespace Arcanedev\Composer\Entities\PackageTraits;
2
3			use Arcanedev\Composer\Entities\PluginState;
4			use Arcanedev\Composer\Utilities\Util;
5			use Composer\Package\RootPackageInterface;
6
7			/**
8			* Trait DevTrait
9			*
10			* @package Arcanedev\Composer\Entities\PackageTraits
11			* @author ARCANEDEV <[email protected]>
12			*/
13			trait DevTrait
14			{
15			/**
16			* Merge just the dev portion into a RootPackageInterface.
17			*
18			* @param \Composer\Package\RootPackageInterface $root
19			* @param \Arcanedev\Composer\Entities\PluginState $state
20			*/
21			public function mergeDevInto(RootPackageInterface $root, PluginState $state)
22			{
23			$this->mergeDevRequires($root, $state);
			0 ignored issues – show Bug introduced 2016-09-09 23:34 UTC by Report Bug Copy Issue Report It seems like `mergeDevRequires()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			$this->mergeDevAutoload($root);
25			$this->mergeReferences($root);
			0 ignored issues – show Bug introduced 2016-09-09 23:34 UTC by Report Bug Copy Issue Report It seems like `mergeReferences()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26			}
27
28			/**
29			* Merge autoload-dev into a RootPackage.
30			*
31			* @param \Composer\Package\RootPackageInterface $root
32			*/
33			private function mergeDevAutoload(RootPackageInterface $root)
34			{
35			if ( ! empty($autoload = $this->package->getDevAutoload())) {
			0 ignored issues – show Bug introduced 2016-09-09 23:34 UTC by Report Bug Copy Issue Report The property `package` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36			self::unwrapIfNeeded($root, 'setDevAutoload')
37			->setDevAutoload(array_merge_recursive(
38			$root->getDevAutoload(), Util::fixRelativePaths($this->path, $autoload)
			0 ignored issues – show Bug introduced 2016-09-09 23:34 UTC by Report Bug Copy Issue Report The property `path` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
39			));
40			}
41			}
42			}
43

ARCANEDEV / Composer

Pull Request — master (#8)

DevTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like