AramisAuto\EmailController\PayloadDecoder\MandrillPayloadDecoder

Complexity

Total Complexity

9

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	1
Bugs	1	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
C	decode()	0	85	9

<?php

namespace AramisAuto\EmailController\PayloadDecoder;

use AramisAuto\EmailController\Exception\InvalidPayloadException;
use AramisAuto\EmailController\Exception\MandrillWebhookTestException;
use AramisAuto\EmailController\Message;

class MandrillPayloadDecoder implements PayloadDecoderInterface
{
    public function decode($payload)
    {
        // Parse request raw body
        $vars = array();
        parse_str($payload, $vars);

        if (!isset($vars['mandrill_events'])) {
            throw new InvalidPayloadException(
                sprintf(
                    'Missing "mandrill_events" body parameter - %s',
                    json_encode(array('payload' => $payload), JSON_UNESCAPED_SLASHES)
                )
            );
        }

        // Decode JSON
        $messagesMandrill = json_decode($vars['mandrill_events'], true);

        if (is_array($messagesMandrill) && count($messagesMandrill) === 0) {
            throw new MandrillWebhookTestException(
                sprintf(
                    'Received Mandrill test payload - %s',
                    json_encode(array('payload' => $payload), JSON_UNESCAPED_SLASHES)
                )
            );
        }

        if (!$messagesMandrill) {
            throw new InvalidPayloadException(
                sprintf(
                    'Could not decode payload JSON - %s',
                    json_encode($vars['mandrill_events'], JSON_UNESCAPED_SLASHES)
                )
            );
        }

        $messages = array();
        foreach ($messagesMandrill as $messageMandrill) {

The expression $messagesMandrill of type object|integer|double|string|boolean|array is not guaranteed to be traversable. How about adding an additional type check?

            // Defaults
            $messageDefaults = array(
                'cc' => array(),
                'from_email' => null,
                'from_name' => null,
                'headers' => array(),
                'html' => null,
                'id' => null,
                'metadata' => array(),
                'raw_msg' => null,
                'subject' => null,
                'text' => null,
                'email' => array(),
            );
            $messageFields = array_merge($messageDefaults, $messageMandrill);

            // Create EmailController message
            $message = new Message();
            $message->setRaw($messageFields['raw_msg']);
            $message->setHeaders($messageFields['headers']);

It seems like $messageFields['headers'] can also be of type null; however, AramisAuto\EmailController\Message::setHeaders() does only seem to accept array, maybe add an additional type check?

            $message->setText($messageFields['text']);
            $message->setHtml($messageFields['html']);
            $message->setSubject($messageFields['subject']);
            $message->setFrom($messageFields['msg']['sender']);
            $message->setTo(array(array($messageMandrill['msg']['email'], null)));

            // Message unique identifier
            $message->setId($messageFields['_id']);

            // Message metadata
            $message->metadata = array();
            if (isset($messageFields['msg'])) {
                $message->metadata = array_merge($message->metadata, $messageFields['msg']);
            }
            if (isset($messageFields['msg']) && isset($messageFields['msg']['metadata'])) {
                $message->metadata = array_merge($message->metadata, $messageFields['msg']['metadata']);
            }

            // Keep original message
            $message->source = $messageMandrill;

            $messages[] = $message;
            unset($messageFields);
        }

        return $messages;
    }
}