Criteria::getCollection() - Code Metrics - Inspection of "Added abilitiy to filter collections then re-set t..." - API-Skeletons/doctrine-orm-graphql - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 12.3.x (#158)

by Tom

created 2024-12-21 19:24 UTC

Criteria::getCollection() A

↳ Parent: Criteria

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace ApiSkeletons\Doctrine\ORM\GraphQL\Event;

use Doctrine\Common\Collections\Collection;
use Doctrine\Common\Collections\Criteria as DoctrineCriteria;
use Doctrine\ORM\PersistentCollection;
use GraphQL\Type\Definition\ResolveInfo;
use League\Event\HasEventName;

/**
 * This event is dispatched when a Doctrine Criteria is created.
 * Define an event using the Association::$criteriaEventName
 */
class Criteria implements
    HasEventName
{
    /**
     * @param PersistentCollection<array-key, mixed> $collection
     * @param mixed[]                                $args
     */
    public function __construct(
        protected readonly string $eventName,
        protected readonly DoctrineCriteria $criteria,
        protected Collection $collection,
        protected readonly mixed $objectValue,
        protected readonly array $args,
        protected readonly mixed $context,
        protected readonly ResolveInfo $info,
    ) {
    }

    public function eventName(): string
    {
        return $this->eventName;
    }

    public function getCriteria(): DoctrineCriteria
    {
        return $this->criteria;
    }

    /** @return PersistentCollection<array-key, mixed> */
    public function getCollection(): Collection
    {
        return $this->collection;
    }

    /** @param Collection<array-key, mixed> $collection */
    public function setCollection(Collection $collection): void
    {
        $this->collection = $collection;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }

    public function getObjectValue(): mixed
    {
        return $this->objectValue;
    }

    /** @return mixed[] */
    public function getArgs(): array
    {
        return $this->args;
    }

    public function getContext(): mixed
    {
        return $this->context;
    }

    public function getInfo(): ResolveInfo
    {
        return $this->info;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace ApiSkeletons\Doctrine\ORM\GraphQL\Event;
6
7			use Doctrine\Common\Collections\Collection;
8			use Doctrine\Common\Collections\Criteria as DoctrineCriteria;
9			use Doctrine\ORM\PersistentCollection;
10			use GraphQL\Type\Definition\ResolveInfo;
11			use League\Event\HasEventName;
12
13			/**
14			* This event is dispatched when a Doctrine Criteria is created.
15			* Define an event using the Association::$criteriaEventName
16			*/
17			class Criteria implements
18			HasEventName
19			{
20			/**
21			* @param PersistentCollection<array-key, mixed> $collection
22			* @param mixed[] $args
23			*/
24			public function __construct(
25			protected readonly string $eventName,
26			protected readonly DoctrineCriteria $criteria,
27			protected Collection $collection,
28			protected readonly mixed $objectValue,
29			protected readonly array $args,
30			protected readonly mixed $context,
31			protected readonly ResolveInfo $info,
32			) {
33			}
34
35			public function eventName(): string
36			{
37			return $this->eventName;
38			}
39
40			public function getCriteria(): DoctrineCriteria
41			{
42			return $this->criteria;
43			}
44
45			/** @return PersistentCollection<array-key, mixed> */
46			public function getCollection(): Collection
47			{
48			return $this->collection;
49			}
50
51			/** @param Collection<array-key, mixed> $collection */
52			public function setCollection(Collection $collection): void
53			{
54			$this->collection = $collection;
			0 ignored issues – show Documentation Bug introduced 2024-12-21 19:27 UTC by Report Bug Copy Issue Report `$collection` is of type `Doctrine\Common\Collections\Collection`, but the property `$collection` was declared to be of type `Doctrine\ORM\PersistentCollection`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
55			}
56
57			public function getObjectValue(): mixed
58			{
59			return $this->objectValue;
60			}
61
62			/** @return mixed[] */
63			public function getArgs(): array
64			{
65			return $this->args;
66			}
67
68			public function getContext(): mixed
69			{
70			return $this->context;
71			}
72
73			public function getInfo(): ResolveInfo
74			{
75			return $this->info;
76			}
77			}
78

API-Skeletons / doctrine-orm-graphql

Pull Request — 12.3.x (#158)

Criteria::getCollection() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like