API-Skeletons / doctrine-graphql

src/Attribute/ExcludeCriteria.php

<?php

declare(strict_types=1);

namespace ApiSkeletons\Doctrine\GraphQL\Attribute;

use ApiSkeletons\Doctrine\GraphQL\Criteria\Filters;
use Exception;

use function array_diff;
use function array_intersect;

trait ExcludeCriteria
{
    /** @return string[] */
    public function getExcludeCriteria(): array
    {
        if ($this->includeCriteria && $this->excludeCriteria) {
            throw new Exception('includeCriteria and excludeCriteria are mutually exclusive.');
        }

        if ($this->includeCriteria) {
            $this->excludeCriteria = array_diff(Filters::toArray(), $this->includeCriteria);

The property excludeCriteria does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        } elseif ($this->excludeCriteria) {
            $this->excludeCriteria = array_intersect(Filters::toArray(), $this->excludeCriteria);
        }

        return $this->excludeCriteria;
    }
}