ApiSkeletons\Doctrine\GraphQL\Attribute\ExcludeCriteria

Complexity

Total Complexity

5

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	getExcludeCriteria()	0	13	5

<?php

Missing declare(strict_types=1).

namespace ApiSkeletons\Doctrine\GraphQL\Attribute;

use ApiSkeletons\Doctrine\GraphQL\Criteria\Filters;

trait ExcludeCriteria
{
    /** @return string[] */
    public function getExcludeCriteria(): array
    {
        if ($this->includeCriteria && $this->exccludeCriteria) {

The property exccludeCriteria does not exist on ApiSkeletons\Doctrine\GraphQL\Attribute\ExcludeCriteria. Did you mean excludeCriteria?

            throw new \Exception('includeCriteria and excludeCriteria are mutually exclusive.');

Class \Exception should not be referenced via a fully qualified name, but via a use statement.

        }

        if ($this->includeCriteria) {
            $this->excludeCriteria = array_diff(Filters::toArray(), $this->includeCriteria);

The property excludeCriteria does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

Function array_diff() should not be referenced via a fallback global name, but via a use statement.

        } else if ($this->excludeCriteria) {
            $this->excludeCriteria = array_intersect(Filters::toArray(), $this->excludeCriteria);

Function array_intersect() should not be referenced via a fallback global name, but via a use statement.

        }

        return $this->excludeCriteria;
    }
}