ResolveCollectionFactory::buildCriteria() - Code Metrics - Inspection of "Refactored ResolveCollectionFactory" - API-Skeletons/doctrine-graphql - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — main (#88)

by Tom
created 2023-01-22 03:37 UTC
ResolveCollectionFactory::buildCriteria() D

↳ Parent: ResolveCollectionFactory
Complexity

Conditions	22
Paths	42
Size

Total Lines	67
Code Lines	47
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	22
eloc	47
c	1
b	0
f	0
nc	42
nop	2
dl	0
loc	67
rs	4.1666
How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace ApiSkeletons\Doctrine\GraphQL\Resolve;

use ApiSkeletons\Doctrine\GraphQL\Config;
use ApiSkeletons\Doctrine\GraphQL\Type\Entity;
use ApiSkeletons\Doctrine\GraphQL\Type\TypeManager;
use Closure;
use Doctrine\Common\Collections\Criteria;
use Doctrine\Common\Util\ClassUtils;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\Mapping\ClassMetadata;
use Doctrine\ORM\PersistentCollection;
use GraphQL\Type\Definition\ResolveInfo;

use function base64_decode;
use function base64_encode;
use function count;
use function strrpos;
use function substr;

class ResolveCollectionFactory
{
    public function __construct(
        protected EntityManager $entityManager,
        protected Config $config,
        protected FieldResolver $fieldResolver,
        protected TypeManager $typeManager,
    ) {
    }

    public function parseValue(ClassMetadata $metadata, string $field, mixed $value): mixed
    {
        /** @psalm-suppress UndefinedDocblockClass */
        $fieldMapping = $metadata->getFieldMapping($field);
        $graphQLType  = $this->typeManager->get($fieldMapping['type']);

        return $graphQLType->parseValue($graphQLType->serialize($value));
    }

    /** @param mixed[] $value */
    public function parseArrayValue(ClassMetadata $metadata, string $field, array $value): mixed
    {
        foreach ($value as $key => $val) {
            $value[$key] = $this->parseValue($metadata, $field, $val);
        }

        return $value;
    }

    public function get(Entity $entity): Closure
    {
        return function ($source, $args, $context, ResolveInfo $resolveInfo) {
            $filter = $args['filter'] ?? [];

            $fieldResolver = $this->fieldResolver;
            $collection    = $fieldResolver($source, $args, $context, $resolveInfo);

            $collectionMetadata = $this->entityManager->getMetadataFactory()
                ->getMetadataFor(
                    $this->entityManager->getMetadataFactory()
                    /** @scrutinizer ignore-type */ $this->entityManager->getMetadataFactory()
                        ->getMetadataFor(ClassUtils::getRealClass($source::class))
                        ->getAssociationTargetClass($resolveInfo->fieldName),
                );

            return $this->buildPagination(
                $filter,
                $collection,
                $this->buildCriteria($filter, $collectionMetadata),
            );
        };
    }

    /** @param mixed[] $filter */
    private function buildCriteria(array $filter, ClassMetadata $collectionMetadata): Criteria
    {
        $orderBy  = [];
        $criteria = Criteria::create();

        foreach ($filter as $field => $value) {
            // Pagination is handled elsewhere
            switch ($field) {
                case '_first':
                case '_after':
                case '_last':
                case '_before':
                    continue 2;
            }

            // Handle other fields as $field_$type: $value
            // Get right-most _text
            $filter = substr($field, strrpos($field, '_') + 1);

            if (strrpos($field, '_') === false) {
                // Special case for eq `field: value`
                $value = $this->parseValue($collectionMetadata, $field, $value);
                $criteria->andWhere($criteria->expr()->eq($field, $value));
            } else {
                $field = substr($field, 0, strrpos($field, '_'));

                // Format value type - this seems like something which should
                // be done in GraphQL.
                switch ($filter) {
                    case 'eq':
                    case 'neq':
                    case 'lt':
                    case 'lte':
                    case 'gt':
                    case 'gte':
                    case 'contains':
                    case 'startswith':
                    case 'endswith':
                        $value = $this->parseValue($collectionMetadata, $field, $value);
                        $criteria->andWhere($criteria->expr()->$filter($field, $value));
                        break;
                    case 'in':
                    case 'notin':
                        $value = $this->parseArrayValue($collectionMetadata, $field, $value);
                        $criteria->andWhere($criteria->expr()->$filter($field, $value));
                        break;
                    case 'isnull':
                        $criteria->andWhere($criteria->expr()->$filter($field));
                        break;
                    case 'between':
                        $value = $this->parseArrayValue($collectionMetadata, $field, $value);

                        $criteria->andWhere($criteria->expr()->gte($field, $value['from']));
                        $criteria->andWhere($criteria->expr()->lte($field, $value['to']));
                        break;
                    case 'sort':
                        $orderBy[$field] = $value;
                        break;
                }
            }
        }

        if (! empty($orderBy)) {
            $criteria->orderBy($orderBy);
        }

        return $criteria;
    }

    /**
     * @param mixed[] $filter
     *
     * @return mixed[]
     */
    private function buildPagination(array $filter, PersistentCollection $collection, Criteria $criteria): array
    {
        $first  = 0;
        $after  = 0;
        $last   = 0;
        $before = 0;
        $offset = 0;

        // Pagination
        foreach ($filter as $field => $value) {
            switch ($field) {
                case '_first':
                    $first = $value;
                    break;
                case '_after':
                    $after = (int) base64_decode($value, true) + 1;
                    break;
                case '_last':
                    $last = $value;
                    break;
                case '_before':
                    $before = (int) base64_decode($value, true);
                    break;
            }
        }

        $limit         = $this->config->getLimit();
        $adjustedLimit = $first ?: $last ?: $limit;
        if ($adjustedLimit < $limit) {
            $limit = $adjustedLimit;
        }

        if ($after) {
            $offset = $after;
        } elseif ($before) {
            $offset = $before - $limit;
        }

        if ($offset < 0) {
            $limit += $offset;
            $offset = 0;
        }

        // Get total count from collection then match
        $itemCount = count($collection->matching($criteria));

        if ($last && ! $before) {
            $offset = $itemCount - $last;
        }

        if ($offset) {
            $criteria->setFirstResult($offset);
        }

        if ($limit) {
            $criteria->setMaxResults($limit);
        }

        // Fetch slice of collection
        $items = $collection->matching($criteria);

        $edges       = [];
        $index       = 0;
        $lastCursor  = base64_encode((string) 0);
        $firstCursor = null;
        foreach ($items as $result) {
            $cursor = base64_encode((string) ($index + $offset));

            $edges[] = [
                'node' => $result,
                'cursor' => $cursor,
            ];

            $lastCursor = $cursor;
            if (! $firstCursor) {
                $firstCursor = $cursor;
            }

            $index++;
        }

        $endCursor   = $itemCount ? $itemCount - 1 : 0;
        $startCursor = base64_encode((string) 0);
        $endCursor   = base64_encode((string) $endCursor);

        // Return entities
        return [
            'edges' => $edges,
            'totalCount' => $itemCount,
            'pageInfo' => [
                'endCursor' => $endCursor,
                'startCursor' => $startCursor,
                'hasNextPage' => $endCursor !== $lastCursor,
                'hasPreviousPage' => $firstCursor !== null && $startCursor !== $firstCursor,
            ],
        ];
    }
}

API-Skeletons / doctrine-graphql

Pull Request — main (#88)

ResolveCollectionFactory::buildCriteria() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
