| Conditions | 2 |
| Paths | 1 |
| Total Lines | 110 |
| Code Lines | 76 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 24 | public function __construct( |
||
| 25 | EntityManager $entityManager, |
||
| 26 | Config|null $config = null, |
||
| 27 | array $metadata = [], |
||
| 28 | ) { |
||
| 29 | $metadata = new ArrayObject($metadata); |
||
| 30 | |||
| 31 | $this |
||
| 32 | // Plain classes |
||
| 33 | ->set(EntityManager::class, $entityManager) |
||
| 34 | ->set( |
||
| 35 | Config::class, |
||
| 36 | static function () use ($config) { |
||
| 37 | if (! $config) { |
||
| 38 | $config = new Config(); |
||
| 39 | } |
||
| 40 | |||
| 41 | return $config; |
||
| 42 | }, |
||
| 43 | ) |
||
| 44 | ->set( |
||
| 45 | EventDispatcher::class, |
||
| 46 | static fn () => new EventDispatcher() |
||
| 47 | ) |
||
| 48 | ->set( |
||
| 49 | Type\TypeManager::class, |
||
| 50 | static fn (AbstractContainer $container) => new Type\TypeManager($container) |
||
| 51 | ) |
||
| 52 | ->set( |
||
| 53 | 'metadata', |
||
| 54 | static function (AbstractContainer $container) use ($metadata) { |
||
| 55 | return (new Metadata\MetadataFactory( |
||
| 56 | $metadata, |
||
| 57 | $container->get(EntityManager::class), |
||
| 58 | $container->get(Config::class), |
||
| 59 | $container->get(GlobalEnable::class), |
||
| 60 | $container->get(EventDispatcher::class), |
||
| 61 | ))(); |
||
| 62 | }, |
||
| 63 | ) |
||
| 64 | ->set( |
||
| 65 | Metadata\GlobalEnable::class, |
||
| 66 | static function (AbstractContainer $container) { |
||
| 67 | return new Metadata\GlobalEnable( |
||
| 68 | $container->get(EntityManager::class), |
||
| 69 | $container->get(Config::class), |
||
| 70 | $container->get(EventDispatcher::class), |
||
| 71 | ); |
||
| 72 | }, |
||
| 73 | ) |
||
| 74 | ->set( |
||
| 75 | Resolve\FieldResolver::class, |
||
| 76 | static function (AbstractContainer $container) { |
||
| 77 | return new Resolve\FieldResolver( |
||
| 78 | $container->get(Config::class), |
||
| 79 | $container->get(Type\TypeManager::class), |
||
| 80 | ); |
||
| 81 | }, |
||
| 82 | ) |
||
| 83 | ->set( |
||
| 84 | Resolve\ResolveCollectionFactory::class, |
||
| 85 | static function (AbstractContainer $container) { |
||
| 86 | return new Resolve\ResolveCollectionFactory( |
||
| 87 | $container->get(EntityManager::class), |
||
| 88 | $container->get(Config::class), |
||
| 89 | $container->get(Resolve\FieldResolver::class), |
||
| 90 | $container->get(Type\TypeManager::class), |
||
| 91 | $container->get(EventDispatcher::class), |
||
| 92 | $container->get('metadata'), |
||
| 93 | ); |
||
| 94 | }, |
||
| 95 | ) |
||
| 96 | ->set( |
||
| 97 | Resolve\ResolveEntityFactory::class, |
||
| 98 | static function (AbstractContainer $container) { |
||
| 99 | return new Resolve\ResolveEntityFactory( |
||
| 100 | $container->get(Config::class), |
||
| 101 | $container->get(EntityManager::class), |
||
| 102 | $container->get(EventDispatcher::class), |
||
| 103 | $container->get('metadata'), |
||
| 104 | ); |
||
| 105 | }, |
||
| 106 | ) |
||
| 107 | ->set( |
||
| 108 | Criteria\CriteriaFactory::class, |
||
| 109 | static function (AbstractContainer $container) { |
||
| 110 | return new Criteria\CriteriaFactory( |
||
| 111 | $container->get(Config::class), |
||
| 112 | $container->get(EntityManager::class), |
||
| 113 | $container->get(Type\TypeManager::class), |
||
| 114 | $container->get(EventDispatcher::class), |
||
| 115 | ); |
||
| 116 | }, |
||
| 117 | ) |
||
| 118 | ->set( |
||
| 119 | Hydrator\HydratorFactory::class, |
||
| 120 | static function (AbstractContainer $container) { |
||
| 121 | return new Hydrator\HydratorFactory( |
||
| 122 | $container->get(EntityManager::class), |
||
| 123 | $container->get(Type\TypeManager::class), |
||
| 124 | ); |
||
| 125 | }, |
||
| 126 | ) |
||
| 127 | ->set( |
||
| 128 | Input\InputFactory::class, |
||
| 129 | static function (AbstractContainer $container) { |
||
| 130 | return new Input\InputFactory( |
||
| 131 | $container->get(Config::class), |
||
| 132 | $container->get(EntityManager::class), |
||
| 133 | $container->get(Type\TypeManager::class), |
||
| 134 | ); |
||
| 141 |