Completed
Pull Request — master (#18)
by Tomas Norre
03:41
created

RestrictionIdentifierFabric   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 33
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 3

Test Coverage

Coverage 52.38%

Importance

Changes 0
Metric Value
wmc 3
lcom 0
cbo 3
dl 0
loc 33
ccs 11
cts 21
cp 0.5238
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A getRestrictionIdentifier() 0 23 3
1
<?php
2
namespace Aoe\FeloginBruteforceProtection\Domain\Service;
3
4
/***************************************************************
5
 *  Copyright notice
6
 *
7
 *  (c) 2019 AOE GmbH <[email protected]>
8
 *
9
 *  All rights reserved
10
 *
11
 *  This script is part of the TYPO3 project. The TYPO3 project is
12
 *  free software; you can redistribute it and/or modify
13
 *  it under the terms of the GNU General Public License as published by
14
 *  the Free Software Foundation; either version 3 of the License, or
15
 *  (at your option) any later version.
16
 *
17
 *  The GNU General Public License can be found at
18
 *  http://www.gnu.org/copyleft/gpl.html.
19
 *
20
 *  This script is distributed in the hope that it will be useful,
21
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
22
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
23
 *  GNU General Public License for more details.
24
 *
25
 *  This copyright notice MUST APPEAR in all copies of the script!
26
 ***************************************************************/
27
28
use TYPO3\CMS\Frontend\Authentication\FrontendUserAuthentication;
29
use Aoe\FeloginBruteforceProtection\System\Configuration;
30
31
class RestrictionIdentifierFabric
32
{
33
    /**
34
     * Restriction identifier fabric method
35
     *
36
     * @param Configuration $configuration
37
     * @param FrontendUserAuthentication $frontendUserAuthentication
38
     * @return RestrictionIdentifierInterface
39
     **/
40 33
    public function getRestrictionIdentifier(
41
        Configuration $configuration,
42
        FrontendUserAuthentication $frontendUserAuthentication = null
43
    ) {
44
45 33
        $identificationIdentifier = $configuration->getIdentificationIdentifier();
46
        switch ($identificationIdentifier) {
47 33
            case 2:
48 12
                if ($frontendUserAuthentication !== null) {
49 11
                    new RestrictionIdentifierFrontendName();
50 11
                    $restrictionIdentifier = new RestrictionIdentifierFrontendName();
51 11
                    $restrictionIdentifier->setFrontendUserAuthentication($frontendUserAuthentication);
52 11
                    return $restrictionIdentifier;
53
                    break;
0 ignored issues
show
Unused Code introduced by
break is not strictly necessary here and could be removed.

The break statement is not necessary if it is preceded for example by a return statement:

switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

If you would like to keep this construct to be consistent with other case statements, you can safely mark this issue as a false-positive.

Loading history...
54
                }
55
                // no break
56
            default:
57 22
                $restrictionIdentifier = new RestrictionIdentifierClientIp();
58 22
                $restrictionIdentifier->setConfiguration($configuration);
59 22
                return $restrictionIdentifier;
60
                break;
0 ignored issues
show
Unused Code introduced by
break is not strictly necessary here and could be removed.

The break statement is not necessary if it is preceded for example by a return statement:

switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

If you would like to keep this construct to be consistent with other case statements, you can safely mark this issue as a false-positive.

Loading history...
61
        }
62
    }
63
}
64