AOEpeople / crawler

Classes/Backend/Helper/ResultHandler.php

<?php

declare(strict_types=1);

namespace AOE\Crawler\Backend\Helper;

/*
 * (c) 2020 AOE GmbH <dev@aoe.com>
 *
 * This file is part of the TYPO3 Crawler Extension.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

use AOE\Crawler\Converter\JsonCompatibilityConverter;
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * @internal since v9.2.5
 */
class ResultHandler
{
    /**
     * Extract the log information from the current row and retrieve it as formatted string.
     *
     * @param array $resultRow
     * @return string
     */
    public static function getResultLog($resultRow)
    {
        $content = '';
        if (is_array($resultRow) && array_key_exists('result_data', $resultRow)) {
            $requestContent = self::getJsonCompatibilityConverter()->convert($resultRow['result_data']) ?: [];
            if (! array_key_exists('content', $requestContent)) {

It seems like $requestContent can also be of type true; however, parameter $array of array_key_exists() does only seem to accept ArrayObject|array, maybe add an additional type check?

                return $content;
            }
            $requestResult = self::getJsonCompatibilityConverter()->convert($requestContent['content']);

            if (is_array($requestResult) && array_key_exists('log', $requestResult)) {
                $content = implode(chr(10), $requestResult['log']);
            }
        }
        return $content;
    }

    /**
     * @param array|bool $requestContent
     */
    public static function getResStatus($requestContent): string
    {
        if (empty($requestContent)) {
            return '-';
        }
        if (! array_key_exists('content', $requestContent)) {

It seems like $requestContent can also be of type boolean; however, parameter $array of array_key_exists() does only seem to accept ArrayObject|array, maybe add an additional type check?

            return 'Content index does not exists in requestContent array';
        }

        $requestResult = self::getJsonCompatibilityConverter()->convert($requestContent['content']);
        if (is_array($requestResult)) {
            if (empty($requestResult['errorlog'])) {
                return 'OK';
            }
            return implode("\n", $requestResult['errorlog']);
        }

        if (is_bool($requestResult)) {

The condition is_bool($requestResult) is always true.

            return 'Error - no info, sorry!';
        }

        return 'Error: ' . substr(preg_replace('/\s+/', ' ', strip_tags($requestResult)), 0, 10000) . '...';
    }

    /**
     * Find Fe vars
     */
    public static function getResFeVars(array $resultData): array
    {
        if (empty($resultData)) {
            return [];
        }
        $requestResult = self::getJsonCompatibilityConverter()->convert($resultData['content']);
        return $requestResult['vars'] ?? [];
    }

    private static function getJsonCompatibilityConverter(): JsonCompatibilityConverter
    {
        return GeneralUtility::makeInstance(JsonCompatibilityConverter::class);
    }
}