AOE\Crawler\Backend\BackendModule::drawURLs()

Complexity

Conditions	13
Paths	192

Size

Total Lines	112
Code Lines	74

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function drawURLs()
    {
        global $BACK_PATH, $BE_USER;

        // Init:
        $this->duplicateTrack = [];
        $this->submitCrawlUrls = GeneralUtility::_GP('_crawl');

It seems like \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('_crawl') can also be of type array or string. However, the property $submitCrawlUrls is declared as type boolean. Maybe add an additional type check?

        $this->downloadCrawlUrls = GeneralUtility::_GP('_download');

It seems like \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('_download') can also be of type array or string. However, the property $downloadCrawlUrls is declared as type boolean. Maybe add an additional type check?

        $this->makeCrawlerProcessableChecks();

        switch ((string) GeneralUtility::_GP('tstamp')) {
            case 'midnight':
                $this->scheduledTime = mktime(0, 0, 0);
            break;
            case '04:00':
                $this->scheduledTime = mktime(0, 0, 0) + 4 * 3600;
            break;
            case 'now':
            default:
                $this->scheduledTime = time();
            break;
        }
        // $this->reqMinute = \TYPO3\CMS\Core\Utility\GeneralUtility::intInRange(\TYPO3\CMS\Core\Utility\GeneralUtility::_GP('perminute'),1,10000);
        // TODO: check relevance
        $this->reqMinute = 1000;

        $this->incomingConfigurationSelection = GeneralUtility::_GP('configurationSelection');

It seems like \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('configurationSelection') can also be of type null or string. However, the property $incomingConfigurationSelection is declared as type array. Maybe add an additional type check?

        $this->incomingConfigurationSelection = is_array($this->incomingConfigurationSelection) ? $this->incomingConfigurationSelection : [''];

        $this->crawlerObj = GeneralUtility::makeInstance(CrawlerController::class);
        $this->crawlerObj->setAccessMode('gui');
        $this->crawlerObj->setID = GeneralUtility::md5int(microtime());

        if (empty($this->incomingConfigurationSelection)
            || (count($this->incomingConfigurationSelection) == 1 && empty($this->incomingConfigurationSelection[0]))
            ) {
            $code = '
			<tr>
				<td colspan="7"><b>' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/locallang.xml:labels.noConfigSelected') . '</b></td>
			</tr>';
        } else {
            if ($this->submitCrawlUrls) {
                $reason = new Reason();
                $reason->setReason(Reason::REASON_GUI_SUBMIT);

                if ($BE_USER instanceof BackendUserAuthentication) {
                    $username = $BE_USER->user['username'];
                }
                $reason->setDetailText('The user ' . $username . ' added pages to the crawler queue manually ');

The variable $username does not seem to be defined for all execution paths leading up to this point.

                EventDispatcher::getInstance()->post(
                    'invokeQueueChange',
                    $this->findCrawler()->setID,
                    ['reason' => $reason]
                );
            }

            $code = $this->crawlerObj->getPageTreeAndUrls(
                $this->pObj->id,
                $this->pObj->MOD_SETTINGS['depth'],
                $this->scheduledTime,
                $this->reqMinute,
                $this->submitCrawlUrls,
                $this->downloadCrawlUrls,
                [], // Do not filter any processing instructions
                $this->incomingConfigurationSelection
            );
        }

        $this->downloadUrls = $this->crawlerObj->downloadUrls;
        $this->duplicateTrack = $this->crawlerObj->duplicateTrack;

        $output = '';
        if ($code) {
            $output .= '<h3>' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/locallang.xml:labels.configuration') . ':</h3>';
            $output .= '<input type="hidden" name="id" value="' . intval($this->pObj->id) . '" />';

            if (!$this->submitCrawlUrls) {
                $output .= $this->drawURLs_cfgSelectors() . '<br />';
                $output .= '<input type="submit" name="_update" value="' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/locallang.xml:labels.triggerUpdate') . '" /> ';
                $output .= '<input type="submit" name="_crawl" value="' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/locallang.xml:labels.triggerCrawl') . '" /> ';
                $output .= '<input type="submit" name="_download" value="' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/locallang.xml:labels.triggerDownload') . '" /><br /><br />';
                $output .= $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/locallang.xml:labels.count') . ': ' . count(array_keys($this->duplicateTrack)) . '<br />';
                $output .= $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/locallang.xml:labels.curtime') . ': ' . date('H:i:s', time()) . '<br />';
                $output .= '<br />
					<table class="lrPadding c-list url-table">' .
                        $this->drawURLs_printTableHeader() .
                        $code .
                    '</table>';
            } else {
                $output .= count(array_keys($this->duplicateTrack)) . ' ' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/locallang.xml:labels.submitted') . '. <br /><br />';
                $output .= '<input type="submit" name="_" value="' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/locallang.xml:labels.continue') . '" />';
                $output .= '<input type="submit" onclick="this.form.elements[\'SET[crawlaction]\'].value=\'log\';" value="' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/locallang.xml:labels.continueinlog') . '" />';
            }
        }

        // Download Urls to crawl:
        if ($this->downloadCrawlUrls) {

                // Creating output header:
            $mimeType = 'application/octet-stream';
            Header('Content-Type: ' . $mimeType);
            Header('Content-Disposition: attachment; filename=CrawlerUrls.txt');

            // Printing the content of the CSV lines:
            echo implode(chr(13) . chr(10), $this->downloadUrls);

            exit;
        }

        return 	$output;
    }