CrawlStrategyFactory::create() - Code Metrics - Inspection of "Refactor/add crawl strategy factory" - AOEpeople/crawler - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#630)

by Tomas Norre

created 2020-10-11 12:19 UTC

CrawlStrategyFactory::create() A

↳ Parent: CrawlStrategyFactory

Complexity

Conditions	3
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
c	1
b	0
f	0
nc	4
nop	0
dl	0
loc	13
ccs	7
cts	7
cp	1
crap	3
rs	10

<?php

declare(strict_types=1);

namespace AOE\Crawler\CrawlStrategy;

use AOE\Crawler\Configuration\ExtensionConfigurationProvider;
use TYPO3\CMS\Core\Utility\GeneralUtility;

final class CrawlStrategyFactory
{
    /**
     * @var ExtensionConfigurationProvider
     */
    private $configurationProvider;

    public function __construct(?ExtensionConfigurationProvider $configurationProvider = null)
    {
        $this->configurationProvider = $configurationProvider ?? GeneralUtility::makeInstance(ExtensionConfigurationProvider::class);
    }

    public function create(): CrawlStrategy
    {
        $settings = $this->configurationProvider->getExtensionConfiguration();
        $extensionSettings = is_array($settings) ? $settings : [];


        if ($extensionSettings['makeDirectRequests']) {
            /** @var CrawlStrategy $instance */
            $instance = GeneralUtility::makeInstance(SubProcessExecutionStrategy::class);
        } else {
            $instance = GeneralUtility::makeInstance(GuzzleExecutionStrategy::class);
        }

        return $instance;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace AOE\Crawler\CrawlStrategy;
6
7		use AOE\Crawler\Configuration\ExtensionConfigurationProvider;
8		use TYPO3\CMS\Core\Utility\GeneralUtility;
9
10		final class CrawlStrategyFactory
11		{
12		/**
13		* @var ExtensionConfigurationProvider
14		*/
15		private $configurationProvider;
16
17	47	public function __construct(?ExtensionConfigurationProvider $configurationProvider = null)
18		{
19	47	$this->configurationProvider = $configurationProvider ?? GeneralUtility::makeInstance(ExtensionConfigurationProvider::class);
20	47	}
21
22	47	public function create(): CrawlStrategy
23		{
24	47	$settings = $this->configurationProvider->getExtensionConfiguration();
25	47	$extensionSettings = is_array($settings) ? $settings : [];
		0 ignored issues – show introduced 2019-12-30 17:56 UTC by Report Bug Copy Issue Report The condition `is_array($settings)` is always `true`. Loading history...
26
27	47	if ($extensionSettings['makeDirectRequests']) {
28		/** @var CrawlStrategy $instance */
29	1	$instance = GeneralUtility::makeInstance(SubProcessExecutionStrategy::class);
30		} else {
31	46	$instance = GeneralUtility::makeInstance(GuzzleExecutionStrategy::class);
32		}
33
34	47	return $instance;
35		}
36		}
37

AOEpeople / crawler

Pull Request — master (#630)

CrawlStrategyFactory::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like