AOEpeople / crawler

Classes/Hooks/StaticFileCacheCreateUriHook.php

Doc Comments +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      * @param string $uri
      * @param TypoScriptFrontendController $frontend
      *
-     * @return array
+     * @return string[]
      *
      * @throws \Exception
      *

Spacing +2 added lines, -2 removed lines

@@ -67,9 +67,9 @@
             $speakingUri = $frontend->cObj->typoLink_URL(['parameter' => $matches[1], 'additionalParams' => $matches[2]]);
             $speakingUriParts = parse_url($speakingUri);
             if (false === $speakingUriParts) {
-                throw new \Exception('Could not parse URI: ' . $speakingUri, 1289915976);
+                throw new \Exception('Could not parse URI: '.$speakingUri, 1289915976);
             }
-            $speakingUrlPath = '/' . ltrim($speakingUriParts['path'], '/');
+            $speakingUrlPath = '/'.ltrim($speakingUriParts['path'], '/');
             // Don't change anything if speaking URL is part of old URI:
             // (it might be the case the using the speaking URL failed)
             if (strpos($uri, $speakingUrlPath) !== 0 || $speakingUrlPath === '/') {

Classes/Api/CrawlerApi.php

Doc Comments +1 added lines, -1 removed lines

@@ -209,7 +209,7 @@
     /**
      * Determines if a page is queued
      *
-     * @param $uid
+     * @param integer $uid
      * @param bool $unprocessed_only
      * @param bool $timed_only
      * @param bool $timestamp

Spacing +11 added lines, -11 removed lines

@@ -91,7 +91,7 @@ 
      */
     protected function findCrawler()
     {
-        if (! is_object($this->crawlerObj)) {
+        if (!is_object($this->crawlerObj)) {
             $this->crawlerObj = GeneralUtility::makeInstance('tx_crawler_lib');
             $this->crawlerObj->setID = GeneralUtility::md5int(microtime());
         }
@@ -126,7 +126,7 @@ 
         if (count($this->allowedConfigrations) > 0) {
             // 	remove configuration that does not match the current selection
             foreach ($configurations as $confKey => $confArray) {
-                if (! in_array($confKey, $this->allowedConfigrations)) {
+                if (!in_array($confKey, $this->allowedConfigrations)) {
                     unset($configurations[$confKey]);
                 }
             }
@@ -191,12 +191,12 @@ 
         //if the same page is scheduled for the same time and has not be executed?
         if ($schedule_timestamp == 0) {
             //untimed elements need an exec_time with 0 because they can occure multiple times
-            $where = 'page_id=' . $page_uid . ' AND exec_time = 0 AND scheduled=' . $schedule_timestamp;
+            $where = 'page_id='.$page_uid.' AND exec_time = 0 AND scheduled='.$schedule_timestamp;
         } else {
             //timed elementes have got a fixed schedule time, if a record with this time
             //exists it is maybe queued for the future, or is has been queue for the past and therefore
             //also been processed.
-            $where = 'page_id=' . $page_uid . ' AND scheduled=' . $schedule_timestamp;
+            $where = 'page_id='.$page_uid.' AND scheduled='.$schedule_timestamp;
         }
 
         $row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($GLOBALS['TYPO3_DB']->exec_SELECTquery(
@@ -226,7 +226,7 @@ 
 
         $isPageInQueue = false;
 
-        $whereClause = 'page_id = ' . (integer)$uid;
+        $whereClause = 'page_id = '.(integer) $uid;
 
         if (false !== $unprocessed_only) {
             $whereClause .= ' AND exec_time = 0';
@@ -237,7 +237,7 @@ 
         }
 
         if (false !== $timestamp) {
-            $whereClause .= ' AND scheduled = ' . (integer)$timestamp;
+            $whereClause .= ' AND scheduled = '.(integer) $timestamp;
         }
 
         $count = $GLOBALS['TYPO3_DB']->exec_SELECTcountRows(
@@ -266,10 +266,10 @@ 
     {
         $uid = intval($uid);
         $query = 'max(scheduled) as latest';
-        $where = ' page_id = ' . $uid;
+        $where = ' page_id = '.$uid;
 
         if ($future_crawldates_only) {
-            $where .= ' AND scheduled > ' . time();
+            $where .= ' AND scheduled > '.time();
         }
 
         if ($unprocessed_only) {
@@ -302,7 +302,7 @@ 
         $limit = $GLOBALS['TYPO3_DB']->fullQuoteStr($limit, 'tx_crawler_queue');
 
         $query = 'scheduled, exec_time, set_id';
-        $where = ' page_id = ' . $uid;
+        $where = ' page_id = '.$uid;
 
         $limit_query = ($limit) ? $limit : null;
 
@@ -379,7 +379,7 @@ 
     {
         $qid = intval($qid);
         $table = 'tx_crawler_queue';
-        $where = ' qid=' . $qid;
+        $where = ' qid='.$qid;
         $GLOBALS['TYPO3_DB']->exec_DELETEquery($table, $where);
     }
 
@@ -407,7 +407,7 @@ 
      */
     protected function getQueueRepository()
     {
-        if (! $this->queueRepository instanceof \tx_crawler_domain_queue_repository) {
+        if (!$this->queueRepository instanceof \tx_crawler_domain_queue_repository) {
             $this->queueRepository = new \tx_crawler_domain_queue_repository();
         }
 

domain/process/class.tx_crawler_domain_process_repository.php

Spacing +3 added lines, -3 removed lines

@@ -66,7 +66,7 @@ 
             $this->tableName,
             $where,
             '',
-            htmlspecialchars($orderField) . ' ' . htmlspecialchars($orderDirection),
+            htmlspecialchars($orderField).' '.htmlspecialchars($orderDirection),
             self::getLimitFromItemCountAndOffset($itemCount, $offset)
         );
 
@@ -111,7 +111,7 @@ 
      */
     public function countNotTimeouted($ttl)
     {
-        return $this->countByWhere('deleted = 0 AND ttl > ' . intval($ttl));
+        return $this->countByWhere('deleted = 0 AND ttl > '.intval($ttl));
     }
 
     /**
@@ -127,7 +127,7 @@ 
     {
         $itemCount = filter_var($itemCount, FILTER_VALIDATE_INT, ['options' => ['min_range' => 1, 'default' => 20]]);
         $offset = filter_var($offset, FILTER_VALIDATE_INT, ['options' => ['min_range' => 0, 'default' => 0]]);
-        $limit = $offset . ', ' . $itemCount;
+        $limit = $offset.', '.$itemCount;
 
         return $limit;
     }

Classes/Task/CrawlMultiProcessTask.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
     public function execute()
     {
         $processManager = new \tx_crawler_domain_process_manager();
-        $timeout = is_int($this->timeOut) ? (int)$this->timeOut : 1800;
+        $timeout = is_int($this->timeOut) ? (int) $this->timeOut : 1800;
 
         try {
             $processManager->multiProcess($timeout);

cli/crawler_multiprocess.php

Spacing +1 added lines, -1 removed lines

@@ -9,5 +9,5 @@
 try {
     $processManager->multiProcess($timeout);
 } catch (Exception $e) {
-    echo PHP_EOL . $e->getMessage();
+    echo PHP_EOL.$e->getMessage();
 }

domain/events/class.tx_crawler_domain_events_dispatcher.php

Spacing +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
     {
         if (is_array($this->observers[$event])) {
             foreach ($this->observers[$event] as $eventObserver) {
-                call_user_func([$eventObserver['object'],$eventObserver['method']], $event, $group, $attachedData);
+                call_user_func([$eventObserver['object'], $eventObserver['method']], $event, $group, $attachedData);
             }
         }
     }

Classes/Utility/HookUtility.php

Spacing +5 added lines, -5 removed lines

@@ -45,17 +45,17 @@
     public static function registerHooks($extKey)
     {
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['connectToDB']['tx_crawler'] =
-            TsfeHook::class . '->fe_init';
+            TsfeHook::class.'->fe_init';
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['initFEuser']['tx_crawler'] =
-            TsfeHook::class . '->fe_feuserInit';
+            TsfeHook::class.'->fe_feuserInit';
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['isOutputting']['tx_crawler'] =
-            TsfeHook::class . '->fe_isOutputting';
+            TsfeHook::class.'->fe_isOutputting';
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['hook_eofe']['tx_crawler'] =
-            TsfeHook::class . '->fe_eofe';
+            TsfeHook::class.'->fe_eofe';
 
         // Activating NC Static File Cache hook
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['nc_staticfilecache/class.tx_ncstaticfilecache.php']['createFile_initializeVariables']['tx_crawler'] =
-            StaticFileCacheCreateUriHook::class . '->initialize';
+            StaticFileCacheCreateUriHook::class.'->initialize';
 
         // Activating Crawler cli_hooks
         $GLOBALS['TYPO3_CONF_VARS']['EXTCONF'][$extKey]['cli_hooks'][] =

Classes/Hooks/ProcessCleanUpHook.php

Spacing +10 added lines, -10 removed lines

@@ -70,14 +70,14 @@ 
         $results = $this->getDatabaseConnection()->exec_SELECTgetRows(
             'process_id, system_process_id',
             'tx_crawler_process',
-            'ttl <= ' . intval(time() - $this->extensionSettings['processMaxRunTime'] - 3600) . ' AND active = 1'
+            'ttl <= '.intval(time() - $this->extensionSettings['processMaxRunTime'] - 3600).' AND active = 1'
         );
 
         if (!is_array($results)) {
             return;
         }
         foreach ($results as $result) {
-            $systemProcessId = (int)$result['system_process_id'];
+            $systemProcessId = (int) $result['system_process_id'];
             $processId = $result['process_id'];
             if ($systemProcessId > 1) {
                 if ($this->doProcessStillExists($systemProcessId)) {
@@ -98,7 +98,7 @@ 
         $results = $this->getDatabaseConnection()->exec_SELECTgetRows(
             'process_id, system_process_id',
             'tx_crawler_process',
-            'ttl <= ' . intval(time() - $this->extensionSettings['processMaxRunTime']) . ' AND active = 1'
+            'ttl <= '.intval(time() - $this->extensionSettings['processMaxRunTime']).' AND active = 1'
         );
 
         if (!is_array($results)) {
@@ -106,7 +106,7 @@ 
         }
         foreach ($results as $result) {
             $processExists = false;
-            $systemProcessId = (int)$result['system_process_id'];
+            $systemProcessId = (int) $result['system_process_id'];
             $processId = $result['process_id'];
             if ($systemProcessId > 1) {
                 $dispatcherProcesses = $this->findDispatcherProcesses();
@@ -116,7 +116,7 @@ 
                 }
                 foreach ($dispatcherProcesses as $process) {
                     $responseArray = $this->createResponseArray($process);
-                    if ($systemProcessId === (int)$responseArray[1]) {
+                    if ($systemProcessId === (int) $responseArray[1]) {
                         $processExists = true;
                     };
                 }
@@ -138,12 +138,12 @@ 
     {
         $this->getDatabaseConnection()->exec_DELETEquery(
             'tx_crawler_process',
-            'process_id = ' . $this->getDatabaseConnection()->fullQuoteStr($processId, 'tx_crawler_process')
+            'process_id = '.$this->getDatabaseConnection()->fullQuoteStr($processId, 'tx_crawler_process')
         );
 
         $this->getDatabaseConnection()->exec_UPDATEquery(
             'tx_crawler_queue',
-            'process_id = ' . $this->getDatabaseConnection()->fullQuoteStr($processId, 'tx_crawler_queue'),
+            'process_id = '.$this->getDatabaseConnection()->fullQuoteStr($processId, 'tx_crawler_queue'),
             ['process_id' => '']
         );
     }
@@ -177,12 +177,12 @@ 
         $doProcessStillExists = false;
         if (!$this->isOsWindows()) {
             // Not windows
-            if (file_exists('/proc/' . $pid)) {
+            if (file_exists('/proc/'.$pid)) {
                 $doProcessStillExists = true;
             }
         } else {
             // Windows
-            exec('tasklist | find "' . $pid . '"', $returnArray, $returnValue);
+            exec('tasklist | find "'.$pid.'"', $returnArray, $returnValue);
             if (count($returnArray) > 0 && preg_match('/php/i', $returnValue[0])) {
                 $doProcessStillExists = true;
             }
@@ -204,7 +204,7 @@ 
             posix_kill($pid, 9);
         } else {
             // Windows
-            exec('taskkill /PID ' . $pid);
+            exec('taskkill /PID '.$pid);
         }
     }
 

Classes/Task/FlushQueueTaskAdditionalFieldProvider.php

Spacing +4 added lines, -4 removed lines

@@ -59,10 +59,10 @@
         }
 
         $fieldId = 'mode';
-        $fieldCode = '<select name="tx_scheduler[mode]" id="' . $fieldId . '" value="' . htmlentities($taskInfo['mode']) . '" class="form-control">'
-            . '<option value="all"' . ($taskInfo['mode'] == 'all' ? ' selected="selected"' : '') . '>' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/Backend.xlf:crawler_flush.modeAll') . '</option>'
-            . '<option value="finished"' . ($taskInfo['mode'] == 'finished' ? ' selected="selected"' : '') . '>' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/Backend.xlf:crawler_flush.modeFinished') . '</option>'
-            . '<option value="pending"' . ($taskInfo['mode'] == 'pending' ? ' selected="selected"' : '') . '>' . $GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/Backend.xlf:crawler_flush.modePending') . '</option>'
+        $fieldCode = '<select name="tx_scheduler[mode]" id="'.$fieldId.'" value="'.htmlentities($taskInfo['mode']).'" class="form-control">'
+            . '<option value="all"'.($taskInfo['mode'] == 'all' ? ' selected="selected"' : '').'>'.$GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/Backend.xlf:crawler_flush.modeAll').'</option>'
+            . '<option value="finished"'.($taskInfo['mode'] == 'finished' ? ' selected="selected"' : '').'>'.$GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/Backend.xlf:crawler_flush.modeFinished').'</option>'
+            . '<option value="pending"'.($taskInfo['mode'] == 'pending' ? ' selected="selected"' : '').'>'.$GLOBALS['LANG']->sL('LLL:EXT:crawler/Resources/Private/Language/Backend.xlf:crawler_flush.modePending').'</option>'
             . '</select>';
 
         $additionalFields[$fieldId] = [