PhpBinaryUtility::getPhpBinary() - Code Metrics - Inspection of "[TASK] Improves getPhpBinary and adds tests" - AOEpeople/crawler - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — issues/544 ( 1e0b91 )

by Tomas Norre

created 2020-04-16 20:38 UTC

PhpBinaryUtility::getPhpBinary() A

↳ Parent: PhpBinaryUtility

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	4.5923

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	10
c	1
b	0
f	0
nc	4
nop	0
dl	0
loc	18
ccs	10
cts	15
cp	0.6667
crap	4.5923
rs	9.9332

<?php

declare(strict_types=1);

namespace AOE\Crawler\Utility;

/*
 * (c) 2020 AOE GmbH <[email protected]>
 *
 * This file is part of the TYPO3 Crawler Extension.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

use AOE\Crawler\Configuration\ExtensionConfigurationProvider;
use TYPO3\CMS\Core\Utility\CommandUtility;
use TYPO3\CMS\Core\Utility\GeneralUtility;

class PhpBinaryUtility
{
    /**
     * @return string
     */
    public static function getPhpBinary(): string
    {
        $extensionSettings = GeneralUtility::makeInstance(ExtensionConfigurationProvider::class)->getExtensionConfiguration();

        if (empty($extensionSettings)) {
            throw new \Exception('ExtensionSettings are empty', 1587066853);
        }

        if (empty($extensionSettings['phpPath'])) {
            $phpPath = CommandUtility::getCommand($extensionSettings['phpBinary']);
            if (false === $phpPath) {
                throw new \Exception('The phpBinary: "' . $extensionSettings['phpBinary'] . '" could not be found!', 1587068215);
            }
        } else {
            $phpPath = $extensionSettings['phpPath'];
        }

        return $phpPath;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace AOE\Crawler\Utility;
6
7		/*
8		* (c) 2020 AOE GmbH <[email protected]>
9		*
10		* This file is part of the TYPO3 Crawler Extension.
11		*
12		* It is free software; you can redistribute it and/or modify it under
13		* the terms of the GNU General Public License, either version 2
14		* of the License, or any later version.
15		*
16		* For the full copyright and license information, please read the
17		* LICENSE.txt file that was distributed with this source code.
18		*
19		* The TYPO3 project - inspiring people to share!
20		*/
21
22		use AOE\Crawler\Configuration\ExtensionConfigurationProvider;
23		use TYPO3\CMS\Core\Utility\CommandUtility;
24		use TYPO3\CMS\Core\Utility\GeneralUtility;
25
26		class PhpBinaryUtility
27		{
28		/**
29		* @return string
30		*/
31	6	public static function getPhpBinary(): string
32		{
33	6	$extensionSettings = GeneralUtility::makeInstance(ExtensionConfigurationProvider::class)->getExtensionConfiguration();
34
35	5	if (empty($extensionSettings)) {
36	1	throw new \Exception('ExtensionSettings are empty', 1587066853);
37		}
38
39	4	if (empty($extensionSettings['phpPath'])) {
40	3	$phpPath = CommandUtility::getCommand($extensionSettings['phpBinary']);
41	3	if (false === $phpPath) {
42	3	throw new \Exception('The phpBinary: "' . $extensionSettings['phpBinary'] . '" could not be found!', 1587068215);
43		}
44		} else {
45	2	$phpPath = $extensionSettings['phpPath'];
46		}
47
48	3	return $phpPath;
49		}
50		}
51

AOEpeople / crawler

Push — issues/544 ( 1e0b91 )

PhpBinaryUtility::getPhpBinary() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like