AOEpeople / crawler

modfunc1/class.tx_crawler_modfunc1.php

Braces +6 added lines, -4 removed lines

@@ -1054,8 +1054,9 @@ 
 		$isAvailable = false;
 		$userArray = \TYPO3\CMS\Backend\Utility\BackendUtility::getRecordsByField('be_users', 'username', '_cli_crawler');
 
-		if (is_array($userArray))
-			$isAvailable = true;
+		if (is_array($userArray)) {
+					$isAvailable = true;
+		}
 
 		return $isAvailable;
 	}
@@ -1073,8 +1074,9 @@ 
 		$isAvailable = false;
 		$userArray = \TYPO3\CMS\Backend\Utility\BackendUtility::getRecordsByField('be_users', 'username', '_cli_crawler');
 
-		if (is_array($userArray) && $userArray[0]['admin'] == 0)
-			$isAvailable = true;
+		if (is_array($userArray) && $userArray[0]['admin'] == 0) {
+					$isAvailable = true;
+		}
 
 		return $isAvailable;
 	}

template/pagination.php

Braces +4 added lines, -1 removed lines

@@ -1,4 +1,7 @@
-<?php if (!defined('TYPO3_MODE')) die ('Access denied.'); ?>
+<?php if (!defined('TYPO3_MODE')) {
+    die ('Access denied.');
+}
+?>
 
 Page:
 <?php for($currentPageOffset 	= 0; $currentPageOffset < $this->getTotalPagesCount(); $currentPageOffset++ ){  ?>

template/process/list.php

Braces +9 added lines, -3 removed lines

@@ -1,4 +1,7 @@ 
-<?php if (!defined('TYPO3_MODE')) die ('Access denied.'); ?>
+<?php if (!defined('TYPO3_MODE')) {
+    die ('Access denied.');
+}
+?>
 
 <br />
 <div id="controll-panel">
@@ -69,8 +72,11 @@ 
 					</div>
 				<?php elseif ($process->getState() == 'cancelled'): ?>
 					<?php echo $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.cancelled'); ?>
-				<?php else: ?>
-					<?php echo $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.success'); ?>
+				<?php else {
+    : ?>
+					<?php echo $this->getLLLabel('LLL:EXT:crawler/modfunc1/locallang.xml:labels.process.success');
+}
+?>
 				<?php endif; ?>
 				</td>
 			</tr>

Classes/Hooks/TsfeHook.php

Braces +3 added lines, -1 removed lines

@@ -76,7 +76,9 @@
         if ($params['pObj']->applicationData['tx_crawler']['running']) {
             $grList = $params['pObj']->applicationData['tx_crawler']['parameters']['feUserGroupList'];
             if ($grList) {
-                if (!is_array($params['pObj']->fe_user->user)) $params['pObj']->fe_user->user = array();
+                if (!is_array($params['pObj']->fe_user->user)) {
+                    $params['pObj']->fe_user->user = array();
+                }
                 $params['pObj']->fe_user->user['usergroup'] = $grList;
                 $params['pObj']->applicationData['tx_crawler']['log'][] = 'User Groups: '.$grList;
             }

cli/crawler_flush.php

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if (!defined('TYPO3_REQUESTTYPE')) die('You cannot run this script directly!');
+if (!defined('TYPO3_REQUESTTYPE')) {
+    die('You cannot run this script directly!');
+}
 
 $crawlerObj = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('tx_crawler_lib');
 $crawlerObj->CLI_main_flush($_SERVER["argv"]);

cli/crawler_im.php

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if (!defined('TYPO3_REQUESTTYPE')) die('You cannot run this script directly!');
+if (!defined('TYPO3_REQUESTTYPE')) {
+    die('You cannot run this script directly!');
+}
 
 $crawlerObj = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('tx_crawler_lib');
 $crawlerObj->CLI_main_im($_SERVER["argv"]);

cli/crawler_cli.php

Braces +3 added lines, -1 removed lines

@@ -1,5 +1,7 @@
 <?php
-if (!defined('TYPO3_REQUESTTYPE'))	die('You cannot run this script directly!');
+if (!defined('TYPO3_REQUESTTYPE')) {
+    die('You cannot run this script directly!');
+}
 
 $crawlerObj = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('tx_crawler_lib');
 

class.tx_crawler_lib.php

Braces +48 added lines, -18 removed lines

@@ -642,7 +642,9 @@ 
             $sets = $pageTSconfig['tx_crawler.']['crawlerCfg.']['paramSets.'];
             if(is_array($sets)) {
                 foreach($sets as $key=>$value) {
-                    if(!is_array($value)) continue;
+                    if(!is_array($value)) {
+                        continue;
+                    }
                     $configurationsForBranch[] = substr($key,-1)=='.'?substr($key,0,-1):$key;
                 }
 
@@ -990,7 +992,9 @@ 
      */
     function addQueueEntry_callBack($setId,$params,$callBack,$page_id=0,$schedule=0) {
 
-        if (!is_array($params))    $params = array();
+        if (!is_array($params)) {
+            $params = array();
+        }
         $params['_CALLBACKOBJ'] = $callBack;
 
             // Compile value array:
@@ -1092,7 +1096,7 @@ 
                 $rows[] = $uid;
                 $urlAdded = true;
                 tx_crawler_domain_events_dispatcher::getInstance()->post('urlAddedToQueue',$this->setID,array('uid' => $uid, 'fieldArray' => $fieldArray));
-            }else{
+            } else{
                 tx_crawler_domain_events_dispatcher::getInstance()->post('duplicateUrlInQueue',$this->setID,array('rows' => $rows, 'fieldArray' => $fieldArray));
             }
         }
@@ -1122,7 +1126,7 @@ 
                 $timeBegin     = $currentTime - 100;
                 $timeEnd     = $currentTime + 100;
                 $where         = ' ((scheduled BETWEEN '.$timeBegin.' AND '.$timeEnd.' ) OR scheduled <= '. $currentTime.') ';
-            }else{
+            } else{
                 $where = 'scheduled <= ' . $currentTime;
             }
         } elseif ($tstamp > $currentTime) {
@@ -1314,18 +1318,24 @@ 
      */
     function requestUrl($originalUrl, $crawlerId, $timeout=2, $recursion=10) {
 
-        if (!$recursion) return false;
+        if (!$recursion) {
+            return false;
+        }
 
             // Parse URL, checking for scheme:
         $url = parse_url($originalUrl);
 
         if ($url === FALSE) {
-            if (TYPO3_DLOG) \TYPO3\CMS\Core\Utility\GeneralUtility::devLog(sprintf('Could not parse_url() for string "%s"', $url), 'crawler', 4, array('crawlerId' => $crawlerId));
+            if (TYPO3_DLOG) {
+                \TYPO3\CMS\Core\Utility\GeneralUtility::devLog(sprintf('Could not parse_url() for string "%s"', $url), 'crawler', 4, array('crawlerId' => $crawlerId));
+            }
             return FALSE;
         }
 
         if (!in_array($url['scheme'], array('','http','https'))) {
-            if (TYPO3_DLOG) \TYPO3\CMS\Core\Utility\GeneralUtility::devLog(sprintf('Scheme does not match for url "%s"', $url), 'crawler', 4, array('crawlerId' => $crawlerId));
+            if (TYPO3_DLOG) {
+                \TYPO3\CMS\Core\Utility\GeneralUtility::devLog(sprintf('Scheme does not match for url "%s"', $url), 'crawler', 4, array('crawlerId' => $crawlerId));
+            }
             return FALSE;
         }
 
@@ -1359,7 +1369,9 @@ 
         $fp = fsockopen($host, $port, $errno, $errstr, $timeout);
 
         if (!$fp) {
-            if (TYPO3_DLOG) \TYPO3\CMS\Core\Utility\GeneralUtility::devLog(sprintf('Error while opening "%s"', $url), 'crawler', 4, array('crawlerId' => $crawlerId));
+            if (TYPO3_DLOG) {
+                \TYPO3\CMS\Core\Utility\GeneralUtility::devLog(sprintf('Error while opening "%s"', $url), 'crawler', 4, array('crawlerId' => $crawlerId));
+            }
             return FALSE;
         } else {
                 // Request message:
@@ -1387,7 +1399,9 @@ 
                 if (is_array($newRequestUrl)) {
                     $result = array_merge(array('parentRequest'=>$result), $newRequestUrl);
                 } else {
-                    if (TYPO3_DLOG) \TYPO3\CMS\Core\Utility\GeneralUtility::devLog(sprintf('Error while opening "%s"', $url), 'crawler', 4, array('crawlerId' => $crawlerId));
+                    if (TYPO3_DLOG) {
+                        \TYPO3\CMS\Core\Utility\GeneralUtility::devLog(sprintf('Error while opening "%s"', $url), 'crawler', 4, array('crawlerId' => $crawlerId));
+                    }
                     return FALSE;
                 }
             }
@@ -1510,20 +1524,32 @@ 
      * @return    string        URL from redirection
      */
     protected function getRequestUrlFrom302Header($headers,$user='',$pass='') {
-        if(!is_array($headers)) return false;
-        if(!(stristr($headers[0],'301 Moved') || stristr($headers[0],'302 Found') || stristr($headers[0],'302 Moved'))) return false;
+        if(!is_array($headers)) {
+            return false;
+        }
+        if(!(stristr($headers[0],'301 Moved') || stristr($headers[0],'302 Found') || stristr($headers[0],'302 Moved'))) {
+            return false;
+        }
 
         foreach($headers as $hl) {
             $tmp = explode(": ",$hl);
             $header[trim($tmp[0])] = trim($tmp[1]);
-            if(trim($tmp[0])=='Location') break;
+            if(trim($tmp[0])=='Location') {
+                break;
+            }
+        }
+        if(!array_key_exists('Location',$header)) {
+            return false;
         }
-        if(!array_key_exists('Location',$header)) return false;
 
         if($user!='') {
-            if(!($tmp = parse_url($header['Location']))) return false;
+            if(!($tmp = parse_url($header['Location']))) {
+                return false;
+            }
             $newUrl = $tmp['scheme'] . '://' . $user . ':' . $pass . '@' . $tmp['host'] . $tmp['path'];
-            if($tmp['query']!='') $newUrl .= '?' . $tmp['query'];
+            if($tmp['query']!='') {
+                $newUrl .= '?' . $tmp['query'];
+            }
         } else {
             $newUrl = $header['Location'];
         }
@@ -1974,7 +2000,7 @@ 
             $configurations = $this->getUrlsForPageId($pageId);
             if(is_array($configurations)){
                 $configurationKeys = array_keys($configurations);
-            }else{
+            } else{
                 $configurationKeys = array();
             }
         }
@@ -2306,7 +2332,9 @@ 
             return false;   //nothing to release
         }
 
-        if(!$withinLock) $this->db->sql_query('BEGIN');
+        if(!$withinLock) {
+            $this->db->sql_query('BEGIN');
+        }
 
             // some kind of 2nd chance algo - this way you need at least 2 processes to have a real cleanup
             // this ensures that a single process can't mess up the entire process table
@@ -2350,7 +2378,9 @@ 
             )
         );
 
-        if(!$withinLock) $this->db->sql_query('COMMIT');
+        if(!$withinLock) {
+            $this->db->sql_query('COMMIT');
+        }
 
         return true;
     }

domain/process/class.tx_crawler_domain_process_manager.php

Braces +1 added lines, -2 removed lines

@@ -178,8 +178,7 @@
         $completePath = '(' .escapeshellcmd($this->getCrawlerCliPath()) . ' &) > /dev/null';
         if (system($completePath) === FALSE) {
             throw new Exception('could not start process!');
-        }
-        else {
+        } else {
             for ($i=0;$i<10;$i++) {
                 if ($this->processRepository->countNotTimeouted($ttl) > $current) {
                     return true;