Configuration::fromArray() - Code Metrics - Inspection of "[WIP] Switch to configuration object" - AOEpeople/crawler - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/switch-to-configuratio... ( 74ae66 )

by Tomas Norre

created 2020-11-19 12:00 UTC

Configuration::fromArray() A

↳ Parent: Configuration

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	10
c	0
b	0
f	0
nc	3
nop	1
dl	0
loc	17
ccs	11
cts	11
cp	1
crap	3
rs	9.9332

<?php

declare(strict_types=1);

namespace AOE\Crawler\Domain\Model;

/*
 * (c) 2020 AOE GmbH <[email protected]>
 *
 * This file is part of the TYPO3 Crawler Extension.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

use Assert\Assert;
use TYPO3\CMS\Extbase\DomainObject\AbstractEntity;

/**
 * Class Configuration
 */
class Configuration extends AbstractEntity
{
    /**
     * @var string
     */
    protected $name = '';

    /**
     * @var int
     */
    protected $forceSsl = 1;

    /**
     * @var string
     */
    protected $processingInstructionFilter = '';

    /**
     * @var string
     */
    protected $processingInstructionParameters = '';

    /**
     * @var string
     */
    protected $configuration = '';

    /**
     * @var string
     */
    protected $baseUrl = '';

    /**
     * @var string
     */
    protected $pidsonly = '';

    /**
     * @var string
     */
    protected $begroups = '';

    /**
     * @var string
     */
    protected $fegroups = '';

    /**
     * @var string
     */
    protected $exclude = '';

    public function __construct(string $name)
    {
        $this->name = $name;
    }

    public static function fromArray($array): self
    {
        Assert::that($array)
            ->keyIsset('name','Name needs to be set to create a new Object from Array');

        $configuration = new self($array['name']);

        foreach($array as $key => $value) {
            $property = self::getPropertyMap($key);
            $property = self::getPropertyMap($key);
            if (empty($property)) {
                continue;
            }
            $setProperty = "set$property";
            $configuration->${setProperty}($value);

        }

        return $configuration;
    }

    private function getPropertyMap($key): string
    {
        $propertyMap = [
            'procInstrFilter' => 'ProcessingInstructionFilter',
            'baseUrl' => 'BaseUrl',
            'procInstrParams.'  => 'ProcessingInstructionParameters',
            'force_ssl' => 'ForceSsl',
            // Not sure if it be or fegroups
            'userGroups' => 'FeGroups',
            'exclude' => 'Exclude',
            //'key'  => '',
            'name'  => 'Name',
        ];

        return $propertyMap[$key] ?: '';
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @param string $name
     */
    public function setName($name): void
    {
        $this->name = $name;
    }

    /**
     * @return int
     */
    public function isForceSsl()
    {
        return $this->forceSsl;
    }

    /**
     * @param int $forceSsl
     */
    public function setForceSsl($forceSsl): void
    {
        $this->forceSsl = $forceSsl;
    }

    /**
     * @return string
     */
    public function getProcessingInstructionFilter()
    {
        return $this->processingInstructionFilter;
    }

    /**
     * @param string $processingInstructionFilter
     */
    public function setProcessingInstructionFilter($processingInstructionFilter): void
    {
        $this->processingInstructionFilter = $processingInstructionFilter;
    }

    /**
     * @return string|array
     */
    public function getProcessingInstructionParameters()
    {
        return $this->processingInstructionParameters;
    }

    /**
     * @param string|array $processingInstructionParameters
     */
    public function setProcessingInstructionParameters($processingInstructionParameters): void
    {
        $this->processingInstructionParameters = $processingInstructionParameters;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * @return string
     */
    public function getConfiguration()
    {
        return $this->configuration;
    }

    /**
     * @param string $configuration
     */
    public function setConfiguration($configuration): void
    {
        $this->configuration = $configuration;
    }

    /**
     * @return string
     */
    public function getBaseUrl()
    {
        return $this->baseUrl;
    }

    /**
     * @param string $baseUrl
     */
    public function setBaseUrl($baseUrl): void
    {
        $this->baseUrl = $baseUrl;
    }

    public function getPidsOnly()
    {
        return $this->pidsonly;
    }

    public function setPidsOnly($pidsOnly): void
    {
        $this->pidsonly = $pidsOnly;
    }

    /**
     * @return string
     */
    public function getBeGroups()
    {
        return $this->begroups;
    }

    /**
     * @param string $beGroups
     */
    public function setBeGroups($beGroups): void
    {
        $this->begroups = $beGroups;
    }

    /**
     * @return string
     */
    public function getFeGroups()
    {
        return $this->fegroups;
    }

    /**
     * @param string $feGroups
     */
    public function setFeGroups($feGroups): void
    {
        $this->fegroups = $feGroups;
    }

    /**
     * @return string
     */
    public function getExclude()
    {
        return $this->exclude;
    }

    /**
     * @param string $exclude
     */
    public function setExclude($exclude): void
    {
        $this->exclude = $exclude;
    }
}


AOEpeople / crawler

Push — feature/switch-to-configuratio... ( 74ae66 )

Configuration::fromArray() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like