JsonCompatibilityConverter::convert() - Code Metrics - Inspection of "[WIP] Documentation" - AOEpeople/crawler - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — features/addFlushedPagesToCraw... ( 44f5f4...d700c8 )

by Tomas Norre

created 2020-07-13 20:19 UTC

JsonCompatibilityConverter::convert() A

↳ Parent: JsonCompatibilityConverter

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3.1825

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
c	1
b	0
f	0
nc	3
nop	1
dl	0
loc	13
ccs	8
cts	11
cp	0.7272
crap	3.1825
rs	10

<?php

declare(strict_types=1);

namespace AOE\Crawler\Converter;

/*
 * (c) 2020 AOE GmbH <[email protected]>
 *
 * This file is part of the TYPO3 Crawler Extension.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

class JsonCompatibilityConverter
{
    /**
     * This is implemented as we want to switch away from serialized data to json data, when the crawler is storing
     * in the database. To ensure that older crawler entries, which have already been stored as serialized data
     * still works, we have added this converter that can be used for the reading part. The writing part will be done
     * in json from now on.
     * @see https://github.com/AOEpeople/crawler/issues/417
     *
     * @return array|bool
     */
    public function convert(string $dataString)
    {
        $unserialized = unserialize($dataString, ['allowed_classes' => false]);
        if ($unserialized) {
            return $unserialized;
        }

        $decoded = json_decode($dataString, true);
        if ($decoded) {
            return $decoded;
        }

        return false;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace AOE\Crawler\Converter;
6
7		/*
8		* (c) 2020 AOE GmbH <[email protected]>
9		*
10		* This file is part of the TYPO3 Crawler Extension.
11		*
12		* It is free software; you can redistribute it and/or modify it under
13		* the terms of the GNU General Public License, either version 2
14		* of the License, or any later version.
15		*
16		* For the full copyright and license information, please read the
17		* LICENSE.txt file that was distributed with this source code.
18		*
19		* The TYPO3 project - inspiring people to share!
20		*/
21
22		class JsonCompatibilityConverter
23		{
24		/**
25		* This is implemented as we want to switch away from serialized data to json data, when the crawler is storing
26		* in the database. To ensure that older crawler entries, which have already been stored as serialized data
27		* still works, we have added this converter that can be used for the reading part. The writing part will be done
28		* in json from now on.
29		* @see https://github.com/AOEpeople/crawler/issues/417
30		*
31		* @return array\|bool
32		*/
33	15	public function convert(string $dataString)
34		{
35	15	$unserialized = unserialize($dataString, ['allowed_classes' => false]);
36	15	if ($unserialized) {
37	1	return $unserialized;
38		}
39
40	14	$decoded = json_decode($dataString, true);
41	14	if ($decoded) {
42	11	return $decoded;
43		}
44
45	3	return false;
46		}
47		}
48

AOEpeople / crawler

Push — features/addFlushedPagesToCraw... ( 44f5f4...d700c8 )

JsonCompatibilityConverter::convert() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like