JsonCompatibilityConverter::convert() - Code Metrics - Inspection of "Updating tests to have better mutation score" - AOEpeople/crawler - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — ci/infection ( a25359...ab479d )

by Tomas Norre

created 2020-07-03 06:58 UTC

JsonCompatibilityConverter::convert() A

↳ Parent: JsonCompatibilityConverter

Complexity

Conditions	5
Paths	4

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	5.583

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	9
c	1
b	0
f	0
nc	4
nop	1
dl	0
loc	18
ccs	10
cts	14
cp	0.7143
crap	5.583
rs	9.6111

<?php

declare(strict_types=1);

namespace AOE\Crawler\Converter;

/*
 * (c) 2020 AOE GmbH <[email protected]>
 *
 * This file is part of the TYPO3 Crawler Extension.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

class JsonCompatibilityConverter
{
    /**
     * This is implemented as we want to switch away from serialized data to json data, when the crawler is storing
     * in the database. To ensure that older crawler entries, which have already been stored as serialized data
     * still works, we have added this converter that can be used for the reading part. The writing part will be done
     * in json from now on.
     * @see https://github.com/AOEpeople/crawler/issues/417
     *
     * @return array|bool
     * @throws \Exception
     */
    public function convert(string $dataString)
    {
        $unserialized = unserialize($dataString, ['allowed_classes' => false]);

        if (is_object($unserialized)) {
            throw new \Exception('Objects are not allowed' . var_export($unserialized, true), 1593758307);
        }

        if ($unserialized && ! is_object($unserialized)) {
            return $unserialized;
        }

        $decoded = json_decode($dataString, true);
        if ($decoded) {
            return $decoded;
        }

        return false;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace AOE\Crawler\Converter;
6
7		/*
8		* (c) 2020 AOE GmbH <[email protected]>
9		*
10		* This file is part of the TYPO3 Crawler Extension.
11		*
12		* It is free software; you can redistribute it and/or modify it under
13		* the terms of the GNU General Public License, either version 2
14		* of the License, or any later version.
15		*
16		* For the full copyright and license information, please read the
17		* LICENSE.txt file that was distributed with this source code.
18		*
19		* The TYPO3 project - inspiring people to share!
20		*/
21
22		class JsonCompatibilityConverter
23		{
24		/**
25		* This is implemented as we want to switch away from serialized data to json data, when the crawler is storing
26		* in the database. To ensure that older crawler entries, which have already been stored as serialized data
27		* still works, we have added this converter that can be used for the reading part. The writing part will be done
28		* in json from now on.
29		* @see https://github.com/AOEpeople/crawler/issues/417
30		*
31		* @return array\|bool
32		* @throws \Exception
33		*/
34	16	public function convert(string $dataString)
35		{
36	16	$unserialized = unserialize($dataString, ['allowed_classes' => false]);
37
38	16	if (is_object($unserialized)) {
39	1	throw new \Exception('Objects are not allowed' . var_export($unserialized, true), 1593758307);
40		}
41
42	15	if ($unserialized && ! is_object($unserialized)) {
43	1	return $unserialized;
44		}
45
46	14	$decoded = json_decode($dataString, true);
47	14	if ($decoded) {
48	11	return $decoded;
49		}
50
51	3	return false;
52		}
53		}
54

AOEpeople / crawler

Push — ci/infection ( a25359...ab479d )

JsonCompatibilityConverter::convert() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like