AOEpeople / crawler

domain/process/class.tx_crawler_domain_process.php

Spacing +1 added lines, -1 removed lines

@@ -128,7 +128,7 @@
 	 */
 	public function getProgress() {
 		$all = $this->countItemsAssigned();
-		if ($all<=0) {
+		if ($all <= 0) {
 			return 0;
 		}
 

domain/process/class.tx_crawler_domain_process_collection.php

Spacing +6 added lines, -6 removed lines

@@ -48,8 +48,8 @@ 
 	 * @return tx_crawler_domain_process
 	 */
 	public function offsetGet($index) {
-		if (! parent::offsetExists($index)) {
-			throw new Exception('Index "' . var_export($index, true) . '" for tx_crawler_domain_process are not available');
+		if (!parent::offsetExists($index)) {
+			throw new Exception('Index "'.var_export($index, true).'" for tx_crawler_domain_process are not available');
 		}
 		return parent::offsetGet($index);
 	}
@@ -63,7 +63,7 @@ 
 	 * @return void
 	 */
 	public function offsetSet($index, $subject) {
-		if (! $subject instanceof tx_crawler_domain_process ) {
+		if (!$subject instanceof tx_crawler_domain_process) {
 			throw new InvalidArgumentException('Wrong parameter type given, "tx_crawler_domain_process" expected!');
 		}
 		parent::offsetSet($index, $subject);
@@ -76,7 +76,7 @@ 
 	 * @return void
 	 */
 	public function append($subject) {
-		if (! $subject instanceof tx_crawler_domain_process ) {
+		if (!$subject instanceof tx_crawler_domain_process) {
 			throw new InvalidArgumentException('Wrong parameter type given, "tx_crawler_domain_process" expected!');
 		}
 		parent::append($subject);
@@ -87,9 +87,9 @@ 
 	 * @return array
 	 */
 	public function getProcessIds() {
-		$result=array();
+		$result = array();
 		foreach ($this->getIterator() as $value) {
-			$result[]=$value->getProcess_id();
+			$result[] = $value->getProcess_id();
 		}
 		return $result;
 	}

domain/events/class.tx_crawler_domain_events_dispatcher.php

Spacing +5 added lines, -5 removed lines

@@ -70,7 +70,7 @@ 
 	 */
     protected function __construct() {
     	$this->observers = array();
-    	if (is_array ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['crawler/domain/events/class.tx_crawler_domain_events_dispatcher.php']['registerObservers'])) {
+    	if (is_array($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['crawler/domain/events/class.tx_crawler_domain_events_dispatcher.php']['registerObservers'])) {
 			foreach ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['crawler/domain/events/class.tx_crawler_domain_events_dispatcher.php']['registerObservers'] as $classRef) {
 				$hookObj = &\TYPO3\CMS\Core\Utility\GeneralUtility::getUserObj($classRef);
 				if (method_exists($hookObj, 'registerObservers')) {
@@ -122,9 +122,9 @@ 
 	 * @return void
 	 */
 	public function post($event, $group, $attachedData) {
-		if(is_array($this->observers[$event])) {
-			foreach($this->observers[$event] as $eventObserver) {
-				call_user_func(array($eventObserver['object'],$eventObserver['method']),$event,$group,$attachedData);
+		if (is_array($this->observers[$event])) {
+			foreach ($this->observers[$event] as $eventObserver) {
+				call_user_func(array($eventObserver['object'], $eventObserver['method']), $event, $group, $attachedData);
 			}
 		}
 	}
@@ -137,7 +137,7 @@ 
 	 */
 	public static function getInstance() {
 
-		if(!self::$instance instanceof tx_crawler_domain_events_dispatcher) {
+		if (!self::$instance instanceof tx_crawler_domain_events_dispatcher) {
 			$dispatcher = new tx_crawler_domain_events_dispatcher();
 			self::$instance = $dispatcher;
 		}

Classes/Utility/SchedulerUtility.php

Spacing +10 added lines, -10 removed lines

@@ -42,36 +42,36 @@
     {
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks']['AOE\\Crawler\\Task\\CrawlerQueueTask'] = array(
             'extension'        => $extKey,
-            'title'            => 'LLL:EXT:' . $extKey . '/Resources/Private/Language/Backend.xlf:crawler_im.name',
-            'description'      => 'LLL:EXT:' . $extKey . '/Resources/Private/Language/Backend.xlf:crawler_im.description',
+            'title'            => 'LLL:EXT:'.$extKey.'/Resources/Private/Language/Backend.xlf:crawler_im.name',
+            'description'      => 'LLL:EXT:'.$extKey.'/Resources/Private/Language/Backend.xlf:crawler_im.description',
             'additionalFields' => 'AOE\\Crawler\\Task\\CrawlerQueueTaskAdditionalFieldProvider'
         );
 
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks']['AOE\\Crawler\\Task\\CrawlerTask'] = array(
             'extension'        => $extKey,
-            'title'            => 'LLL:EXT:' . $extKey . '/Resources/Private/Language/Backend.xlf:crawler_crawl.name',
-            'description'      => 'LLL:EXT:' . $extKey . '/Resources/Private/Language/Backend.xlf:crawler_crawl.description',
+            'title'            => 'LLL:EXT:'.$extKey.'/Resources/Private/Language/Backend.xlf:crawler_crawl.name',
+            'description'      => 'LLL:EXT:'.$extKey.'/Resources/Private/Language/Backend.xlf:crawler_crawl.description',
             'additionalFields' => 'AOE\\Crawler\\Task\\CrawlerTaskAdditionalFieldProvider'
         );
 
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks']['AOE\\Crawler\\Task\\CrawlMultiProcessTask'] = array(
             'extension'        => $extKey,
-            'title'            => 'LLL:EXT:' . $extKey . '/Resources/Private/Language/Backend.xlf:crawler_crawlMultiProcess.name',
-            'description'      => 'LLL:EXT:' . $extKey . '/Resources/Private/Language/Backend.xlf:crawler_crawl.description',
+            'title'            => 'LLL:EXT:'.$extKey.'/Resources/Private/Language/Backend.xlf:crawler_crawlMultiProcess.name',
+            'description'      => 'LLL:EXT:'.$extKey.'/Resources/Private/Language/Backend.xlf:crawler_crawl.description',
             'additionalFields' => 'AOE\\Crawler\\Task\\CrawlMultiProcessTaskAdditionalFieldProvider'
         );
 
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks']['AOE\\Crawler\\Task\\FlushQueueTask'] = array(
             'extension'        => $extKey,
-            'title'            => 'LLL:EXT:' . $extKey . '/Resources/Private/Language/Backend.xlf:crawler_flush.name',
-            'description'      => 'LLL:EXT:' . $extKey . '/Resources/Private/Language/Backend.xlf:crawler_flush.description',
+            'title'            => 'LLL:EXT:'.$extKey.'/Resources/Private/Language/Backend.xlf:crawler_flush.name',
+            'description'      => 'LLL:EXT:'.$extKey.'/Resources/Private/Language/Backend.xlf:crawler_flush.description',
             'additionalFields' => 'AOE\\Crawler\\Task\\FlushQueueTaskAdditionalFieldProvider'
         );
 
         $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks']['AOE\\Crawler\\Task\\ProcessCleanupTask'] = array(
             'extension'        => $extKey,
-            'title'            => 'LLL:EXT:' . $extKey . '/Resources/Private/Language/Backend.xlf:crawler_processCleanup.name',
-            'description'      => 'LLL:EXT:' . $extKey . '/Resources/Private/Language/Backend.xlf:crawler_processCleanup.description',
+            'title'            => 'LLL:EXT:'.$extKey.'/Resources/Private/Language/Backend.xlf:crawler_processCleanup.name',
+            'description'      => 'LLL:EXT:'.$extKey.'/Resources/Private/Language/Backend.xlf:crawler_processCleanup.description',
         );
     }
 }

Classes/Utility/TypoScriptUtility.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
             $templateUid = $GLOBALS['TYPO3_DB']->exec_SELECTgetSingleRow(
                 '*',
                 'sys_template',
-                'root=1 AND pid=' . (int)$page['uid'] .
+                'root=1 AND pid='.(int) $page['uid'].
                 \TYPO3\CMS\Backend\Utility\BackendUtility::BEenableFields('sys_template')
             );
 

Classes/Api/CrawlerApi.php

Spacing +11 added lines, -11 removed lines

@@ -91,7 +91,7 @@ 
      */
     protected function findCrawler()
     {
-        if ( ! is_object($this->crawlerObj)) {
+        if (!is_object($this->crawlerObj)) {
             $this->crawlerObj = GeneralUtility::makeInstance('tx_crawler_lib');
             $this->crawlerObj->setID = GeneralUtility::md5int(microtime());
         }
@@ -126,7 +126,7 @@ 
         if (count($this->allowedConfigrations) > 0) {
             // 	remove configuration that does not match the current selection
             foreach ($configurations as $confKey => $confArray) {
-                if ( ! in_array($confKey, $this->allowedConfigrations)) {
+                if (!in_array($confKey, $this->allowedConfigrations)) {
                     unset($configurations[$confKey]);
                 }
             }
@@ -192,12 +192,12 @@ 
         //if the same page is scheduled for the same time and has not be executed?
         if ($schedule_timestamp == 0) {
             //untimed elements need an exec_time with 0 because they can occure multiple times
-            $where = 'page_id=' . $page_uid . ' AND exec_time = 0 AND scheduled=' . $schedule_timestamp;
+            $where = 'page_id='.$page_uid.' AND exec_time = 0 AND scheduled='.$schedule_timestamp;
         } else {
             //timed elementes have got a fixed schedule time, if a record with this time
             //exists it is maybe queued for the future, or is has been queue for the past and therefore
             //also been processed.
-            $where = 'page_id=' . $page_uid . ' AND scheduled=' . $schedule_timestamp;
+            $where = 'page_id='.$page_uid.' AND scheduled='.$schedule_timestamp;
         }
 
         $row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($GLOBALS['TYPO3_DB']->exec_SELECTquery('count(*) as cnt',
@@ -224,7 +224,7 @@ 
 
         $isPageInQueue = false;
 
-        $whereClause = 'page_id = ' . (integer)$uid;
+        $whereClause = 'page_id = '.(integer) $uid;
 
         if (false !== $unprocessed_only) {
             $whereClause .= ' AND exec_time = 0';
@@ -235,7 +235,7 @@ 
         }
 
         if (false !== $timestamp) {
-            $whereClause .= ' AND scheduled = ' . (integer)$timestamp;
+            $whereClause .= ' AND scheduled = '.(integer) $timestamp;
         }
 
         $count = $GLOBALS['TYPO3_DB']->exec_SELECTcountRows(
@@ -264,10 +264,10 @@ 
     {
         $uid   = intval($uid);
         $query = 'max(scheduled) as latest';
-        $where = ' page_id = ' . $uid;
+        $where = ' page_id = '.$uid;
 
         if ($future_crawldates_only) {
-            $where .= ' AND scheduled > ' . time();
+            $where .= ' AND scheduled > '.time();
         }
 
         if ($unprocessed_only) {
@@ -300,7 +300,7 @@ 
         $limit = $GLOBALS['TYPO3_DB']->fullQuoteStr($limit, 'tx_crawler_queue');
 
         $query = 'scheduled, exec_time, set_id';
-        $where = ' page_id = ' . $uid;
+        $where = ' page_id = '.$uid;
 
         $limit_query = ($limit) ? $limit : null;
 
@@ -378,7 +378,7 @@ 
     {
         $qid   = intval($qid);
         $table = 'tx_crawler_queue';
-        $where = ' qid=' . $qid;
+        $where = ' qid='.$qid;
         $GLOBALS['TYPO3_DB']->exec_DELETEquery($table, $where);
     }
 
@@ -406,7 +406,7 @@ 
      */
     protected function getQueueRepository()
     {
-        if ( ! $this->queueRepository instanceof \tx_crawler_domain_queue_repository) {
+        if (!$this->queueRepository instanceof \tx_crawler_domain_queue_repository) {
             $this->queueRepository = new \tx_crawler_domain_queue_repository();
         }
 

Classes/Hooks/TsfeHook.php

Spacing +6 added lines, -6 removed lines

@@ -48,8 +48,8 @@ 
         if (isset($_SERVER['HTTP_X_T3CRAWLER'])) {
             //@todo: ask service to exclude current call for special reasons: for example no relevance because the language version is not affected
 
-            list($queueId,$hash) = explode(':', $_SERVER['HTTP_X_T3CRAWLER']);
-            list($queueRec) = $GLOBALS['TYPO3_DB']->exec_SELECTgetRows('*','tx_crawler_queue','qid='.intval($queueId));
+            list($queueId, $hash) = explode(':', $_SERVER['HTTP_X_T3CRAWLER']);
+            list($queueRec) = $GLOBALS['TYPO3_DB']->exec_SELECTgetRows('*', 'tx_crawler_queue', 'qid='.intval($queueId));
 
             // If a crawler record was found and hash was matching, set it up:
             if (is_array($queueRec) && $hash === md5($queueRec['qid'].'|'.$queueRec['set_id'].'|'.$GLOBALS['TYPO3_CONF_VARS']['SYS']['encryptionKey'])) {
@@ -119,10 +119,10 @@ 
              * Required because some extensions (staticpub) might never be requested to run due to some Core side effects
              * and since this is considered as error the crawler should handle it properly
              */
-            if(is_array($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['crawler']['pollSuccess'])) {
-                foreach($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['crawler']['pollSuccess'] as $pollable) {
-                    if(is_array($params['pObj']->applicationData['tx_crawler']['content']['parameters']['procInstructions']) && in_array($pollable,$params['pObj']->applicationData['tx_crawler']['content']['parameters']['procInstructions'])){
-                        if(empty($params['pObj']->applicationData['tx_crawler']['success'][$pollable])) {
+            if (is_array($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['crawler']['pollSuccess'])) {
+                foreach ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['crawler']['pollSuccess'] as $pollable) {
+                    if (is_array($params['pObj']->applicationData['tx_crawler']['content']['parameters']['procInstructions']) && in_array($pollable, $params['pObj']->applicationData['tx_crawler']['content']['parameters']['procInstructions'])) {
+                        if (empty($params['pObj']->applicationData['tx_crawler']['success'][$pollable])) {
                             $params['pObj']->applicationData['tx_crawler']['errorlog'][] = 'Error: Pollable extension ('.$pollable.') did not complete successfully.';
                         }
                     }

Classes/Hooks/ProcessCleanUpHook.php

Spacing +10 added lines, -10 removed lines

@@ -70,14 +70,14 @@ 
         $results = $this->getDatabaseConnection()->exec_SELECTgetRows(
             'process_id, system_process_id',
             'tx_crawler_process',
-            'ttl <= ' . intval(time() - $this->extensionSettings['processMaxRunTime'] - 3600) . ' AND active = 1'
+            'ttl <= '.intval(time() - $this->extensionSettings['processMaxRunTime'] - 3600).' AND active = 1'
         );
 
         if (!is_array($results)) {
             return;
         }
         foreach ($results as $result) {
-            $systemProcessId = (int)$result['system_process_id'];
+            $systemProcessId = (int) $result['system_process_id'];
             $processId = $result['process_id'];
             if ($systemProcessId > 1) {
                 if ($this->doProcessStillExists($systemProcessId)) {
@@ -98,7 +98,7 @@ 
         $results = $this->getDatabaseConnection()->exec_SELECTgetRows(
             'process_id, system_process_id',
             'tx_crawler_process',
-            'ttl <= ' . intval(time() - $this->extensionSettings['processMaxRunTime']) . ' AND active = 1'
+            'ttl <= '.intval(time() - $this->extensionSettings['processMaxRunTime']).' AND active = 1'
         );
 
         if (!is_array($results)) {
@@ -106,7 +106,7 @@ 
         }
         foreach ($results as $result) {
             $processExists = false;
-            $systemProcessId = (int)$result['system_process_id'];
+            $systemProcessId = (int) $result['system_process_id'];
             $processId = $result['process_id'];
             if ($systemProcessId > 1) {
                 $dispatcherProcesses = $this->findDispatcherProcesses();
@@ -116,7 +116,7 @@ 
                 }
                 foreach ($dispatcherProcesses as $process) {
                     $responseArray = $this->createResponseArray($process);
-                    if ($systemProcessId === (int)$responseArray[1]) {
+                    if ($systemProcessId === (int) $responseArray[1]) {
                         $processExists = true;
                     };
                 }
@@ -138,12 +138,12 @@ 
     {
         $this->getDatabaseConnection()->exec_DELETEquery(
             'tx_crawler_process',
-            'process_id = ' . $this->getDatabaseConnection()->fullQuoteStr($processId, 'tx_crawler_process')
+            'process_id = '.$this->getDatabaseConnection()->fullQuoteStr($processId, 'tx_crawler_process')
         );
 
         $this->getDatabaseConnection()->exec_UPDATEquery(
             'tx_crawler_queue',
-            'process_id = ' . $this->getDatabaseConnection()->fullQuoteStr($processId, 'tx_crawler_queue'),
+            'process_id = '.$this->getDatabaseConnection()->fullQuoteStr($processId, 'tx_crawler_queue'),
             array('process_id' => '')
         );
     }
@@ -177,12 +177,12 @@ 
         $doProcessStillExists = false;
         if (!$this->isOsWindows()) {
             // Not windows
-            if (file_exists('/proc/' . $pid)) {
+            if (file_exists('/proc/'.$pid)) {
                 $doProcessStillExists = true;
             }
         } else {
             // Windows
-            exec('tasklist | find "' . $pid . '"', $returnArray, $returnValue);
+            exec('tasklist | find "'.$pid.'"', $returnArray, $returnValue);
             if (count($returnArray) > 0 && preg_match('/php/i', $returnValue[0])) {
                 $doProcessStillExists = true;
             }
@@ -204,7 +204,7 @@ 
             posix_kill($pid, 9);
         } else {
             // Windows
-            exec('taskkill /PID ' . $pid);
+            exec('taskkill /PID '.$pid);
         }
     }
 

Classes/Hooks/StaticFileCacheCreateUriHook.php

Spacing +3 added lines, -3 removed lines

@@ -66,10 +66,10 @@
         if ($this->isCrawlerExtensionRunning($frontend) && preg_match('#^/index.php\?&?id=(\d+)(&.*)?$#', $uri, $matches)) {
             $speakingUri = $frontend->cObj->typoLink_URL(array('parameter' => $matches[1], 'additionalParams' => $matches[2]));
             $speakingUriParts = parse_url($speakingUri);
-            if(false === $speakingUriParts){
-                throw new \Exception('Could not parse URI: ' . $speakingUri, 1289915976);
+            if (false === $speakingUriParts) {
+                throw new \Exception('Could not parse URI: '.$speakingUri, 1289915976);
             }
-            $speakingUrlPath = '/' . ltrim($speakingUriParts['path'], '/');
+            $speakingUrlPath = '/'.ltrim($speakingUriParts['path'], '/');
             // Don't change anything if speaking URL is part of old URI:
             // (it might be the case the using the speaking URL failed)
             if (strpos($uri, $speakingUrlPath) !== 0 || $speakingUrlPath === '/') {