Factory::createServer() - Code Metrics - Inspection of "Feature/typo3 11 codestyle" - AOEpeople/asdis - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#16)

unknown

created 2022-10-26 11:48 UTC

Factory::createServer() A

↳ Parent: Factory

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1.125

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	6
nc	1
nop	3
dl	0
loc	8
ccs	2
cts	4
cp	0.5
crap	1.125
rs	10
c	1
b	0
f	0

<?php

namespace Aoe\Asdis\Domain\Model\Server;

use Aoe\Asdis\Domain\Model\Server;
use Aoe\Asdis\System\Configuration\Provider;
use Exception;
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * Factory for server objects.
 */
class Factory
{
    private ?string $protocolMarker = '';

    public function injectConfigurationProvider(Provider $configurationProvider): void
    {
        try {
            $this->protocolMarker = $configurationProvider->getServerProtocolMarker();
        } catch (Exception $exception) {
            $this->protocolMarker = '';
        }
    }

    /**
     * @param string $identifier
     * @param string $domain
     * @param string $protocol
     * @return \Aoe\Asdis\Domain\Model\Server
     */
    public function createServer($identifier, $domain, $protocol)
    {
        $server = GeneralUtility::makeInstance(Server::class);
        $server->setIdentifier($identifier);
        $server->setDomain($domain);
        $server->setProtocol($protocol);
        $server->setProtocolMarker($this->protocolMarker);
        return $server;
    }
}


1		<?php
2
3		namespace Aoe\Asdis\Domain\Model\Server;
4
5		use Aoe\Asdis\Domain\Model\Server;
6		use Aoe\Asdis\System\Configuration\Provider;
7		use Exception;
8		use TYPO3\CMS\Core\Utility\GeneralUtility;
9
10		/**
11		* Factory for server objects.
12		*/
13		class Factory
14		{
15		private ?string $protocolMarker = '';
16
17		public function injectConfigurationProvider(Provider $configurationProvider): void
18		{
19		try {
20		$this->protocolMarker = $configurationProvider->getServerProtocolMarker();
21		} catch (Exception $exception) {
22		$this->protocolMarker = '';
23		}
24		}
25
26	1	/**
27		* @param string $identifier
28	1	* @param string $domain
29	1	* @param string $protocol
30		* @return \Aoe\Asdis\Domain\Model\Server
31		*/
32		public function createServer($identifier, $domain, $protocol)
33		{
34	1	$server = GeneralUtility::makeInstance(Server::class);
35		$server->setIdentifier($identifier);
36		$server->setDomain($domain);
37	1	$server->setProtocol($protocol);
38		$server->setProtocolMarker($this->protocolMarker);
39		return $server;
40		}
41		}
42

AOEpeople / asdis

Pull Request — master (#16)

Factory::createServer() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like