Aoe\Asdis\System\Configuration\TypoScriptConfiguration

Complexity

Total Complexity

13

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Test Coverage

Coverage

53.13%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getSetting()	0	29	11
A	getTypoScriptConfigurationArray()	0	18	2

<?php
namespace Aoe\Asdis\System\Configuration;

use Aoe\Asdis\System\Configuration\Exception\InvalidTypoScriptSetting;
use Aoe\Asdis\System\Configuration\Exception\TypoScriptSettingNotExists;
use TYPO3\CMS\Core\SingletonInterface;
use TYPO3\CMS\Core\TypoScript\TemplateService;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Core\Utility\RootlineUtility;

/**
 * TypoScript configuration provider.
 */
class TypoScriptConfiguration implements SingletonInterface 
{
    /**
     * @var array
     */
    private $configuration;

The private property $configuration is not used, and could be removed.

    /**
     * @var array
     */
    private $configurationCache = [];

    /**
     * @param string $key The setting key. E.g. "logger.severity"
     * @param string $validateType The data type to be validated against (E.g. "string"). Empty string to skip validation.
     * @param boolean $hasSubkeys Tells whether the requested key is assumed to has subkeys.
     * @return mixed
     * @throws \Aoe\Asdis\System\Configuration\Exception\InvalidTypoScriptSetting
     * @throws \Aoe\Asdis\System\Configuration\Exception\TypoScriptSettingNotExists
     */
    public function getSetting($key, $validateType = '', $hasSubkeys = false)
    {
        if (isset($this->configurationCache[$key])) {
            return $this->configurationCache[$key];
        }
        $parts = explode('.', $key);
        if (false === is_array($parts) || sizeof($parts) < 1) {
            throw new TypoScriptSettingNotExists($key, 1372050700894);
        }
        $conf = $this->getTypoScriptConfigurationArray();
        $lastPartIndex = sizeof($parts) - 1;
        foreach($parts as $index => $part) {
            $subkey = $part;
            if ($lastPartIndex !== $index || $hasSubkeys) {
                $subkey .= '.';
            }
            if (false === isset($conf[$subkey])) {
                throw new TypoScriptSettingNotExists($key, 1372063884313);
            }
            $conf = $conf[$subkey];
            if ($lastPartIndex === $index) {
                break;
            }
        }
        if (strlen($validateType) > 0 && strcmp($validateType, gettype($conf)) !== 0) {
            throw new InvalidTypoScriptSetting($key, gettype($conf), 1372064668444);
        }
        $this->configurationCache[$key] = $conf;
        return $conf;
    }

    /**
     * @return array
     */
    protected function getTypoScriptConfigurationArray()
    {
        if (true === version_compare(\TYPO3\CMS\Core\Utility\VersionNumberUtility::getCurrentTypo3Version(), '9.5.0', '<')) {
            return $GLOBALS['TSFE']->tmpl->setup['config.']['tx_asdis.'];
        }

        /** @var Site $site */
        $site = $GLOBALS['TYPO3_REQUEST']->getAttribute('site');
        /** @var RootlineUtility $rootlineUtility */
        $rootlineUtility = GeneralUtility::makeInstance(RootlineUtility::class, $site->getRootPageId());
        $rootline = $rootlineUtility->get();
        /** @var TemplateService $templateService */
        $templateService = GeneralUtility::makeInstance(TemplateService::class);
        $templateService->tt_track = 0;

The property $tt_track was declared of type boolean, but 0 is of type integer. Maybe add a type cast?

        $templateService->runThroughTemplates($rootline);
        $templateService->generateConfig();

        return $templateService->setup['config.']['tx_asdis.'];
    }
}