AbstractHook::getVarnish() - Code Metrics - Inspection of "TYPO3 10 LTS compatible" - AOEpeople/TYPO3-varnish - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by Tomas Norre

created 2021-05-27 09:12 UTC

AbstractHook::getVarnish() A

↳ Parent: AbstractHook

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	5
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php
namespace Aoe\Varnish\TYPO3\Hooks;

/***************************************************************
 *  Copyright notice
 *
 *  (c) 2018 AOE GmbH <[email protected]>
 *
 *  All rights reserved
 *
 *  This script is part of the TYPO3 project. The TYPO3 project is
 *  free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 3 of the License, or
 *  (at your option) any later version.
 *
 *  The GNU General Public License can be found at
 *  http://www.gnu.org/copyleft/gpl.html.
 *
 *  This script is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  This copyright notice MUST APPEAR in all copies of the script!
 ***************************************************************/

use Aoe\Varnish\System\Varnish;
use TYPO3\CMS\Core\Utility\GeneralUtility;

abstract class AbstractHook
{
    /**
     * @var Varnish
     */
    protected $varnish;

    /**
     * @var \TYPO3\CMS\Extbase\Object\ObjectManagerInterface $objectManager
     */
    protected $objectManager;

    public function injectObjectManager(ObjectManagerInterface $objectManager): void
    {
        $this->objectManager = $objectManager;

    }

    protected function getVarnish(): Varnish
    {
        $this->varnish = $this->varnish ?? GeneralUtility::makeInstance(Varnish::class);
        return $this->varnish;
    }

}


1			<?php
2			namespace Aoe\Varnish\TYPO3\Hooks;
3
4			/***************************************************************
5			* Copyright notice
6			*
7			* (c) 2018 AOE GmbH <[email protected]>
8			*
9			* All rights reserved
10			*
11			* This script is part of the TYPO3 project. The TYPO3 project is
12			* free software; you can redistribute it and/or modify
13			* it under the terms of the GNU General Public License as published by
14			* the Free Software Foundation; either version 3 of the License, or
15			* (at your option) any later version.
16			*
17			* The GNU General Public License can be found at
18			* http://www.gnu.org/copyleft/gpl.html.
19			*
20			* This script is distributed in the hope that it will be useful,
21			* but WITHOUT ANY WARRANTY; without even the implied warranty of
22			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
23			* GNU General Public License for more details.
24			*
25			* This copyright notice MUST APPEAR in all copies of the script!
26			***************************************************************/
27
28			use Aoe\Varnish\System\Varnish;
29			use TYPO3\CMS\Core\Utility\GeneralUtility;
30
31			abstract class AbstractHook
32			{
33			/**
34			* @var Varnish
35			*/
36			protected $varnish;
37
38			/**
39			* @var \TYPO3\CMS\Extbase\Object\ObjectManagerInterface $objectManager
40			*/
41			protected $objectManager;
42
43			public function injectObjectManager(ObjectManagerInterface $objectManager): void
44			{
45			$this->objectManager = $objectManager;
			0 ignored issues – show Documentation Bug introduced 2021-05-25 13:21 UTC by Report Bug Copy Issue Report It seems like `$objectManager` of type `object<Aoe\Varnish\TYPO3...ObjectManagerInterface>` is incompatible with the declared type `object<TYPO3\CMS\Extbase...ObjectManagerInterface>` of property `$objectManager`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
46			}
47
48			protected function getVarnish(): Varnish
49			{
50			$this->varnish = $this->varnish ?? GeneralUtility::makeInstance(Varnish::class);
51			return $this->varnish;
52			}
53
54			}
55

AOEpeople / TYPO3-varnish

Pull Request — master (#10)

AbstractHook::getVarnish() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like